From: Li Feng <fengli@smartx.com>
To: "Markus Armbruster" <armbru@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Raphael Norwitz" <raphael.norwitz@nutanix.com>,
"Kevin Wolf" <kwolf@redhat.com>,
"Hanna Reitz" <hreitz@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Fam Zheng" <fam@euphon.net>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Viresh Kumar" <viresh.kumar@linaro.org>,
qemu-block@nongnu.org (open list:Block layer core),
qemu-devel@nongnu.org (open list:All patches CC here)
Cc: Li Feng <fengli@smartx.com>
Subject: [PATCH v5 2/5] vhost: move and rename the conn retry times
Date: Tue, 19 Sep 2023 19:40:23 +0800 [thread overview]
Message-ID: <20230919114030.280414-3-fengli@smartx.com> (raw)
In-Reply-To: <20230919114030.280414-1-fengli@smartx.com>
Multiple devices need this macro, move it to a common header.
Signed-off-by: Li Feng <fengli@smartx.com>
Reviewed-by: Raphael Norwitz <raphael.norwitz@nutanix.com>
---
hw/block/vhost-user-blk.c | 4 +---
hw/virtio/vhost-user-gpio.c | 3 +--
include/hw/virtio/vhost.h | 2 ++
3 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/hw/block/vhost-user-blk.c b/hw/block/vhost-user-blk.c
index eecf3f7a81..3c69fa47d5 100644
--- a/hw/block/vhost-user-blk.c
+++ b/hw/block/vhost-user-blk.c
@@ -32,8 +32,6 @@
#include "sysemu/sysemu.h"
#include "sysemu/runstate.h"
-#define REALIZE_CONNECTION_RETRIES 3
-
static const int user_feature_bits[] = {
VIRTIO_BLK_F_SIZE_MAX,
VIRTIO_BLK_F_SEG_MAX,
@@ -482,7 +480,7 @@ static void vhost_user_blk_device_realize(DeviceState *dev, Error **errp)
s->inflight = g_new0(struct vhost_inflight, 1);
s->vhost_vqs = g_new0(struct vhost_virtqueue, s->num_queues);
- retries = REALIZE_CONNECTION_RETRIES;
+ retries = VU_REALIZE_CONN_RETRIES;
assert(!*errp);
do {
if (*errp) {
diff --git a/hw/virtio/vhost-user-gpio.c b/hw/virtio/vhost-user-gpio.c
index 3b013f2d0f..d9979aa5db 100644
--- a/hw/virtio/vhost-user-gpio.c
+++ b/hw/virtio/vhost-user-gpio.c
@@ -15,7 +15,6 @@
#include "standard-headers/linux/virtio_ids.h"
#include "trace.h"
-#define REALIZE_CONNECTION_RETRIES 3
#define VHOST_NVQS 2
/* Features required from VirtIO */
@@ -359,7 +358,7 @@ static void vu_gpio_device_realize(DeviceState *dev, Error **errp)
qemu_chr_fe_set_handlers(&gpio->chardev, NULL, NULL, vu_gpio_event, NULL,
dev, NULL, true);
- retries = REALIZE_CONNECTION_RETRIES;
+ retries = VU_REALIZE_CONN_RETRIES;
g_assert(!*errp);
do {
if (*errp) {
diff --git a/include/hw/virtio/vhost.h b/include/hw/virtio/vhost.h
index 6a173cb9fa..ca3131b1af 100644
--- a/include/hw/virtio/vhost.h
+++ b/include/hw/virtio/vhost.h
@@ -8,6 +8,8 @@
#define VHOST_F_DEVICE_IOTLB 63
#define VHOST_USER_F_PROTOCOL_FEATURES 30
+#define VU_REALIZE_CONN_RETRIES 3
+
/* Generic structures common for any vhost based device. */
struct vhost_inflight {
--
2.41.0
next prev parent reply other threads:[~2023-09-19 11:43 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 10:51 [PATCH] vhost-user-scsi: support reconnect to backend Li Feng
2023-07-24 17:21 ` Raphael Norwitz
2023-07-24 20:30 ` Michael S. Tsirkin
2023-07-25 10:19 ` Li Feng
2023-07-27 21:21 ` Raphael Norwitz
2023-07-28 7:48 ` Li Feng
2023-07-30 22:09 ` Raphael Norwitz
2023-07-31 11:32 ` Li Feng
2023-07-25 10:42 ` [PATCH v2 0/4] Implement reconnect for vhost-user-scsi Li Feng
2023-07-25 10:42 ` [PATCH v2 1/4] vhost: fix the fd leak Li Feng
2023-07-30 22:09 ` Raphael Norwitz
2023-07-25 10:42 ` [PATCH v2 2/4] vhost-user-common: send get_inflight_fd once Li Feng
2023-07-28 6:04 ` Michael S. Tsirkin
2023-07-28 7:49 ` Li Feng
2023-07-30 22:13 ` Raphael Norwitz
2023-07-31 11:38 ` Li Feng
2023-07-31 23:11 ` Raphael Norwitz
2023-07-25 10:42 ` [PATCH v2 3/4] vhost: move and rename the conn retry times Li Feng
2023-07-30 22:13 ` Raphael Norwitz
2023-07-25 10:42 ` [PATCH v2 4/4] vhost-user-scsi: support reconnect to backend Li Feng
2023-07-25 10:58 ` Li Feng
2023-07-30 22:14 ` Raphael Norwitz
2023-07-31 10:24 ` Li Feng
2023-07-31 12:10 ` [PATCH v3 0/5] Implement reconnect for vhost-user-scsi Li Feng
2023-07-31 12:10 ` [PATCH v3 1/5] vhost: fix the fd leak Li Feng
2023-08-03 13:41 ` Fiona Ebner
2023-07-31 12:10 ` [PATCH v3 2/5] vhost-user-common: send get_inflight_fd once Li Feng
2023-07-31 23:34 ` Raphael Norwitz
2023-07-31 12:10 ` [PATCH v3 3/5] vhost: move and rename the conn retry times Li Feng
2023-07-31 12:10 ` [PATCH v3 4/5] vhost-user-scsi: support reconnect to backend Li Feng
2023-07-31 23:35 ` Raphael Norwitz
2023-09-01 12:00 ` Markus Armbruster
2023-09-12 8:29 ` Li Feng
2023-07-31 12:10 ` [PATCH v3 5/5] vhost-user-scsi: start vhost when guest kicks Li Feng
2023-07-31 23:35 ` Raphael Norwitz
2023-09-01 11:44 ` Markus Armbruster
2023-09-12 7:53 ` Li Feng
2023-09-12 8:52 ` [PATCH v4 0/5] Implement reconnect for vhost-user-scsi Li Feng
2023-09-12 8:52 ` [PATCH v4 1/5] vhost-user-common: send get_inflight_fd once Li Feng
2023-09-12 8:52 ` [PATCH v4 2/5] vhost: move and rename the conn retry times Li Feng
2023-09-12 8:52 ` [PATCH v4 3/5] vhost-user-scsi: support reconnect to backend Li Feng
2023-09-12 8:52 ` [PATCH v4 4/5] vhost-user-scsi: start vhost when guest kicks Li Feng
2023-09-12 8:52 ` [PATCH v4 5/5] vhost-user: fix lost reconnect Li Feng
2023-09-19 11:40 ` [PATCH v5 0/5] Implement reconnect for vhost-user-scsi Li Feng
2023-09-19 11:40 ` [PATCH v5 1/5] vhost-user-common: send get_inflight_fd once Li Feng
2023-09-19 11:40 ` Li Feng [this message]
2023-09-19 11:40 ` [PATCH v5 3/5] vhost-user-scsi: support reconnect to backend Li Feng
2023-09-19 11:40 ` [PATCH v5 4/5] vhost-user-scsi: start vhost when guest kicks Li Feng
2023-09-19 11:40 ` [PATCH v5 5/5] vhost-user: fix lost reconnect Li Feng
2023-09-22 11:46 ` [PATCH v6 0/5] Implement reconnect for vhost-user-scsi Li Feng
2023-09-22 11:46 ` [PATCH v6 1/5] vhost-user-common: send get_inflight_fd once Li Feng
2023-09-29 0:54 ` Raphael Norwitz
2023-10-08 8:49 ` Li Feng
2023-10-08 8:50 ` Michael S. Tsirkin
2023-10-08 8:53 ` Li Feng
2023-09-22 11:46 ` [PATCH v6 2/5] vhost: move and rename the conn retry times Li Feng
2023-09-22 11:46 ` [PATCH v6 3/5] vhost-user-scsi: support reconnect to backend Li Feng
2023-09-29 0:55 ` Raphael Norwitz
2023-10-08 8:45 ` Li Feng
2023-09-22 11:46 ` [PATCH v6 4/5] vhost-user-scsi: start vhost when guest kicks Li Feng
2023-09-29 0:55 ` Raphael Norwitz
2023-09-22 11:46 ` [PATCH v6 5/5] vhost-user: fix lost reconnect Li Feng
2023-09-29 0:55 ` Raphael Norwitz
2023-09-29 0:55 ` Raphael Norwitz
2023-10-08 8:49 ` [PATCH v6 0/5] Implement reconnect for vhost-user-scsi Michael S. Tsirkin
2023-10-08 8:53 ` Li Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230919114030.280414-3-fengli@smartx.com \
--to=fengli@smartx.com \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=fam@euphon.net \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=raphael.norwitz@nutanix.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).