qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: deller@kernel.org
To: qemu-devel@nongnu.org
Cc: Helge Deller <deller@gmx.de>,
	Richard Henderson <richard.henderson@linaro.org>,
	Laurent Vivier <laurent@vivier.eu>,
	Mikulas Patocka <mpatocka@redhat.com>,
	qemu-stable@nongnu.org
Subject: [PULL v2 8/8] linux-user/hppa: lock both words of function descriptor
Date: Tue, 19 Sep 2023 21:17:56 +0200	[thread overview]
Message-ID: <20230919191757.98889-9-deller@kernel.org> (raw)
In-Reply-To: <20230919191757.98889-1-deller@kernel.org>

From: Mikulas Patocka <mpatocka@redhat.com>

The code in setup_rt_frame reads two words at haddr, but locks only one.
This patch fixes it to lock both.

Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Acked-by: Helge Deller <deller@gmx.de>
Cc: qemu-stable@nongnu.org
Signed-off-by: Helge Deller <deller@gmx.de>
---
 linux-user/hppa/signal.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/linux-user/hppa/signal.c b/linux-user/hppa/signal.c
index 3a976ac693..bda6e54655 100644
--- a/linux-user/hppa/signal.c
+++ b/linux-user/hppa/signal.c
@@ -149,12 +149,13 @@ void setup_rt_frame(int sig, struct target_sigaction *ka,
         target_ulong *fdesc, dest;
 
         haddr &= -4;
-        if (!lock_user_struct(VERIFY_READ, fdesc, haddr, 1)) {
+        fdesc = lock_user(VERIFY_READ, haddr, 2 * sizeof(target_ulong), 1);
+        if (!fdesc) {
             goto give_sigsegv;
         }
         __get_user(dest, fdesc);
         __get_user(env->gr[19], fdesc + 1);
-        unlock_user_struct(fdesc, haddr, 1);
+        unlock_user(fdesc, haddr, 0);
         haddr = dest;
     }
     env->iaoq_f = haddr;
-- 
2.41.0



  parent reply	other threads:[~2023-09-19 19:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-19 19:17 [PULL v2 0/8] Hppa btlb patches deller
2023-09-19 19:17 ` [PULL v2 1/8] target/hppa: Update to SeaBIOS-hppa version 9 deller
2023-09-19 19:17 ` [PULL v2 2/8] target/hppa: Allow up to 16 BTLB entries deller
2023-09-19 19:17 ` [PULL v2 3/8] target/hppa: Report and clear BTLBs via fw_cfg at startup deller
2023-09-19 19:17 ` [PULL v2 4/8] target/hppa: Add BTLB support to hppa TLB functions deller
2023-09-19 19:17 ` [PULL v2 5/8] target/hppa: Extract diagnose immediate value deller
2023-09-19 19:17 ` [PULL v2 6/8] target/hppa: Wire up diag instruction to support BTLB deller
2023-09-19 19:17 ` [PULL v2 7/8] linux-user/hppa: clear the PSW 'N' bit when delivering signals deller
2023-09-19 19:17 ` deller [this message]
2023-09-20 20:05 ` [PULL v2 0/8] Hppa btlb patches Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230919191757.98889-9-deller@kernel.org \
    --to=deller@kernel.org \
    --cc=deller@gmx.de \
    --cc=laurent@vivier.eu \
    --cc=mpatocka@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).