From: Victor Toso <victortoso@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Markus Armbruster" <armbru@redhat.com>,
"John Snow" <jsnow@redhat.com>,
"Daniel P . Berrangé" <berrange@redhat.com>
Subject: [PATCH v3 00/10] Validate and test qapi examples
Date: Tue, 19 Sep 2023 22:18:47 +0200 [thread overview]
Message-ID: <20230919201857.675913-1-victortoso@redhat.com> (raw)
Hi,
v2: https://lists.gnu.org/archive/html/qemu-devel/2023-09/msg02383.html
- Sorry Markus, I kept the two last 'fix example' patches as I don't
fully remember how we should go with it. Not taking them but taking
the generator would be bad as we would fail the build.
- Removed the meson flag suggested by Philippe to take the pragma suggestion from Markus, the
interesting diff is:
--- a/scripts/qapi/dumpexamples.py
+++ b/scripts/qapi/dumpexamples.py
@@ -119,6 +119,10 @@ def parse_examples_of(self: QAPISchemaGenExamplesVisitor,
assert(name in self.schema._entity_dict)
obj = self.schema._entity_dict[name]
+
+ if not obj.info.pragma.doc_required:
+ return
+
assert((obj.doc is not None))
module_name = obj._module.name
which avoid failures with tests that don't have any docs.
Cheers,
Victor
Victor Toso (10):
qapi: fix example of get-win32-socket command
qapi: fix example of dumpdtb command
qapi: fix example of cancel-vcpu-dirty-limit command
qapi: fix example of set-vcpu-dirty-limit command
qapi: fix example of calc-dirty-rate command
qapi: fix example of NETDEV_STREAM_CONNECTED event
qapi: fix example of query-blockstats command
qapi: fix example of query-rocker-of-dpa-flows command
qapi: fix example of query-spice command
qapi: scripts: add a generator for qapi's examples
qapi/block-core.json | 32 +++---
qapi/machine.json | 2 +-
qapi/migration.json | 6 +-
qapi/misc.json | 2 +-
qapi/net.json | 6 +-
qapi/rocker.json | 3 +-
qapi/ui.json | 3 +-
scripts/qapi/dumpexamples.py | 208 +++++++++++++++++++++++++++++++++++
scripts/qapi/main.py | 3 +-
9 files changed, 236 insertions(+), 29 deletions(-)
create mode 100644 scripts/qapi/dumpexamples.py
--
2.41.0
next reply other threads:[~2023-09-19 20:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-19 20:18 Victor Toso [this message]
2023-09-19 20:18 ` [PATCH v3 01/10] qapi: fix example of get-win32-socket command Victor Toso
2023-09-19 20:18 ` [PATCH v3 02/10] qapi: fix example of dumpdtb command Victor Toso
2023-09-19 20:18 ` [PATCH v3 03/10] qapi: fix example of cancel-vcpu-dirty-limit command Victor Toso
2023-09-19 20:18 ` [PATCH v3 04/10] qapi: fix example of set-vcpu-dirty-limit command Victor Toso
2023-09-19 20:18 ` [PATCH v3 05/10] qapi: fix example of calc-dirty-rate command Victor Toso
2023-09-19 20:18 ` [PATCH v3 06/10] qapi: fix example of NETDEV_STREAM_CONNECTED event Victor Toso
2023-09-19 20:18 ` [PATCH v3 07/10] qapi: fix example of query-blockstats command Victor Toso
2023-09-19 20:18 ` [PATCH v3 08/10] qapi: fix example of query-rocker-of-dpa-flows command Victor Toso
2023-09-19 20:18 ` [PATCH v3 09/10] qapi: fix example of query-spice command Victor Toso
2023-09-19 20:18 ` [PATCH v3 10/10] qapi: scripts: add a generator for qapi's examples Victor Toso
2023-09-21 11:06 ` Markus Armbruster
2023-10-18 19:35 ` Victor Toso
2023-10-19 6:26 ` Markus Armbruster
2023-09-21 11:21 ` [PATCH v3 00/10] Validate and test qapi examples Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230919201857.675913-1-victortoso@redhat.com \
--to=victortoso@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=jsnow@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).