From: "Denis V. Lunev" via <qemu-devel@nongnu.org>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, "Denis V. Lunev" <den@openvz.org>,
Alexander Ivanov <alexander.ivanov@virtuozzo.com>
Subject: [PULL v2 15/22] parallels: accept multiple clusters in mark_used()
Date: Thu, 21 Sep 2023 09:54:53 +0200 [thread overview]
Message-ID: <20230921075500.694585-16-den@openvz.org> (raw)
In-Reply-To: <20230921075500.694585-1-den@openvz.org>
This would be useful in the next patch in allocate_clusters(). This
change would not imply serious performance drawbacks as usually image
is full of data or are at the end of the bitmap.
Signed-off-by: Denis V. Lunev <den@openvz.org>
Reviewed-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
---
block/parallels.c | 18 ++++++++++--------
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/block/parallels.c b/block/parallels.c
index a997880c34..3df73aa8a0 100644
--- a/block/parallels.c
+++ b/block/parallels.c
@@ -178,18 +178,20 @@ static void parallels_set_bat_entry(BDRVParallelsState *s,
bitmap_set(s->bat_dirty_bmap, bat_entry_off(index) / s->bat_dirty_block, 1);
}
-static int mark_used(BlockDriverState *bs,
- unsigned long *bitmap, uint32_t bitmap_size, int64_t off)
+static int mark_used(BlockDriverState *bs, unsigned long *bitmap,
+ uint32_t bitmap_size, int64_t off, uint32_t count)
{
BDRVParallelsState *s = bs->opaque;
uint32_t cluster_index = host_cluster_index(s, off);
- if (cluster_index >= bitmap_size) {
+ unsigned long next_used;
+ if (cluster_index + count > bitmap_size) {
return -E2BIG;
}
- if (test_bit(cluster_index, bitmap)) {
+ next_used = find_next_bit(bitmap, bitmap_size, cluster_index);
+ if (next_used < cluster_index + count) {
return -EBUSY;
}
- bitmap_set(bitmap, cluster_index, 1);
+ bitmap_set(bitmap, cluster_index, count);
return 0;
}
@@ -230,7 +232,7 @@ static int parallels_fill_used_bitmap(BlockDriverState *bs)
continue;
}
- err2 = mark_used(bs, s->used_bmap, s->used_bmap_size, host_off);
+ err2 = mark_used(bs, s->used_bmap, s->used_bmap_size, host_off, 1);
if (err2 < 0 && err == 0) {
err = err2;
}
@@ -732,7 +734,7 @@ parallels_check_duplicate(BlockDriverState *bs, BdrvCheckResult *res,
continue;
}
- ret = mark_used(bs, bitmap, bitmap_size, host_off);
+ ret = mark_used(bs, bitmap, bitmap_size, host_off, 1);
assert(ret != -E2BIG);
if (ret == 0) {
continue;
@@ -792,7 +794,7 @@ parallels_check_duplicate(BlockDriverState *bs, BdrvCheckResult *res,
* considered, and the bitmap size doesn't change. This specifically
* means that -E2BIG is OK.
*/
- ret = mark_used(bs, bitmap, bitmap_size, host_off);
+ ret = mark_used(bs, bitmap, bitmap_size, host_off, 1);
if (ret == -EBUSY) {
res->check_errors++;
goto out_repair_bat;
--
2.34.1
next prev parent reply other threads:[~2023-09-21 7:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 7:54 [PULL v2 00/22] implement discard operation for Parallels images Denis V. Lunev via
2023-09-21 7:54 ` [PULL v2 01/22] parallels: fix formatting in bdrv_parallels initialization Denis V. Lunev via
2023-09-21 7:54 ` [PULL v2 02/22] parallels: mark driver as supporting CBT Denis V. Lunev via
2023-09-21 7:54 ` [PULL v2 03/22] parallels: fix memory leak in parallels_open() Denis V. Lunev via
2023-09-21 7:54 ` [PULL v2 04/22] parallels: invent parallels_opts_prealloc() helper to parse prealloc opts Denis V. Lunev via
2023-09-21 7:54 ` [PULL v2 05/22] parallels: return earler in fail_format branch in parallels_open() Denis V. Lunev via
2023-09-21 7:54 ` [PULL v2 06/22] parallels: return earlier from parallels_open() function on error Denis V. Lunev via
2023-09-21 7:54 ` [PULL v2 07/22] parallels: refactor path when we need to re-check image in parallels_open Denis V. Lunev via
2023-09-21 7:54 ` [PULL v2 08/22] parallels: create mark_used() helper which sets bit in used bitmap Denis V. Lunev via
2023-09-21 7:54 ` [PULL v2 09/22] tests: ensure that image validation will not cure the corruption Denis V. Lunev via
2023-09-21 7:54 ` [PULL v2 10/22] parallels: fix broken parallels_check_data_off() Denis V. Lunev via
2023-09-21 7:54 ` [PULL v2 11/22] parallels: add test which will validate data_off fixes through repair Denis V. Lunev via
2023-09-21 7:54 ` [PULL v2 12/22] parallels: collect bitmap of used clusters at open Denis V. Lunev via
2023-09-21 7:54 ` [PULL v2 13/22] tests: fix broken deduplication check in parallels format test Denis V. Lunev via
2023-09-21 7:54 ` [PULL v2 14/22] tests: test self-cure of parallels image with duplicated clusters Denis V. Lunev via
2023-09-21 7:54 ` Denis V. Lunev via [this message]
2023-09-21 7:54 ` [PULL v2 16/22] parallels: update used bitmap in allocate_cluster Denis V. Lunev via
2023-09-21 7:54 ` [PULL v2 17/22] parallels: naive implementation of allocate_clusters with used bitmap Denis V. Lunev via
2023-09-21 7:54 ` [PULL v2 18/22] parallels: improve readability of allocate_clusters Denis V. Lunev via
2023-09-21 7:54 ` [PULL v2 19/22] parallels: naive implementation of parallels_co_pdiscard Denis V. Lunev via
2023-09-21 7:54 ` [PULL v2 20/22] tests: extend test 131 to cover availability of the discard operation Denis V. Lunev via
2023-09-21 7:54 ` [PULL v2 21/22] parallels: naive implementation of parallels_co_pwrite_zeroes Denis V. Lunev via
2023-09-21 7:55 ` [PULL v2 22/22] tests: extend test 131 to cover availability of the write-zeroes Denis V. Lunev via
2023-09-21 15:16 ` [PULL v2 00/22] implement discard operation for Parallels images Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230921075500.694585-16-den@openvz.org \
--to=qemu-devel@nongnu.org \
--cc=alexander.ivanov@virtuozzo.com \
--cc=den@openvz.org \
--cc=qemu-block@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).