From: "Denis V. Lunev" via <qemu-devel@nongnu.org>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, "Denis V. Lunev" <den@openvz.org>,
Alexander Ivanov <alexander.ivanov@virtuozzo.com>
Subject: [PULL v2 02/22] parallels: mark driver as supporting CBT
Date: Thu, 21 Sep 2023 09:54:40 +0200 [thread overview]
Message-ID: <20230921075500.694585-3-den@openvz.org> (raw)
In-Reply-To: <20230921075500.694585-1-den@openvz.org>
Parallels driver indeed support Parallels Dirty Bitmap Feature in
read-only mode. The patch adds bdrv_supports_persistent_dirty_bitmap()
callback which always return 1 to indicate that.
This will allow to copy CBT from Parallels image with qemu-img.
Note: read-write support is signalled through
bdrv_co_can_store_new_dirty_bitmap() and is different.
Signed-off-by: Denis V. Lunev <den@openvz.org>
Reviewed-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
---
block/parallels.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/block/parallels.c b/block/parallels.c
index 2ebd8e1301..428f72de1c 100644
--- a/block/parallels.c
+++ b/block/parallels.c
@@ -1248,6 +1248,11 @@ static void parallels_close(BlockDriverState *bs)
error_free(s->migration_blocker);
}
+static bool parallels_is_support_dirty_bitmaps(BlockDriverState *bs)
+{
+ return 1;
+}
+
static BlockDriver bdrv_parallels = {
.format_name = "parallels",
.instance_size = sizeof(BDRVParallelsState),
@@ -1256,6 +1261,7 @@ static BlockDriver bdrv_parallels = {
.supports_backing = true,
.bdrv_has_zero_init = bdrv_has_zero_init_1,
+ .bdrv_supports_persistent_dirty_bitmap = parallels_is_support_dirty_bitmaps,
.bdrv_probe = parallels_probe,
.bdrv_open = parallels_open,
--
2.34.1
next prev parent reply other threads:[~2023-09-21 7:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 7:54 [PULL v2 00/22] implement discard operation for Parallels images Denis V. Lunev via
2023-09-21 7:54 ` [PULL v2 01/22] parallels: fix formatting in bdrv_parallels initialization Denis V. Lunev via
2023-09-21 7:54 ` Denis V. Lunev via [this message]
2023-09-21 7:54 ` [PULL v2 03/22] parallels: fix memory leak in parallels_open() Denis V. Lunev via
2023-09-21 7:54 ` [PULL v2 04/22] parallels: invent parallels_opts_prealloc() helper to parse prealloc opts Denis V. Lunev via
2023-09-21 7:54 ` [PULL v2 05/22] parallels: return earler in fail_format branch in parallels_open() Denis V. Lunev via
2023-09-21 7:54 ` [PULL v2 06/22] parallels: return earlier from parallels_open() function on error Denis V. Lunev via
2023-09-21 7:54 ` [PULL v2 07/22] parallels: refactor path when we need to re-check image in parallels_open Denis V. Lunev via
2023-09-21 7:54 ` [PULL v2 08/22] parallels: create mark_used() helper which sets bit in used bitmap Denis V. Lunev via
2023-09-21 7:54 ` [PULL v2 09/22] tests: ensure that image validation will not cure the corruption Denis V. Lunev via
2023-09-21 7:54 ` [PULL v2 10/22] parallels: fix broken parallels_check_data_off() Denis V. Lunev via
2023-09-21 7:54 ` [PULL v2 11/22] parallels: add test which will validate data_off fixes through repair Denis V. Lunev via
2023-09-21 7:54 ` [PULL v2 12/22] parallels: collect bitmap of used clusters at open Denis V. Lunev via
2023-09-21 7:54 ` [PULL v2 13/22] tests: fix broken deduplication check in parallels format test Denis V. Lunev via
2023-09-21 7:54 ` [PULL v2 14/22] tests: test self-cure of parallels image with duplicated clusters Denis V. Lunev via
2023-09-21 7:54 ` [PULL v2 15/22] parallels: accept multiple clusters in mark_used() Denis V. Lunev via
2023-09-21 7:54 ` [PULL v2 16/22] parallels: update used bitmap in allocate_cluster Denis V. Lunev via
2023-09-21 7:54 ` [PULL v2 17/22] parallels: naive implementation of allocate_clusters with used bitmap Denis V. Lunev via
2023-09-21 7:54 ` [PULL v2 18/22] parallels: improve readability of allocate_clusters Denis V. Lunev via
2023-09-21 7:54 ` [PULL v2 19/22] parallels: naive implementation of parallels_co_pdiscard Denis V. Lunev via
2023-09-21 7:54 ` [PULL v2 20/22] tests: extend test 131 to cover availability of the discard operation Denis V. Lunev via
2023-09-21 7:54 ` [PULL v2 21/22] parallels: naive implementation of parallels_co_pwrite_zeroes Denis V. Lunev via
2023-09-21 7:55 ` [PULL v2 22/22] tests: extend test 131 to cover availability of the write-zeroes Denis V. Lunev via
2023-09-21 15:16 ` [PULL v2 00/22] implement discard operation for Parallels images Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230921075500.694585-3-den@openvz.org \
--to=qemu-devel@nongnu.org \
--cc=alexander.ivanov@virtuozzo.com \
--cc=den@openvz.org \
--cc=qemu-block@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).