From: "Michael S. Tsirkin" <mst@redhat.com>
To: Ani Sinha <anisinha@redhat.com>
Cc: "Markus Armbruster" <armbru@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>,
"Alberto Garcia" <berto@igalia.com>,
"Alistair Francis" <alistair.francis@wdc.com>,
"Andrew Jeffery" <andrew@aj.id.au>,
"Brian Cain" <bcain@quicinc.com>,
"Cédric Le Goater" <clg@kaod.org>,
"Daniel Henrique Barboza" <danielhb413@gmail.com>,
"Daniel P. Berrange" <berrange@redhat.com>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Eric Auger" <eric.auger@redhat.com>,
"Eric Blake" <eblake@redhat.com>, "Fam Zheng" <fam@euphon.net>,
"Fan Ni" <fan.ni@samsung.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Joel Stanley" <joel@jms.id.au>,
"Jonathan Cameron" <jonathan.cameron@huawei.com>,
"Keith Busch" <kbusch@kernel.org>,
"Klaus Jensen" <its@irrelevant.dk>,
"Laurent Vivier" <laurent@vivier.eu>,
"Laurent Vivier" <lvivier@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Marcelo Tosatti" <mtosatti@redhat.com>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Peter Xu" <peterx@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Song Gao" <gaosong@loongson.cn>,
"Thomas Huth" <thuth@redhat.com>,
"Vladimir Sementsov-Ogievskiy" <vsementsov@yandex-team.ru>,
"Xiaojuan Yang" <yangxiaojuan@loongson.cn>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: Help wanted for enabling -Wshadow=local
Date: Fri, 22 Sep 2023 06:36:19 -0400 [thread overview]
Message-ID: <20230922063552-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <5255ABB8-8D1D-4AF4-9015-84573056973C@redhat.com>
On Fri, Sep 22, 2023 at 04:03:27PM +0530, Ani Sinha wrote:
>
>
> > On 22-Sep-2023, at 3:07 PM, Markus Armbruster <armbru@redhat.com> wrote:
> >
> > Devices
> > -------
> > ACPI/SMBIOS
> > M: Michael S. Tsirkin <mst@redhat.com>
> > M: Igor Mammedov <imammedo@redhat.com>
> > R: Ani Sinha <anisinha@redhat.com>
> > hw/acpi/cpu_hotplug.c
> > hw/i386/acpi-build.c(*3*)
> > hw/smbios/smbios.c
>
> I will look into this after enabling
>
> diff --git a/meson.build b/meson.build
> index 98e68ef0b1..9fc4c7ac9d 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -466,6 +466,9 @@ warn_flags = [
> '-Wno-tautological-type-limit-compare',
> '-Wno-psabi',
> '-Wno-gnu-variable-sized-type-not-at-end',
> + '-Wshadow=local',
> + '-Wno-error=shadow=local',
> + '-Wno-error=shadow=compatible-local',
> ]
Am I right that one can equivalently do
./configure --disable-werror --extra-cflags='-Wshadow=local -Wno-error=shadow=local -Wno-error=shadow=compatible-local'
?
next prev parent reply other threads:[~2023-09-22 10:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 9:37 Help wanted for enabling -Wshadow=local Markus Armbruster
2023-09-22 10:33 ` Ani Sinha
2023-09-22 10:36 ` Michael S. Tsirkin [this message]
2023-09-22 11:25 ` Markus Armbruster
2023-09-22 14:03 ` Peter Maydell
2023-09-22 15:26 ` Markus Armbruster
2023-09-22 15:31 ` Markus Armbruster
2023-09-22 16:32 ` Daniel Henrique Barboza
2023-09-22 17:00 ` Ani Sinha
2023-09-22 17:43 ` Daniel Henrique Barboza
2023-09-22 17:48 ` Peter Maydell
2023-09-22 18:59 ` Warner Losh
2023-09-23 12:33 ` Peter Maydell
2023-09-25 16:37 ` Warner Losh
2023-09-23 6:10 ` Markus Armbruster
2023-09-23 7:22 ` Markus Armbruster
2023-09-25 11:47 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230922063552-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=alistair.francis@wdc.com \
--cc=andrew@aj.id.au \
--cc=anisinha@redhat.com \
--cc=armbru@redhat.com \
--cc=bcain@quicinc.com \
--cc=berrange@redhat.com \
--cc=berto@igalia.com \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=eric.auger@redhat.com \
--cc=fam@euphon.net \
--cc=fan.ni@samsung.com \
--cc=gaosong@loongson.cn \
--cc=imammedo@redhat.com \
--cc=its@irrelevant.dk \
--cc=jasowang@redhat.com \
--cc=joel@jms.id.au \
--cc=jonathan.cameron@huawei.com \
--cc=kbusch@kernel.org \
--cc=kraxel@redhat.com \
--cc=laurent@vivier.eu \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mtosatti@redhat.com \
--cc=npiggin@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
--cc=vsementsov@yandex-team.ru \
--cc=yangxiaojuan@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).