From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Martin Kletzander <mkletzan@redhat.com>
Subject: [PULL 10/12] audio/spiceaudio: Fail initialisation when not using spice
Date: Fri, 22 Sep 2023 11:31:23 +0200 [thread overview]
Message-ID: <20230922093126.264016-11-pbonzini@redhat.com> (raw)
In-Reply-To: <20230922093126.264016-1-pbonzini@redhat.com>
From: Martin Kletzander <mkletzan@redhat.com>
The caller would already fail, but this way the message can better
express the reason for the failure.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2043498
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
Message-ID: <5db1fdef0330f20ed6ae306b5a71dad1b5e9b44c.1650874791.git.mkletzan@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
audio/spiceaudio.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/audio/spiceaudio.c b/audio/spiceaudio.c
index d17ef1a25ef..af9bd7d54c9 100644
--- a/audio/spiceaudio.c
+++ b/audio/spiceaudio.c
@@ -74,8 +74,9 @@ static const SpiceRecordInterface record_sif = {
static void *spice_audio_init(Audiodev *dev)
{
if (!using_spice) {
- return NULL;
+ error_setg(&error_fatal, "Cannot use spice audio without -spice");
}
+
return &spice_audio_init;
}
--
2.41.0
next prev parent reply other threads:[~2023-09-22 9:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 9:31 [PULL 00/12] Audio, i386 patches for 2022-09-22 Paolo Bonzini
2023-09-22 9:31 ` [PULL 01/12] target/i386: enumerate bit 56 of MSR_IA32_VMX_BASIC Paolo Bonzini
2023-09-22 9:31 ` [PULL 02/12] target/i386: Export GDS_NO bit to guests Paolo Bonzini
2023-09-22 9:31 ` [PULL 03/12] qemu/timer: Add host ticks function for RISC-V Paolo Bonzini
2023-09-22 9:31 ` [PULL 04/12] audio: remove QEMU_AUDIO_* and -audio-help support Paolo Bonzini
2023-09-22 9:31 ` [PULL 05/12] hw/input/tsc210x: Extract common init code into new function Paolo Bonzini
2023-09-22 9:31 ` [PULL 06/12] hw/audio: Simplify hda audio init Paolo Bonzini
2023-09-22 9:31 ` [PULL 07/12] hw/audio/lm4549: Add errp error reporting to init function Paolo Bonzini
2023-09-22 9:31 ` [PULL 08/12] hw/display/xlnx_dp.c: Add audiodev property Paolo Bonzini
2023-09-22 9:31 ` [PULL 09/12] tests/qtest: Specify audiodev= and -audiodev Paolo Bonzini
2023-09-22 9:31 ` Paolo Bonzini [this message]
2023-09-22 9:31 ` [PULL 11/12] ui/vnc: Require audiodev= to enable audio Paolo Bonzini
2023-09-22 9:31 ` [PULL 12/12] audio: Require AudioState in AUD_add_capture Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230922093126.264016-11-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=mkletzan@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).