From: Fabiano Rosas <farosas@suse.de>
To: qemu-devel@nongnu.org
Cc: Juan Quintela <quintela@redhat.com>, Peter Xu <peterx@redhat.com>,
Leonardo Bras <leobras@redhat.com>,
Elena Ufimtseva <elena.ufimtseva@oracle.com>
Subject: [RFC PATCH 0/3] migration/multifd: SYNC packet changes
Date: Fri, 22 Sep 2023 11:53:16 -0300 [thread overview]
Message-ID: <20230922145319.27380-1-farosas@suse.de> (raw)
I'm putting this RFC out early so we can discuss the issues around the
SYNC packet of the multifd protocol. There's a related series posted
by Elena Ufimtseva:
https://lore.kernel.org/r/20230922065625.21848-1-elena.ufimtseva@oracle.com
My interest in this (aside from correctness) is that when doing the
(upcoming) fixed-ram[1] migration, I would like to have multifd ignore
the concept of packets altogether, since the file: migration is not
synchronous.
The main problem I hit is that multifd (ab)uses the knowledge that a
sync packet is sent after a batch of pages and relies (perhaps
inadvertently) on the last post to sem_sync to finish the
migration. Which means that without the sync, the main thread just
rushes and does cleanup while packets are still in flight.
I have add another patch to this series that introduces a
multifd-nopackets option (placeholder name), but it's probably too
early to discuss that so I'm leaving it out.
1- https://lore.kernel.org/r/20230330180336.2791-1-farosas@suse.de
Fabiano Rosas (3):
migration/multifd: Move channels_ready semaphore
migration/multifd: Decouple control flow from the SYNC packet
migration/multifd: Extract sem_done waiting into a function
migration/multifd.c | 97 +++++++++++++++++++++++++-----------------
migration/multifd.h | 8 ++--
migration/trace-events | 2 +-
3 files changed, 63 insertions(+), 44 deletions(-)
--
2.35.3
next reply other threads:[~2023-09-22 14:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 14:53 Fabiano Rosas [this message]
2023-09-22 14:53 ` [RFC PATCH 1/3] migration/multifd: Move channels_ready semaphore Fabiano Rosas
2023-09-22 22:33 ` Elena Ufimtseva
2023-09-29 14:41 ` Fabiano Rosas
2023-10-10 21:00 ` Peter Xu
2023-10-10 21:40 ` Peter Xu
2023-10-10 21:43 ` Fabiano Rosas
2023-10-10 21:59 ` Peter Xu
2023-09-22 14:53 ` [RFC PATCH 2/3] migration/multifd: Decouple control flow from the SYNC packet Fabiano Rosas
2023-09-22 14:53 ` [RFC PATCH 3/3] migration/multifd: Extract sem_done waiting into a function Fabiano Rosas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230922145319.27380-1-farosas@suse.de \
--to=farosas@suse.de \
--cc=elena.ufimtseva@oracle.com \
--cc=leobras@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).