qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Karim Taha <kariem.taha2.7@gmail.com>
To: qemu-devel@nongnu.org
Cc: Richard Henderson <richard.henderson@linaro.org>,
	Warner Losh <imp@bsdimp.com>, Stacey Son <sson@FreeBSD.org>,
	Karim Taha <kariem.taha2.7@gmail.com>
Subject: [PATCH v4 23/28] bsd-user: Implement wait4(2) and wait6(2) system calls.
Date: Mon, 25 Sep 2023 00:01:31 +0300	[thread overview]
Message-ID: <20230924210136.11966-24-kariem.taha2.7@gmail.com> (raw)
In-Reply-To: <20230924210136.11966-1-kariem.taha2.7@gmail.com>

From: Stacey Son <sson@FreeBSD.org>

Signed-off-by: Stacey Son <sson@FreeBSD.org>
Signed-off-by: Karim Taha <kariem.taha2.7@gmail.com>
---
 bsd-user/freebsd/os-proc.h    | 84 +++++++++++++++++++++++++++++++++++
 bsd-user/freebsd/os-syscall.c | 15 +++++++
 2 files changed, 99 insertions(+)

diff --git a/bsd-user/freebsd/os-proc.h b/bsd-user/freebsd/os-proc.h
index 75ed39f8dd..04bce755e5 100644
--- a/bsd-user/freebsd/os-proc.h
+++ b/bsd-user/freebsd/os-proc.h
@@ -30,6 +30,10 @@
 
 #include "target_arch_cpu.h"
 
+pid_t safe_wait4(pid_t wpid, int *status, int options, struct rusage *rusage);
+pid_t safe_wait6(idtype_t idtype, id_t id, int *status, int options,
+    struct __wrusage *wrusage, siginfo_t *infop);
+
 /* execve(2) */
 static inline abi_long do_freebsd_execve(abi_ulong path_or_fd, abi_ulong argp,
         abi_ulong envp)
@@ -46,4 +50,84 @@ static inline abi_long do_freebsd_fexecve(abi_ulong path_or_fd, abi_ulong argp,
     return freebsd_exec_common(path_or_fd, argp, envp, 1);
 }
 
+/* wait4(2) */
+static inline abi_long do_freebsd_wait4(abi_long arg1, abi_ulong target_status,
+        abi_long arg3, abi_ulong target_rusage)
+{
+    abi_long ret;
+    int status;
+    struct rusage rusage, *rusage_ptr = NULL;
+
+    if (target_rusage) {
+        rusage_ptr = &rusage;
+    }
+    ret = get_errno(safe_wait4(arg1, &status, arg3, rusage_ptr));
+
+    if (ret < 0) {
+        return ret;
+    }
+    if (target_status != 0) {
+        status = host_to_target_waitstatus(status);
+        if (put_user_s32(status, target_status) != 0) {
+            return -TARGET_EFAULT;
+        }
+    }
+    if (target_rusage != 0) {
+        host_to_target_rusage(target_rusage, &rusage);
+    }
+    return ret;
+}
+
+/* wait6(2) */
+static inline abi_long do_freebsd_wait6(void *cpu_env, abi_long idtype,
+    abi_long id1, abi_long id2,
+    abi_ulong target_status, abi_long options, abi_ulong target_wrusage,
+    abi_ulong target_infop, abi_ulong pad1)
+{
+    abi_long ret;
+    int status;
+    struct __wrusage wrusage, *wrusage_ptr = NULL;
+    siginfo_t info;
+    void *p;
+
+    if (regpairs_aligned(cpu_env) != 0) {
+        /* printf("shifting args\n"); */
+        /* 64-bit id is aligned, so shift all the arguments over by one */
+        id1 = id2;
+        id2 = target_status;
+        target_status = options;
+        options = target_wrusage;
+        target_wrusage = target_infop;
+        target_infop = pad1;
+    }
+
+    if (target_wrusage) {
+        wrusage_ptr = &wrusage;
+    }
+    ret = get_errno(safe_wait6(idtype, target_arg64(id1, id2),
+                               &status, options, wrusage_ptr, &info));
+
+    if (ret < 0) {
+        return ret;
+    }
+    if (target_status != 0) {
+        status = host_to_target_waitstatus(status);
+        if (put_user_s32(status, target_status) != 0) {
+            return -TARGET_EFAULT;
+        }
+    }
+    if (target_wrusage != 0) {
+        host_to_target_wrusage(target_wrusage, &wrusage);
+    }
+    if (target_infop != 0) {
+        p = lock_user(VERIFY_WRITE, target_infop, sizeof(target_siginfo_t), 0);
+        if (p == NULL) {
+            return -TARGET_EFAULT;
+        }
+        host_to_target_siginfo(p, &info);
+        unlock_user(p, target_infop, sizeof(target_siginfo_t));
+    }
+    return ret;
+}
+
 #endif /* BSD_USER_FREEBSD_OS_PROC_H */
diff --git a/bsd-user/freebsd/os-syscall.c b/bsd-user/freebsd/os-syscall.c
index 515eaaf31f..55e68e4815 100644
--- a/bsd-user/freebsd/os-syscall.c
+++ b/bsd-user/freebsd/os-syscall.c
@@ -40,6 +40,12 @@
 #include "os-stat.h"
 #include "os-proc.h"
 
+/* used in os-proc */
+safe_syscall4(pid_t, wait4, pid_t, wpid, int *, status, int, options,
+    struct rusage *, rusage);
+safe_syscall6(pid_t, wait6, idtype_t, idtype, id_t, id, int *, status, int,
+    options, struct __wrusage *, wrusage, siginfo_t *, infop);
+
 /* I/O */
 safe_syscall3(int, open, const char *, path, int, flags, mode_t, mode);
 safe_syscall4(int, openat, int, fd, const char *, path, int, flags, mode_t,
@@ -228,6 +234,15 @@ static abi_long freebsd_syscall(void *cpu_env, int num, abi_long arg1,
         ret = do_freebsd_fexecve(arg1, arg2, arg3);
         break;
 
+    case TARGET_FREEBSD_NR_wait4: /* wait4(2) */
+        ret = do_freebsd_wait4(arg1, arg2, arg3, arg4);
+        break;
+
+    case TARGET_FREEBSD_NR_wait6: /* wait6(2) */
+        ret = do_freebsd_wait6(cpu_env, arg1, arg2, arg3,
+                               arg4, arg5, arg6, arg7, arg8);
+        break;
+
     case TARGET_FREEBSD_NR_exit: /* exit(2) */
         ret = do_bsd_exit(cpu_env, arg1);
         break;
-- 
2.42.0



  parent reply	other threads:[~2023-09-25  2:39 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-24 21:01 [PATCH v4 00/28] bsd-user: Implement freebsd process related system calls Karim Taha
2023-09-24 21:01 ` [PATCH v4 01/28] bsd-user: define TARGET_RFSPAWN for rfork to use vfork(2) semantics, and fix RLIM_INFINITY Karim Taha
2023-09-24 21:01 ` [PATCH v4 02/28] bsd-user: Define procctl(2) related structs Karim Taha
2023-09-24 21:01 ` [PATCH v4 03/28] bsd-user: Implement host_to_target_siginfo Karim Taha
2023-09-24 21:01 ` [PATCH v4 04/28] bsd-user: Add freebsd_exec_common and do_freebsd_procctl to qemu.h Karim Taha
2023-09-24 21:01 ` [PATCH v4 05/28] bsd-user: add extern declarations for bsd-proc.c conversion functions Karim Taha
2023-09-24 21:01 ` [PATCH v4 06/28] bsd-user: Implement target_to_host_resource conversion function Karim Taha
2023-09-25 15:46   ` Warner Losh
2023-09-24 21:01 ` [PATCH v4 07/28] bsd-user: Implement target_to_host_rlim and host_to_target_rlim conversion Karim Taha
2023-09-24 21:01 ` [PATCH v4 08/28] bsd-user: Implement host_to_target_rusage and host_to_target_wrusage Karim Taha
2023-09-24 21:01 ` [PATCH v4 09/28] bsd-user: Implement host_to_target_waitstatus conversion Karim Taha
2023-09-24 21:01 ` [PATCH v4 10/28] bsd-user: Get number of cpus Karim Taha
2023-09-24 21:01 ` [PATCH v4 11/28] bsd-user: Implement getgroups(2) and setgroups(2) system calls Karim Taha
2023-09-24 21:01 ` [PATCH v4 12/28] bsd-user: Implement umask(2), setlogin(2) and getlogin(2) Karim Taha
2023-09-25 15:47   ` Warner Losh
2023-09-24 21:01 ` [PATCH v4 13/28] bsd-user: Implement getrusage(2) Karim Taha
2023-09-24 21:01 ` [PATCH v4 14/28] bsd-user: Implement getrlimit(2) and setrlimit(2) Karim Taha
2023-09-24 21:01 ` [PATCH v4 15/28] bsd-user: Implement several get/set system calls: Karim Taha
2023-09-24 21:01 ` [PATCH v4 16/28] bsd-user: Implement get/set[resuid/resgid/sid] and issetugid Karim Taha
2023-09-24 21:01 ` [PATCH v4 17/28] bsd-user: Add stubs for profil(2), ktrace(2), utrace(2) and ptrace(2) Karim Taha
2023-09-24 21:01 ` [PATCH v4 18/28] bsd-user: Implement getpriority(2) and setpriority(2) Karim Taha
2023-09-24 21:01 ` [PATCH v4 19/28] bsd-user: Implement get_filename_from_fd Karim Taha
2023-09-24 21:01 ` [PATCH v4 20/28] bsd-user: Implement freebsd_exec_common, used in implementing execve/fexecve Karim Taha
2023-09-24 21:01 ` [PATCH v4 21/28] bsd-user: Implement procctl(2) along with necessary conversion functions Karim Taha
2023-09-25 15:49   ` Warner Losh
2023-09-24 21:01 ` [PATCH v4 22/28] bsd-user: Implement execve(2) and fexecve(2) system calls Karim Taha
2023-09-24 21:01 ` Karim Taha [this message]
2023-09-25 15:52   ` [PATCH v4 23/28] bsd-user: Implement wait4(2) and wait6(2) " Warner Losh
2023-09-24 21:01 ` [PATCH v4 24/28] bsd-user: Implement setloginclass(2) and getloginclass(2) " Karim Taha
2023-09-25 15:56   ` Warner Losh
2023-09-24 21:01 ` [PATCH v4 25/28] bsd-user: Implement pdgetpid(2) and the undocumented setugid Karim Taha
2023-09-25 15:57   ` Warner Losh
2023-09-24 21:01 ` [PATCH v4 26/28] bsd-user: Implement fork(2) and vfork(2) system calls Karim Taha
2023-09-24 21:01 ` [PATCH v4 27/28] bsd-user: Implement rfork(2) system call Karim Taha
2023-09-24 21:01 ` [PATCH v4 28/28] bsd-user: Implement pdfork(2) " Karim Taha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230924210136.11966-24-kariem.taha2.7@gmail.com \
    --to=kariem.taha2.7@gmail.com \
    --cc=imp@bsdimp.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=sson@FreeBSD.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).