From: Karim Taha <kariem.taha2.7@gmail.com>
To: qemu-devel@nongnu.org
Cc: Richard Henderson <richard.henderson@linaro.org>,
Warner Losh <imp@bsdimp.com>, Stacey Son <sson@FreeBSD.org>,
Karim Taha <kariem.taha2.7@gmail.com>
Subject: [PATCH v4 27/28] bsd-user: Implement rfork(2) system call.
Date: Mon, 25 Sep 2023 00:01:35 +0300 [thread overview]
Message-ID: <20230924210136.11966-28-kariem.taha2.7@gmail.com> (raw)
In-Reply-To: <20230924210136.11966-1-kariem.taha2.7@gmail.com>
From: Stacey Son <sson@FreeBSD.org>
Signed-off-by: Stacey Son <sson@FreeBSD.org>
Signed-off-by: Karim Taha <kariem.taha2.7@gmail.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Warner Losh <imp@bsdimp.com>
---
bsd-user/freebsd/os-proc.h | 39 +++++++++++++++++++++++++++++++++++
bsd-user/freebsd/os-syscall.c | 4 ++++
2 files changed, 43 insertions(+)
diff --git a/bsd-user/freebsd/os-proc.h b/bsd-user/freebsd/os-proc.h
index 7b2e6a9f79..0a3cd0ef57 100644
--- a/bsd-user/freebsd/os-proc.h
+++ b/bsd-user/freebsd/os-proc.h
@@ -219,4 +219,43 @@ static inline abi_long do_freebsd_vfork(void *cpu_env)
return do_freebsd_fork(cpu_env);
}
+/* rfork(2) */
+static inline abi_long do_freebsd_rfork(void *cpu_env, abi_long flags)
+{
+ abi_long ret;
+ abi_ulong child_flag;
+
+ /*
+ * XXX We need to handle RFMEM here, as well. Neither are safe to execute
+ * as-is on x86 hosts because they'll split memory but not the stack,
+ * wreaking havoc on host architectures that use the stack to store the
+ * return address as both threads try to pop it off. Rejecting RFSPAWN
+ * entirely for now is ok, the only consumer at the moment is posix_spawn
+ * and it will fall back to classic vfork(2) if we return EINVAL.
+ */
+ if ((flags & TARGET_RFSPAWN) != 0) {
+ return -TARGET_EINVAL;
+ }
+ fork_start();
+ ret = rfork(flags);
+ if (ret == 0) {
+ /* child */
+ child_flag = 1;
+ target_cpu_clone_regs(cpu_env, 0);
+ } else {
+ /* parent */
+ child_flag = 0;
+ }
+
+ /*
+ * The fork system call sets a child flag in the second return
+ * value: 0 for parent process, 1 for child process.
+ */
+ set_second_rval(cpu_env, child_flag);
+ fork_end(child_flag);
+
+ return ret;
+
+}
+
#endif /* BSD_USER_FREEBSD_OS_PROC_H */
diff --git a/bsd-user/freebsd/os-syscall.c b/bsd-user/freebsd/os-syscall.c
index cb9425c9ba..4c4e773d1d 100644
--- a/bsd-user/freebsd/os-syscall.c
+++ b/bsd-user/freebsd/os-syscall.c
@@ -234,6 +234,10 @@ static abi_long freebsd_syscall(void *cpu_env, int num, abi_long arg1,
ret = do_freebsd_vfork(cpu_env);
break;
+ case TARGET_FREEBSD_NR_rfork: /* rfork(2) */
+ ret = do_freebsd_rfork(cpu_env, arg1);
+ break;
+
case TARGET_FREEBSD_NR_execve: /* execve(2) */
ret = do_freebsd_execve(arg1, arg2, arg3);
break;
--
2.42.0
next prev parent reply other threads:[~2023-09-25 2:40 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-24 21:01 [PATCH v4 00/28] bsd-user: Implement freebsd process related system calls Karim Taha
2023-09-24 21:01 ` [PATCH v4 01/28] bsd-user: define TARGET_RFSPAWN for rfork to use vfork(2) semantics, and fix RLIM_INFINITY Karim Taha
2023-09-24 21:01 ` [PATCH v4 02/28] bsd-user: Define procctl(2) related structs Karim Taha
2023-09-24 21:01 ` [PATCH v4 03/28] bsd-user: Implement host_to_target_siginfo Karim Taha
2023-09-24 21:01 ` [PATCH v4 04/28] bsd-user: Add freebsd_exec_common and do_freebsd_procctl to qemu.h Karim Taha
2023-09-24 21:01 ` [PATCH v4 05/28] bsd-user: add extern declarations for bsd-proc.c conversion functions Karim Taha
2023-09-24 21:01 ` [PATCH v4 06/28] bsd-user: Implement target_to_host_resource conversion function Karim Taha
2023-09-25 15:46 ` Warner Losh
2023-09-24 21:01 ` [PATCH v4 07/28] bsd-user: Implement target_to_host_rlim and host_to_target_rlim conversion Karim Taha
2023-09-24 21:01 ` [PATCH v4 08/28] bsd-user: Implement host_to_target_rusage and host_to_target_wrusage Karim Taha
2023-09-24 21:01 ` [PATCH v4 09/28] bsd-user: Implement host_to_target_waitstatus conversion Karim Taha
2023-09-24 21:01 ` [PATCH v4 10/28] bsd-user: Get number of cpus Karim Taha
2023-09-24 21:01 ` [PATCH v4 11/28] bsd-user: Implement getgroups(2) and setgroups(2) system calls Karim Taha
2023-09-24 21:01 ` [PATCH v4 12/28] bsd-user: Implement umask(2), setlogin(2) and getlogin(2) Karim Taha
2023-09-25 15:47 ` Warner Losh
2023-09-24 21:01 ` [PATCH v4 13/28] bsd-user: Implement getrusage(2) Karim Taha
2023-09-24 21:01 ` [PATCH v4 14/28] bsd-user: Implement getrlimit(2) and setrlimit(2) Karim Taha
2023-09-24 21:01 ` [PATCH v4 15/28] bsd-user: Implement several get/set system calls: Karim Taha
2023-09-24 21:01 ` [PATCH v4 16/28] bsd-user: Implement get/set[resuid/resgid/sid] and issetugid Karim Taha
2023-09-24 21:01 ` [PATCH v4 17/28] bsd-user: Add stubs for profil(2), ktrace(2), utrace(2) and ptrace(2) Karim Taha
2023-09-24 21:01 ` [PATCH v4 18/28] bsd-user: Implement getpriority(2) and setpriority(2) Karim Taha
2023-09-24 21:01 ` [PATCH v4 19/28] bsd-user: Implement get_filename_from_fd Karim Taha
2023-09-24 21:01 ` [PATCH v4 20/28] bsd-user: Implement freebsd_exec_common, used in implementing execve/fexecve Karim Taha
2023-09-24 21:01 ` [PATCH v4 21/28] bsd-user: Implement procctl(2) along with necessary conversion functions Karim Taha
2023-09-25 15:49 ` Warner Losh
2023-09-24 21:01 ` [PATCH v4 22/28] bsd-user: Implement execve(2) and fexecve(2) system calls Karim Taha
2023-09-24 21:01 ` [PATCH v4 23/28] bsd-user: Implement wait4(2) and wait6(2) " Karim Taha
2023-09-25 15:52 ` Warner Losh
2023-09-24 21:01 ` [PATCH v4 24/28] bsd-user: Implement setloginclass(2) and getloginclass(2) " Karim Taha
2023-09-25 15:56 ` Warner Losh
2023-09-24 21:01 ` [PATCH v4 25/28] bsd-user: Implement pdgetpid(2) and the undocumented setugid Karim Taha
2023-09-25 15:57 ` Warner Losh
2023-09-24 21:01 ` [PATCH v4 26/28] bsd-user: Implement fork(2) and vfork(2) system calls Karim Taha
2023-09-24 21:01 ` Karim Taha [this message]
2023-09-24 21:01 ` [PATCH v4 28/28] bsd-user: Implement pdfork(2) system call Karim Taha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230924210136.11966-28-kariem.taha2.7@gmail.com \
--to=kariem.taha2.7@gmail.com \
--cc=imp@bsdimp.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=sson@FreeBSD.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).