* [PATCH] hw/nvme: Clean up local variable shadowing in nvme_ns_init()
@ 2023-09-25 6:05 Klaus Jensen
2023-09-26 16:51 ` Jesper Wendel Devantier
2023-09-29 6:57 ` Markus Armbruster
0 siblings, 2 replies; 3+ messages in thread
From: Klaus Jensen @ 2023-09-25 6:05 UTC (permalink / raw)
To: Keith Busch, Klaus Jensen
Cc: qemu-block, qemu-devel, Markus Armbruster, Klaus Jensen
From: Klaus Jensen <k.jensen@samsung.com>
Fix local variable shadowing in nvme_ns_init().
Reported-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
---
hw/nvme/ns.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/nvme/ns.c b/hw/nvme/ns.c
index 44aba8f4d9cf..0eabcf5cf500 100644
--- a/hw/nvme/ns.c
+++ b/hw/nvme/ns.c
@@ -107,7 +107,7 @@ static int nvme_ns_init(NvmeNamespace *ns, Error **errp)
ns->pif = ns->params.pif;
- static const NvmeLBAF lbaf[16] = {
+ static const NvmeLBAF defaults[16] = {
[0] = { .ds = 9 },
[1] = { .ds = 9, .ms = 8 },
[2] = { .ds = 9, .ms = 16 },
@@ -120,7 +120,7 @@ static int nvme_ns_init(NvmeNamespace *ns, Error **errp)
ns->nlbaf = 8;
- memcpy(&id_ns->lbaf, &lbaf, sizeof(lbaf));
+ memcpy(&id_ns->lbaf, &defaults, sizeof(defaults));
for (i = 0; i < ns->nlbaf; i++) {
NvmeLBAF *lbaf = &id_ns->lbaf[i];
---
base-commit: b55e4b9c0525560577384adfc6d30eb0daa8d7be
change-id: 20230925-fix-local-shadowing-9606793e8ae9
Best regards,
--
Klaus Jensen <k.jensen@samsung.com>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] hw/nvme: Clean up local variable shadowing in nvme_ns_init()
2023-09-25 6:05 [PATCH] hw/nvme: Clean up local variable shadowing in nvme_ns_init() Klaus Jensen
@ 2023-09-26 16:51 ` Jesper Wendel Devantier
2023-09-29 6:57 ` Markus Armbruster
1 sibling, 0 replies; 3+ messages in thread
From: Jesper Wendel Devantier @ 2023-09-26 16:51 UTC (permalink / raw)
To: Klaus Jensen
Cc: Keith Busch, qemu-block, Markus Armbruster, Klaus Jensen,
qemu-devel
Klaus Jensen <its@irrelevant.dk> writes:
> From: Klaus Jensen <k.jensen@samsung.com>
>
> Fix local variable shadowing in nvme_ns_init().
>
> Reported-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
> ---
> hw/nvme/ns.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/nvme/ns.c b/hw/nvme/ns.c
> index 44aba8f4d9cf..0eabcf5cf500 100644
> --- a/hw/nvme/ns.c
> +++ b/hw/nvme/ns.c
> @@ -107,7 +107,7 @@ static int nvme_ns_init(NvmeNamespace *ns, Error **errp)
>
> ns->pif = ns->params.pif;
>
> - static const NvmeLBAF lbaf[16] = {
> + static const NvmeLBAF defaults[16] = {
> [0] = { .ds = 9 },
> [1] = { .ds = 9, .ms = 8 },
> [2] = { .ds = 9, .ms = 16 },
> @@ -120,7 +120,7 @@ static int nvme_ns_init(NvmeNamespace *ns, Error **errp)
>
> ns->nlbaf = 8;
>
> - memcpy(&id_ns->lbaf, &lbaf, sizeof(lbaf));
> + memcpy(&id_ns->lbaf, &defaults, sizeof(defaults));
>
> for (i = 0; i < ns->nlbaf; i++) {
> NvmeLBAF *lbaf = &id_ns->lbaf[i];
>
> ---
> base-commit: b55e4b9c0525560577384adfc6d30eb0daa8d7be
> change-id: 20230925-fix-local-shadowing-9606793e8ae9
>
> Best regards,
>
Reviewed-by: Jesper Wendel Devantier <j.devantier@samsung.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hw/nvme: Clean up local variable shadowing in nvme_ns_init()
2023-09-25 6:05 [PATCH] hw/nvme: Clean up local variable shadowing in nvme_ns_init() Klaus Jensen
2023-09-26 16:51 ` Jesper Wendel Devantier
@ 2023-09-29 6:57 ` Markus Armbruster
1 sibling, 0 replies; 3+ messages in thread
From: Markus Armbruster @ 2023-09-29 6:57 UTC (permalink / raw)
To: Klaus Jensen; +Cc: Keith Busch, qemu-block, qemu-devel, Klaus Jensen
Klaus Jensen <its@irrelevant.dk> writes:
> From: Klaus Jensen <k.jensen@samsung.com>
>
> Fix local variable shadowing in nvme_ns_init().
>
> Reported-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
Queued, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-29 6:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-25 6:05 [PATCH] hw/nvme: Clean up local variable shadowing in nvme_ns_init() Klaus Jensen
2023-09-26 16:51 ` Jesper Wendel Devantier
2023-09-29 6:57 ` Markus Armbruster
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).