* [PATCH] ui/vnc: fix debug output for invalid audio message
@ 2023-09-25 14:50 Paolo Bonzini
2023-09-25 15:45 ` Daniel P. Berrangé
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Bonzini @ 2023-09-25 14:50 UTC (permalink / raw)
To: qemu-devel; +Cc: berrange
The debug message was cut and pasted from the invalid audio format
case, but the audio message is at bytes 2-3.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
ui/vnc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui/vnc.c b/ui/vnc.c
index 3d13757b72b..acb494d18a0 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -2551,7 +2551,7 @@ static int protocol_client_msg(VncState *vs, uint8_t *data, size_t len)
vs, vs->ioc, vs->as.fmt, vs->as.nchannels, vs->as.freq);
break;
default:
- VNC_DEBUG("Invalid audio message %d\n", read_u8(data, 4));
+ VNC_DEBUG("Invalid audio message %d\n", read_u8(data, 2));
vnc_client_error(vs);
break;
}
--
2.41.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ui/vnc: fix debug output for invalid audio message
2023-09-25 14:50 [PATCH] ui/vnc: fix debug output for invalid audio message Paolo Bonzini
@ 2023-09-25 15:45 ` Daniel P. Berrangé
0 siblings, 0 replies; 2+ messages in thread
From: Daniel P. Berrangé @ 2023-09-25 15:45 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-devel
On Mon, Sep 25, 2023 at 04:50:51PM +0200, Paolo Bonzini wrote:
> The debug message was cut and pasted from the invalid audio format
> case, but the audio message is at bytes 2-3.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> ui/vnc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ui/vnc.c b/ui/vnc.c
> index 3d13757b72b..acb494d18a0 100644
> --- a/ui/vnc.c
> +++ b/ui/vnc.c
> @@ -2551,7 +2551,7 @@ static int protocol_client_msg(VncState *vs, uint8_t *data, size_t len)
> vs, vs->ioc, vs->as.fmt, vs->as.nchannels, vs->as.freq);
> break;
> default:
> - VNC_DEBUG("Invalid audio message %d\n", read_u8(data, 4));
> + VNC_DEBUG("Invalid audio message %d\n", read_u8(data, 2));
> vnc_client_error(vs);
> break;
> }
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-09-25 15:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-25 14:50 [PATCH] ui/vnc: fix debug output for invalid audio message Paolo Bonzini
2023-09-25 15:45 ` Daniel P. Berrangé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).