qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Nina Schoetterl-Glausch <nsg@linux.ibm.com>
To: qemu-devel@nongnu.org, qemu-s390x@nongnu.org,
	Eduardo Habkost <eduardo@habkost.net>,
	Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Richard Henderson <richard.henderson@linaro.org>,
	David Hildenbrand <david@redhat.com>,
	Halil Pasic <pasic@linux.ibm.com>,
	Christian Borntraeger <borntraeger@linux.ibm.com>,
	Eric Farman <farman@linux.ibm.com>,
	Thomas Huth <thuth@redhat.com>, Eric Blake <eblake@redhat.com>,
	Markus Armbruster <armbru@redhat.com>,
	Michael Roth <michael.roth@amd.com>,
	Nina Schoetterl-Glausch <nsg@linux.ibm.com>
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Yanan Wang" <wangyanan55@huawei.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Ilya Leoshkevich" <iii@linux.ibm.com>,
	"Cleber Rosa" <crosa@redhat.com>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Beraldo Leal" <bleal@redhat.com>
Subject: [PATCH v24 01/21] qapi: machine.json: change docs regarding CpuInstanceProperties
Date: Tue, 26 Sep 2023 14:15:14 +0200	[thread overview]
Message-ID: <20230926121534.406035-2-nsg@linux.ibm.com> (raw)
In-Reply-To: <20230926121534.406035-1-nsg@linux.ibm.com>

Clarify roles of different architectures.
Also change things a bit in anticipation of additional members being
added.

Suggested-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Nina Schoetterl-Glausch <nsg@linux.ibm.com>
---


Reference to s390x docs added in patch 14


 qapi/machine.json | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/qapi/machine.json b/qapi/machine.json
index a08b6576ca..3c074c9902 100644
--- a/qapi/machine.json
+++ b/qapi/machine.json
@@ -70,9 +70,9 @@
 # @qom-path: path to the CPU object in the QOM tree
 #
 # @thread-id: ID of the underlying host thread
-#
-# @props: properties describing to which node/socket/core/thread
-#     virtual CPU belongs to, provided if supported by board
+
+# @props: properties of type CpuInstanceProperties associated with a
+#     virtual CPU, e.g. the socket id
 #
 # @target: the QEMU system emulation target, which determines which
 #     additional fields will be listed (since 3.0)
@@ -899,6 +899,9 @@
 # should be passed by management with device_add command when a CPU is
 # being hotplugged.
 #
+# Which members are optional and which mandatory depends on the architecture
+# and board.
+#
 # @node-id: NUMA node ID the CPU belongs to
 #
 # @socket-id: socket number within node/board the CPU belongs to
@@ -912,15 +915,13 @@
 #
 # @thread-id: thread number within core the CPU belongs to
 #
-# Note: currently there are 6 properties that could be present but
-#     management should be prepared to pass through other properties
-#     with device_add command to allow for future interface extension.
-#     This also requires the filed names to be kept in sync with the
-#     properties passed to -device/device_add.
+# Note: management should be prepared to pass through additional
+# properties with device_add.
 #
 # Since: 2.7
 ##
 { 'struct': 'CpuInstanceProperties',
+  # Keep these in sync with the properties device_add accepts
   'data': { '*node-id': 'int',
             '*socket-id': 'int',
             '*die-id': 'int',
-- 
2.39.2



  reply	other threads:[~2023-09-26 12:21 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-26 12:15 [PATCH v24 00/21] s390x: CPU Topology Nina Schoetterl-Glausch
2023-09-26 12:15 ` Nina Schoetterl-Glausch [this message]
2023-10-12  5:59   ` [PATCH v24 01/21] qapi: machine.json: change docs regarding CpuInstanceProperties Markus Armbruster
2023-10-13 11:46     ` Nina Schoetterl-Glausch
2023-09-26 12:15 ` [PATCH v24 02/21] CPU topology: extend with s390 specifics Nina Schoetterl-Glausch
2023-09-28 11:31   ` Thomas Huth
2023-10-04 16:39   ` Nina Schoetterl-Glausch
2023-10-04 17:32     ` Thomas Huth
2023-09-26 12:15 ` [PATCH v24 03/21] s390x/cpu topology: add topology entries on CPU hotplug Nina Schoetterl-Glausch
2023-09-26 12:15 ` [PATCH v24 04/21] target/s390x/cpu topology: handle STSI(15) and build the SYSIB Nina Schoetterl-Glausch
2023-09-28 13:05   ` Thomas Huth
2023-09-26 12:15 ` [PATCH v24 05/21] s390x/sclp: reporting the maximum nested topology entries Nina Schoetterl-Glausch
2023-09-26 12:15 ` [PATCH v24 06/21] s390x/cpu topology: resetting the Topology-Change-Report Nina Schoetterl-Glausch
2023-09-26 12:15 ` [PATCH v24 07/21] s390x/cpu topology: interception of PTF instruction Nina Schoetterl-Glausch
2023-09-26 12:15 ` [PATCH v24 08/21] target/s390x/cpu topology: activate CPU topology Nina Schoetterl-Glausch
2023-09-26 12:15 ` [PATCH v24 09/21] qapi/s390x/cpu topology: set-cpu-topology qmp command Nina Schoetterl-Glausch
2023-09-28 13:29   ` Thomas Huth
2023-09-26 12:15 ` [PATCH v24 10/21] machine: adding s390 topology to query-cpu-fast Nina Schoetterl-Glausch
2023-09-26 12:15 ` [PATCH v24 11/21] machine: adding s390 topology to info hotpluggable-cpus Nina Schoetterl-Glausch
2023-09-26 12:15 ` [PATCH v24 12/21] qapi/s390x/cpu topology: CPU_POLARIZATION_CHANGE qapi event Nina Schoetterl-Glausch
2023-09-26 12:15 ` [PATCH v24 13/21] qapi/s390x/cpu topology: add query-s390x-cpu-polarization command Nina Schoetterl-Glausch
2023-09-26 12:15 ` [PATCH v24 14/21] docs/s390x/cpu topology: document s390x cpu topology Nina Schoetterl-Glausch
2023-09-26 12:15 ` [PATCH v24 15/21] tests/avocado: s390x cpu topology core Nina Schoetterl-Glausch
2023-09-28 14:54   ` Thomas Huth
2023-09-26 12:15 ` [PATCH v24 16/21] tests/avocado: s390x cpu topology polarization Nina Schoetterl-Glausch
2023-09-26 12:15 ` [PATCH v24 17/21] tests/avocado: s390x cpu topology entitlement tests Nina Schoetterl-Glausch
2023-09-28 14:55   ` Thomas Huth
2023-09-26 12:15 ` [PATCH v24 18/21] tests/avocado: s390x cpu topology test dedicated CPU Nina Schoetterl-Glausch
2023-09-26 12:15 ` [PATCH v24 19/21] tests/avocado: s390x cpu topology test socket full Nina Schoetterl-Glausch
2023-09-26 12:15 ` [PATCH v24 20/21] tests/avocado: s390x cpu topology dedicated errors Nina Schoetterl-Glausch
2023-09-26 12:15 ` [PATCH v24 21/21] tests/avocado: s390x cpu topology bad move Nina Schoetterl-Glausch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230926121534.406035-2-nsg@linux.ibm.com \
    --to=nsg@linux.ibm.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=bleal@redhat.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=crosa@redhat.com \
    --cc=david@redhat.com \
    --cc=eblake@redhat.com \
    --cc=eduardo@habkost.net \
    --cc=farman@linux.ibm.com \
    --cc=iii@linux.ibm.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=michael.roth@amd.com \
    --cc=pasic@linux.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=thuth@redhat.com \
    --cc=wainersm@redhat.com \
    --cc=wangyanan55@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).