From: Stefan Hajnoczi <stefanha@redhat.com>
To: Mads Ynddal <mads@ynddal.dk>
Cc: qemu-devel@nongnu.org, John Snow <jsnow@redhat.com>,
Cleber Rosa <crosa@redhat.com>,
Mads Ynddal <m.ynddal@samsung.com>
Subject: Re: [PATCH v5 00/14] simpletrace: refactor and general improvements
Date: Tue, 26 Sep 2023 12:32:04 -0400 [thread overview]
Message-ID: <20230926163204.GB323273@fedora> (raw)
In-Reply-To: <20230926103436.25700-1-mads@ynddal.dk>
[-- Attachment #1: Type: text/plain, Size: 2779 bytes --]
On Tue, Sep 26, 2023 at 12:34:22PM +0200, Mads Ynddal wrote:
> From: Mads Ynddal <m.ynddal@samsung.com>
>
> I wanted to use simpletrace.py for an internal project, so I tried to update
> and polish the code. Some of the commits resolve specific issues, while some
> are more subjective.
>
> I've tried to divide it into commits so we can discuss the
> individual changes, and I'm ready to pull things out, if it isn't needed.
>
> v5:
> * Picked Formatter2 over Formatter, as to not use the deprecated class
> * simpletrace-benchmark.zip deleted
> * Rebased with master
> v4:
> * Added missing Analyzer2 to __all__
> * Rebased with master
> v3:
> * Added __all__ with public interface
> * Added comment about magic numbers and structs from Stefan Hajnoczi
> * Reintroduced old interface for process, run and Analyzer
> * Added comment about Python 3.6 in ref. to getfullargspec
> * process now accepts events as file-like objects
> * Updated context-manager code for Analyzer
> * Moved logic of event processing to Analyzer class
> * Moved logic of process into _process function
> * Added new Analyzer2 class with kwarg event-processing
> * Reverted changes to process-call in scripts/analyse-locks-simpletrace.py
> v2:
> * Added myself as maintainer of simpletrace.py
> * Improve docstring on `process`
> * Changed call to `process` in scripts/analyse-locks-simpletrace.py to reflect new argument types
> * Replaced `iteritems()` with `items()` in scripts/analyse-locks-simpletrace.py to support Python 3
>
> Mads Ynddal (14):
> simpletrace: add __all__ to define public interface
> simpletrace: annotate magic constants from QEMU code
> simpletrace: improve parsing of sys.argv; fix files never closed.
> simpletrace: changed naming of edict and idtoname to improve
> readability
> simpletrace: update code for Python 3.11
> simpletrace: improved error handling on struct unpack
> simpletrace: define exception and add handling
> simpletrace: made Analyzer into context-manager
> simpletrace: refactor to separate responsibilities
> simpletrace: move logic of process into internal function
> simpletrace: move event processing to Analyzer class
> simpletrace: added simplified Analyzer2 class
> MAINTAINERS: add maintainer of simpletrace.py
> scripts/analyse-locks-simpletrace.py: changed iteritems() to items()
>
> MAINTAINERS | 6 +
> scripts/analyse-locks-simpletrace.py | 2 +-
> scripts/simpletrace.py | 382 +++++++++++++++++----------
> 3 files changed, 246 insertions(+), 144 deletions(-)
>
> --
> 2.38.1
>
Thanks, applied to my tracing tree:
https://gitlab.com/stefanha/qemu/commits/tracing
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2023-09-26 16:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-26 10:34 [PATCH v5 00/14] simpletrace: refactor and general improvements Mads Ynddal
2023-09-26 10:34 ` [PATCH v5 01/14] simpletrace: add __all__ to define public interface Mads Ynddal
2023-09-26 10:34 ` [PATCH v5 02/14] simpletrace: annotate magic constants from QEMU code Mads Ynddal
2023-09-26 10:34 ` [PATCH v5 03/14] simpletrace: improve parsing of sys.argv; fix files never closed Mads Ynddal
2023-09-26 10:34 ` [PATCH v5 04/14] simpletrace: changed naming of edict and idtoname to improve readability Mads Ynddal
2023-09-26 10:34 ` [PATCH v5 05/14] simpletrace: update code for Python 3.11 Mads Ynddal
2023-09-26 10:34 ` [PATCH v5 06/14] simpletrace: improved error handling on struct unpack Mads Ynddal
2023-09-26 10:34 ` [PATCH v5 07/14] simpletrace: define exception and add handling Mads Ynddal
2023-09-26 10:34 ` [PATCH v5 08/14] simpletrace: made Analyzer into context-manager Mads Ynddal
2023-09-26 10:34 ` [PATCH v5 09/14] simpletrace: refactor to separate responsibilities Mads Ynddal
2023-09-26 10:34 ` [PATCH v5 10/14] simpletrace: move logic of process into internal function Mads Ynddal
2023-09-26 10:34 ` [PATCH v5 11/14] simpletrace: move event processing to Analyzer class Mads Ynddal
2023-09-26 10:34 ` [PATCH v5 12/14] simpletrace: added simplified Analyzer2 class Mads Ynddal
2023-09-26 10:34 ` [PATCH v5 13/14] MAINTAINERS: add maintainer of simpletrace.py Mads Ynddal
2023-09-26 10:34 ` [PATCH v5 14/14] scripts/analyse-locks-simpletrace.py: changed iteritems() to items() Mads Ynddal
2023-09-26 16:32 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230926163204.GB323273@fedora \
--to=stefanha@redhat.com \
--cc=crosa@redhat.com \
--cc=jsnow@redhat.com \
--cc=m.ynddal@samsung.com \
--cc=mads@ynddal.dk \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).