qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: eblake@redhat.com
To: qemu-devel@nongnu.org
Cc: Eric Blake <eblake@redhat.com>,
	Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>,
	Peter Maydell <peter.maydell@linaro.org>
Subject: [PATCH] maint: Tweak comment in mailmap to sound friendlier
Date: Tue, 26 Sep 2023 15:39:47 -0500	[thread overview]
Message-ID: <20230926203946.3303600-2-eblake@redhat.com> (raw)

From: Eric Blake <eblake@redhat.com>

Documenting that we should not add new lines to work around SPF
rewrites sounds foreboding; the intent is instead that new lines here
are okay, but indicate a second problem elsewhere in our build process
that we should also consider fixing at the same time, to keep the
section from growing without bounds.

Mentioning DMARC alongside SPF may also help people grep for this
scenario, as well as documenting the 'git config' workaround that can
be used by submitters to avoid the munging issue in the first place.

Fixes: 3bd2608d ("maint: Add .mailmap entries for patches claiming list authorship")
CC: Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>
Cc: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Eric Blake <eblake@redhat.com>
---

I'm sending this email with a temporary 'git config sendemail.from
eblake@redhat.com', to see if the added advice actually adds the extra
line. It did not show up in my editor window, though, so this patch
may need further tweaking to get the instructions right.  Since I
don't normally suffer from SPF/DMARC munging, I may not be the best
person to test the right workaround.  Or maybe 'git config' does not
yet have the right workaround already available as a turnkey solution
we can suggest.

 .mailmap | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/.mailmap b/.mailmap
index 64ef9f4de6f..6fb8202715a 100644
--- a/.mailmap
+++ b/.mailmap
@@ -40,7 +40,16 @@ Nick Hudson <hnick@vmware.com> hnick@vmware.com <hnick@vmware.com>
 # for the cvs2svn initialization commit e63c3dc74bf.

 # Next, translate a few commits where mailman rewrote the From: line due
-# to strict SPF, although we prefer to avoid adding more entries like that.
+# to strict SPF and DMARC.  Usually, our build process should be flagging
+# commits like these before maintainer merges; if you find the need to add
+# a line here, please also report a bug against the part of the build
+# process that let the mis-attribution slip through in the first place.
+#
+# If the mailing list munges your emails, consider using something like
+# 'git config --global sendemail.from your.email@example.com'
+# to add an extra From: line in the body of your email that takes
+# precedence over any munged From: in the mail's headers.
+# See https://lists.openembedded.org/g/openembedded-core/message/166515
 Ed Swierk <eswierk@skyportsystems.com> Ed Swierk via Qemu-devel <qemu-devel@nongnu.org>
 Ian McKellar <ianloic@google.com> Ian McKellar via Qemu-devel <qemu-devel@nongnu.org>
 Julia Suvorova <jusual@mail.ru> Julia Suvorova via Qemu-devel <qemu-devel@nongnu.org>
-- 
2.41.0



             reply	other threads:[~2023-09-26 20:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-26 20:39 eblake [this message]
2023-09-27  9:21 ` [PATCH] maint: Tweak comment in mailmap to sound friendlier Peter Maydell
2023-09-27 10:34 ` Andrey Drobyshev
2023-09-27 14:06   ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230926203946.3303600-2-eblake@redhat.com \
    --to=eblake@redhat.com \
    --cc=andrey.drobyshev@virtuozzo.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).