From: Stefan Hajnoczi <stefanha@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Cc: qemu-devel@nongnu.org, pbonzini@redhat.com,
peter.maydell@linaro.org, yc-core@yandex-team.ru,
davydov-max@yandex-team.ru, alex.chen@huawei.com,
euler.robot@huawei.com, "Fam Zheng" <fam@euphon.net>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Kevin Wolf" <kwolf@redhat.com>,
"Hanna Reitz" <hreitz@redhat.com>,
"open list:NVMe Block Driver" <qemu-block@nongnu.org>
Subject: Re: [PATCH v2 6/8] block/nvme: nvme_process_completion() fix bound for cid
Date: Tue, 26 Sep 2023 16:41:35 -0400 [thread overview]
Message-ID: <20230926204135.GA409047@fedora> (raw)
In-Reply-To: <20230926201532.221152-7-vsementsov@yandex-team.ru>
[-- Attachment #1: Type: text/plain, Size: 745 bytes --]
On Tue, Sep 26, 2023 at 11:15:30PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> NVMeQueuePair::reqs has length NVME_NUM_REQS, which less than
> NVME_QUEUE_SIZE by 1.
>
> Fixes: 1086e95da17050 ("block/nvme: switch to a NVMeRequest freelist")
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
> ---
>
> Cc: stefanha@redhat.com
> Cc: alex.chen@huawei.com
> Cc: euler.robot@huawei.com
>
> Note, that there was similar patch in the past:
> https://patchew.org/QEMU/20201208144452.91172-1-alex.chen@huawei.com/
> I still think, that using NVME_NUM_REQS is better here.
>
> block/nvme.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-09-26 20:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-26 20:15 [PATCH v2 0/8] coverity fixes Vladimir Sementsov-Ogievskiy
2023-09-26 20:15 ` [PATCH v2 1/8] hw/i386/intel_iommu: vtd_slpte_nonzero_rsvd(): assert no overflow Vladimir Sementsov-Ogievskiy
2023-09-26 20:24 ` Peter Maydell
2023-09-26 20:15 ` [PATCH v2 2/8] util/filemonitor-inotify: qemu_file_monitor_watch(): " Vladimir Sementsov-Ogievskiy
2023-09-26 20:25 ` Peter Maydell
2023-09-26 20:15 ` [PATCH v2 3/8] libvhost-user.c: add assertion to vu_message_read_default Vladimir Sementsov-Ogievskiy
2023-09-26 20:15 ` [PATCH v2 4/8] mc146818rtc: rtc_set_time(): initialize tm to zeroes Vladimir Sementsov-Ogievskiy
2023-09-26 20:26 ` Peter Maydell
2023-09-26 20:15 ` [PATCH v2 5/8] pcie_sriov: unregister_vfs(): fix error path Vladimir Sementsov-Ogievskiy
2023-09-26 20:47 ` Vladimir Sementsov-Ogievskiy
2023-09-26 20:15 ` [PATCH v2 6/8] block/nvme: nvme_process_completion() fix bound for cid Vladimir Sementsov-Ogievskiy
2023-09-26 20:41 ` Stefan Hajnoczi [this message]
2023-09-26 20:15 ` [PATCH v2 7/8] hw/core/loader: gunzip(): initialize z_stream Vladimir Sementsov-Ogievskiy
2023-09-26 20:26 ` Peter Maydell
2023-09-26 20:15 ` [PATCH v2 8/8] io/channel-socket: qio_channel_socket_flush(): improve msg validation Vladimir Sementsov-Ogievskiy
2023-09-27 8:06 ` [PATCH v2 0/8] coverity fixes Maksim Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230926204135.GA409047@fedora \
--to=stefanha@redhat.com \
--cc=alex.chen@huawei.com \
--cc=davydov-max@yandex-team.ru \
--cc=euler.robot@huawei.com \
--cc=fam@euphon.net \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@yandex-team.ru \
--cc=yc-core@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).