From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Mads Ynddal <mads@ynddal.dk>, John Snow <jsnow@redhat.com>,
Cleber Rosa <crosa@redhat.com>,
Mads Ynddal <m.ynddal@samsung.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: [PULL 02/14] simpletrace: annotate magic constants from QEMU code
Date: Thu, 28 Sep 2023 09:43:55 -0400 [thread overview]
Message-ID: <20230928134407.568453-3-stefanha@redhat.com> (raw)
In-Reply-To: <20230928134407.568453-1-stefanha@redhat.com>
From: Mads Ynddal <m.ynddal@samsung.com>
It wasn't clear where the constants and structs came from, so I added
comments to help.
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Mads Ynddal <m.ynddal@samsung.com>
Message-id: 20230926103436.25700-3-mads@ynddal.dk
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
scripts/simpletrace.py | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/scripts/simpletrace.py b/scripts/simpletrace.py
index b221d9a241..5c230a1b74 100755
--- a/scripts/simpletrace.py
+++ b/scripts/simpletrace.py
@@ -16,6 +16,11 @@
__all__ = ['Analyzer', 'process', 'run']
+# This is the binary format that the QEMU "simple" trace backend
+# emits. There is no specification documentation because the format is
+# not guaranteed to be stable. Trace files must be parsed with the
+# same trace-events-all file and the same simpletrace.py file that
+# QEMU was built with.
header_event_id = 0xffffffffffffffff
header_magic = 0xf2b177cb0aa429b4
dropped_event_id = 0xfffffffffffffffe
--
2.41.0
next prev parent reply other threads:[~2023-09-28 13:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 13:43 [PULL 00/14] Tracing patches Stefan Hajnoczi
2023-09-28 13:43 ` [PULL 01/14] simpletrace: add __all__ to define public interface Stefan Hajnoczi
2023-09-28 13:43 ` Stefan Hajnoczi [this message]
2023-09-28 13:43 ` [PULL 03/14] simpletrace: improve parsing of sys.argv; fix files never closed Stefan Hajnoczi
2023-09-28 13:43 ` [PULL 04/14] simpletrace: changed naming of edict and idtoname to improve readability Stefan Hajnoczi
2023-09-28 13:43 ` [PULL 05/14] simpletrace: update code for Python 3.11 Stefan Hajnoczi
2023-09-28 13:43 ` [PULL 06/14] simpletrace: improved error handling on struct unpack Stefan Hajnoczi
2023-09-28 13:44 ` [PULL 07/14] simpletrace: define exception and add handling Stefan Hajnoczi
2023-09-28 13:44 ` [PULL 08/14] simpletrace: made Analyzer into context-manager Stefan Hajnoczi
2023-09-28 13:44 ` [PULL 09/14] simpletrace: refactor to separate responsibilities Stefan Hajnoczi
2023-09-28 13:44 ` [PULL 10/14] simpletrace: move logic of process into internal function Stefan Hajnoczi
2023-09-28 13:44 ` [PULL 11/14] simpletrace: move event processing to Analyzer class Stefan Hajnoczi
2023-09-28 13:44 ` [PULL 12/14] simpletrace: added simplified Analyzer2 class Stefan Hajnoczi
2023-09-28 13:44 ` [PULL 13/14] MAINTAINERS: add maintainer of simpletrace.py Stefan Hajnoczi
2023-09-28 13:44 ` [PULL 14/14] scripts/analyse-locks-simpletrace.py: changed iteritems() to items() Stefan Hajnoczi
2023-10-02 21:56 ` [PULL 00/14] Tracing patches Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230928134407.568453-3-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=crosa@redhat.com \
--cc=jsnow@redhat.com \
--cc=m.ynddal@samsung.com \
--cc=mads@ynddal.dk \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).