From: Thomas Huth <huth@tuxfamily.org>
To: qemu-devel@nongnu.org, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Cc: Laurent Vivier <laurent@vivier.eu>
Subject: [PATCH 2/5] hw/scsi/esp: Work around problem with PIO data read for the NeXT-Cube machine
Date: Sat, 30 Sep 2023 15:23:48 +0200 [thread overview]
Message-ID: <20230930132351.30282-3-huth@tuxfamily.org> (raw)
In-Reply-To: <20230930132351.30282-1-huth@tuxfamily.org>
The NeXT-Cube bios uses this mode in its selftest, and without
decreasing the amount of bytes in the fifo here, the selftest
fails.
Signed-off-by: Thomas Huth <huth@tuxfamily.org>
---
hw/scsi/esp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/scsi/esp.c b/hw/scsi/esp.c
index e52188d022..0d54efe826 100644
--- a/hw/scsi/esp.c
+++ b/hw/scsi/esp.c
@@ -961,7 +961,7 @@ uint64_t esp_reg_read(ESPState *s, uint32_t saddr)
(s->rregs[ESP_RSTAT] & STAT_PIO_MASK) == 0) {
/* Data out. */
qemu_log_mask(LOG_UNIMP, "esp: PIO data read not implemented\n");
- s->rregs[ESP_FIFO] = 0;
+ s->rregs[ESP_FIFO] = esp_fifo_pop(&s->fifo);
} else {
if ((s->rregs[ESP_RSTAT] & 0x7) == STAT_DI) {
if (s->ti_size) {
--
2.41.0
next prev parent reply other threads:[~2023-09-30 13:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-30 13:23 [PATCH 0/5] m68k: Instantiate ESP and next-net in the next-cube machine Thomas Huth
2023-09-30 13:23 ` [PATCH 1/5] hw/m68k/next-cube: Mirror BIOS to address 0 Thomas Huth
2023-09-30 13:23 ` Thomas Huth [this message]
2023-09-30 13:23 ` [PATCH 3/5] m68k: Instantiate the ESP SCSI controller for the NeXTcube machine Thomas Huth
2023-09-30 13:23 ` [PATCH 4/5] hw/m68k/next-cube: Remove unused NEXTDMA_EN code Thomas Huth
2023-09-30 13:23 ` [PATCH 5/5] m68k: Add NeXTcube network controller Thomas Huth
2023-10-04 9:11 ` [PATCH 0/5] m68k: Instantiate ESP and next-net in the next-cube machine Mark Cave-Ayland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230930132351.30282-3-huth@tuxfamily.org \
--to=huth@tuxfamily.org \
--cc=laurent@vivier.eu \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).