From: Viktor Prutyanov <viktor@daynix.com>
To: peter.maydell@linaro.org
Cc: qemu-devel@nongnu.org, akihiko.odaki@daynix.com, yan@daynix.com,
viktor@daynix.com, viktor.prutyanov@phystech.edu
Subject: [PATCH 1/2] elf2dmp: limit print length for sign_rsds
Date: Sun, 1 Oct 2023 02:39:21 +0300 [thread overview]
Message-ID: <20230930233922.9969-2-viktor@daynix.com> (raw)
In-Reply-To: <20230930233922.9969-1-viktor@daynix.com>
From: Viktor Prutyanov <viktor.prutyanov@phystech.edu>
String sign_rsds isn't terminated, so the print length must be limited.
Signed-off-by: Viktor Prutyanov <viktor@daynix.com>
---
contrib/elf2dmp/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/elf2dmp/main.c b/contrib/elf2dmp/main.c
index 5db163bdbe..6de5c9808e 100644
--- a/contrib/elf2dmp/main.c
+++ b/contrib/elf2dmp/main.c
@@ -478,7 +478,7 @@ static bool pe_check_pdb_name(uint64_t base, void *start_addr,
}
if (memcmp(&rsds->Signature, sign_rsds, sizeof(sign_rsds))) {
- eprintf("CodeView signature is \'%.4s\', \'%s\' expected\n",
+ eprintf("CodeView signature is \'%.4s\', \'%.4s\' expected\n",
rsds->Signature, sign_rsds);
return false;
}
--
2.21.0
next prev parent reply other threads:[~2023-09-30 23:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-30 23:39 [PATCH 0/2] elf2dmp: fixes of code analysis warnings Viktor Prutyanov
2023-09-30 23:39 ` Viktor Prutyanov [this message]
2023-09-30 23:39 ` [PATCH 2/2] elf2dmp: check array bounds in pdb_get_file_size Viktor Prutyanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230930233922.9969-2-viktor@daynix.com \
--to=viktor@daynix.com \
--cc=akihiko.odaki@daynix.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=viktor.prutyanov@phystech.edu \
--cc=yan@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).