From: "Michael S. Tsirkin" <mst@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Ani Sinha <anisinha@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>,
Philippe Mathieu-Daude <philmd@linaro.org>,
imammedo@redhat.com
Subject: Re: [PULL 38/56] hw/acpi: changes towards enabling -Wshadow=local
Date: Mon, 2 Oct 2023 06:49:21 -0400 [thread overview]
Message-ID: <20231002064738-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <87zg142guv.fsf@pond.sub.org>
On Sat, Sep 30, 2023 at 10:41:12AM +0200, Markus Armbruster wrote:
> Ani Sinha <anisinha@redhat.com> writes:
>
> >> On 29-Sep-2023, at 2:20 PM, Markus Armbruster <armbru@redhat.com> wrote:
> >>
> >> From: Ani Sinha <anisinha@redhat.com>
> >>
> >> Code changes in acpi that addresses all compiler complaints coming from enabling
> >> -Wshadow flags. Enabling -Wshadow catches cases of local variables shadowing
> >> other local variables or parameters. These makes the code confusing and/or adds
> >> bugs that are difficult to catch. See also
> >>
> >> Subject: Help wanted for enabling -Wshadow=local
> >> Message-Id: <87r0mqlf9x.fsf@pond.sub.org>
> >> https://lore.kernel.org/qemu-devel/87r0mqlf9x.fsf@pond.sub.org
> >>
> >> The code is tested to build with and without the flag turned on.
> >>
> >> CC: Markus Armbruster <armbru@redhat.com>
> >> CC: Philippe Mathieu-Daude <philmd@linaro.org>
> >> CC: mst@redhat.com
> >> CC: imammedo@redhat.com
> >> Signed-off-by: Ani Sinha <anisinha@redhat.com>
> >> Message-ID: <20230922124203.127110-1-anisinha@redhat.com>
> >> Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
> >> [Commit message tweaked]
> >> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> >
> > Thanks!
> > Are you not going to pick up "hw/i386: changes towards enabling -Wshadow=local” ?
>
> Your conversation with Michael looked unfinished to me, so I didn't
> include your patch in my pull request. I did add it to shadow-next.
Yes - I clarified what I meant. These patch just always
changed the name of the inner scope variable but that is not
always the best thing to do.
--
MST
next prev parent reply other threads:[~2023-10-02 10:49 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 8:49 [PULL 00/56] -Wshadow=local patches patches for 2023-09-29 Markus Armbruster
2023-09-29 8:49 ` [PULL 01/56] migration/rdma: Fix save_page method to fail on polling error Markus Armbruster
2023-09-29 8:49 ` [PULL 02/56] migration: Clean up local variable shadowing Markus Armbruster
2023-09-29 8:50 ` [PULL 03/56] ui: " Markus Armbruster
2023-09-29 8:50 ` [PULL 04/56] block/dirty-bitmap: " Markus Armbruster
2023-09-29 8:50 ` [PULL 05/56] block/vdi: " Markus Armbruster
2023-09-29 8:50 ` [PULL 06/56] block: " Markus Armbruster
2023-09-29 8:50 ` [PULL 07/56] qobject atomics osdep: Make a few macros more hygienic Markus Armbruster
2023-09-29 8:50 ` [PULL 08/56] tcg: Clean up local variable shadowing Markus Armbruster
2023-09-29 8:50 ` [PULL 09/56] target/arm/tcg: " Markus Armbruster
2023-09-29 8:50 ` [PULL 10/56] target/arm/hvf: " Markus Armbruster
2023-09-29 8:50 ` [PULL 11/56] target/mips: " Markus Armbruster
2023-09-29 8:50 ` [PULL 12/56] target/m68k: " Markus Armbruster
2023-09-29 8:50 ` [PULL 13/56] target/tricore: " Markus Armbruster
2023-09-29 8:50 ` [PULL 14/56] hw/arm/armv7m: " Markus Armbruster
2023-09-29 8:50 ` [PULL 15/56] hw/arm/virt: " Markus Armbruster
2023-09-29 8:50 ` [PULL 16/56] hw/arm/allwinner: " Markus Armbruster
2023-09-29 8:50 ` [PULL 17/56] hw/m68k: " Markus Armbruster
2023-09-29 8:50 ` [PULL 18/56] hw/microblaze: " Markus Armbruster
2023-09-29 8:50 ` [PULL 19/56] hw/nios2: " Markus Armbruster
2023-09-29 8:50 ` [PULL 20/56] net/eth: " Markus Armbruster
2023-09-29 8:50 ` [PULL 21/56] crypto/cipher-gnutls.c: " Markus Armbruster
2023-09-29 8:50 ` [PULL 22/56] util/vhost-user-server: " Markus Armbruster
2023-09-29 8:50 ` [PULL 23/56] linux-user/strace: " Markus Armbruster
2023-09-29 8:50 ` [PULL 24/56] sysemu/device_tree: " Markus Armbruster
2023-09-29 8:50 ` [PULL 25/56] softmmu/memory: " Markus Armbruster
2023-09-29 8:50 ` [PULL 26/56] softmmu/physmem: " Markus Armbruster
2023-09-29 8:50 ` [PULL 27/56] hw/core/machine: " Markus Armbruster
2023-09-29 8:50 ` [PULL 28/56] hw/intc/openpic: " Markus Armbruster
2023-09-29 8:50 ` [PULL 29/56] hw/ppc: Clean up local variable shadowing in _FDT helper routine Markus Armbruster
2023-09-29 8:50 ` [PULL 30/56] pnv/psi: Clean up local variable shadowing Markus Armbruster
2023-09-29 8:50 ` [PULL 31/56] spapr: Clean up local variable shadowing in spapr_dt_cpus() Markus Armbruster
2023-09-29 8:50 ` [PULL 32/56] spapr: Clean up local variable shadowing in spapr_init_cpus() Markus Armbruster
2023-09-29 8:50 ` [PULL 33/56] spapr: Clean up local variable shadowing in spapr_get_fw_dev_path() Markus Armbruster
2023-09-29 8:50 ` [PULL 34/56] spapr/drc: Clean up local variable shadowing in rtas_ibm_configure_connector() Markus Armbruster
2023-09-29 8:50 ` [PULL 35/56] spapr/pci: Clean up local variable shadowing in spapr_phb_realize() Markus Armbruster
2023-09-29 8:50 ` [PULL 36/56] spapr/drc: Clean up local variable shadowing in prop_get_fdt() Markus Armbruster
2023-09-29 8:50 ` [PULL 37/56] test-throttle: don't shadow 'index' variable in do_test_accounting() Markus Armbruster
2023-09-29 8:50 ` [PULL 38/56] hw/acpi: changes towards enabling -Wshadow=local Markus Armbruster
2023-09-30 3:54 ` Ani Sinha
2023-09-30 8:41 ` Markus Armbruster
2023-10-02 10:49 ` Michael S. Tsirkin [this message]
2023-09-29 8:50 ` [PULL 39/56] hw/intc/arm_gicv3_its: Avoid shadowing variable in do_process_its_cmd() Markus Armbruster
2023-09-29 8:50 ` [PULL 40/56] hw/misc/arm_sysctl.c: Avoid shadowing local variable Markus Armbruster
2023-09-29 8:50 ` [PULL 41/56] hw/arm/smmuv3.c: Avoid shadowing variable Markus Armbruster
2023-09-29 8:50 ` [PULL 42/56] hw/arm/smmuv3-internal.h: Don't use locals in statement macros Markus Armbruster
2023-09-29 8:50 ` [PULL 43/56] aspeed/i2c: Clean up local variable shadowing Markus Armbruster
2023-09-29 8:50 ` [PULL 44/56] aspeed: " Markus Armbruster
2023-09-29 8:50 ` [PULL 45/56] aspeed/i3c: Rename variable shadowing a local Markus Armbruster
2023-09-29 8:50 ` [PULL 46/56] aspeed/timer: Clean up local variable shadowing Markus Armbruster
2023-09-29 8:50 ` [PULL 47/56] intel_iommu: Fix shadow local variables on "size" Markus Armbruster
2023-09-29 8:50 ` [PULL 48/56] crypto: remove shadowed 'ret' variable Markus Armbruster
2023-09-29 8:50 ` [PULL 49/56] seccomp: avoid shadowing of 'action' variable Markus Armbruster
2023-09-29 8:50 ` [PULL 50/56] qemu-nbd: changes towards enabling -Wshadow=local Markus Armbruster
2023-09-29 8:50 ` [PULL 51/56] hw/riscv: opentitan: Fixup local variables shadowing Markus Armbruster
2023-09-29 8:50 ` [PULL 52/56] target/riscv: cpu: " Markus Armbruster
2023-09-29 8:50 ` [PULL 53/56] target/riscv: vector_helper: " Markus Armbruster
2023-09-29 8:50 ` [PULL 54/56] softmmu/device_tree: " Markus Armbruster
2023-09-29 8:50 ` [PULL 55/56] hw/nvme: Clean up local variable shadowing in nvme_ns_init() Markus Armbruster
2023-09-29 8:50 ` [PULL 56/56] disas/m68k: clean up local variable shadowing Markus Armbruster
2023-10-02 21:57 ` [PULL 00/56] -Wshadow=local patches patches for 2023-09-29 Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231002064738-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=anisinha@redhat.com \
--cc=armbru@redhat.com \
--cc=imammedo@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).