From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: balaton@eik.bme.hu, Martin Kletzander <mkletzan@redhat.com>
Subject: [PATCH 02/13] audio: Require AudioState in AUD_add_capture
Date: Mon, 2 Oct 2023 16:57:16 +0200 [thread overview]
Message-ID: <20231002145728.87958-3-pbonzini@redhat.com> (raw)
In-Reply-To: <20231002145728.87958-1-pbonzini@redhat.com>
From: Martin Kletzander <mkletzan@redhat.com>
Since all callers require a valid audiodev this function can now safely
abort in case of missing AudioState.
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
Message-ID: <c6e87e678e914df0f59da2145c2753cdb4a16f63.1650874791.git.mkletzan@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
audio/audio.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/audio/audio.c b/audio/audio.c
index 2f479657117..d4387cb3e21 100644
--- a/audio/audio.c
+++ b/audio/audio.c
@@ -1876,10 +1876,8 @@ CaptureVoiceOut *AUD_add_capture(
struct capture_callback *cb;
if (!s) {
- if (!legacy_config) {
- dolog("Capturing without setting an audiodev is deprecated\n");
- }
- s = audio_init(NULL, NULL);
+ error_report("Capturing without setting an audiodev is not supported");
+ abort();
}
if (!audio_get_pdo_out(s->dev)->mixing_engine) {
--
2.41.0
next prev parent reply other threads:[~2023-10-02 14:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-02 14:57 [PATCH v4 00/13] Cleanup deprecated audio features, take 2 Paolo Bonzini
2023-10-02 14:57 ` [PATCH 01/13] ui/vnc: Require audiodev= to enable audio Paolo Bonzini
2023-10-02 14:57 ` Paolo Bonzini [this message]
2023-10-02 14:57 ` [PATCH 03/13] audio: allow returning an error from the driver init Paolo Bonzini
2023-10-02 14:57 ` [PATCH 04/13] audio: return Error ** from audio_state_by_name Paolo Bonzini
2023-10-02 14:57 ` [PATCH 05/13] audio: commonize voice initialization Paolo Bonzini
2023-10-02 14:57 ` [PATCH 06/13] audio: simplify flow in audio_init Paolo Bonzini
2023-10-02 14:57 ` [PATCH 07/13] audio: remove QEMU_AUDIO_* and -audio-help support Paolo Bonzini
2023-10-02 14:57 ` [PATCH 08/13] Introduce machine property "audiodev" Paolo Bonzini
2023-10-02 14:57 ` [PATCH 09/13] hw/arm: Support machine-default audiodev with fallback Paolo Bonzini
2023-10-02 14:57 ` [PATCH 10/13] hw/ppc: " Paolo Bonzini
2023-10-02 14:57 ` [PATCH 11/13] vt82c686 machines: " Paolo Bonzini
2023-10-02 14:57 ` [PATCH 12/13] audio: propagate Error * out of audio_init Paolo Bonzini
2023-10-02 14:57 ` [PATCH 13/13] audio: forbid default audiodev backend with -nodefaults Paolo Bonzini
-- strict thread matches above, loose matches on Subject: below --
2023-09-28 7:36 [PATCH v2 00/13] Cleanup deprecated audio features, take 2 Paolo Bonzini
2023-09-28 7:36 ` [PATCH 02/13] audio: Require AudioState in AUD_add_capture Paolo Bonzini
2023-09-23 8:54 [PATCH 00/13] Cleanup deprecated audio features, take 2 Paolo Bonzini
2023-09-23 8:54 ` [PATCH 02/13] audio: Require AudioState in AUD_add_capture Paolo Bonzini
2023-09-23 11:48 ` BALATON Zoltan
2023-09-24 8:53 ` Paolo Bonzini
2023-09-28 11:59 ` BALATON Zoltan
2023-09-28 13:01 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231002145728.87958-3-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=balaton@eik.bme.hu \
--cc=mkletzan@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).