[PATCH v2 0/8] MAINTAINERS: Collect unmaintained files under PPC entries

[PATCH v2 0/8] MAINTAINERS: Collect unmaintained files under PPC entries

[Cédric Le Goater]

Hello,

All PPC files should now be correctly assigned to some entry. 

Cheers,

C.

Changes in v2:
 - Took Reviewed-by's from Phil and Daniel
 - Took tests/avocado/ppc_405.py in patch 2


Cédric Le Goater (8):
  ppc/{bamboo, virtex_ml507}: Remove useless dependency on ppc405.h
    header
  MAINTAINERS: Adjust file list for PPC ref405ep machine
  MAINTAINERS: Adjust file list for PPC 4xx CPUs
  MAINTAINERS: Adjust file list for PPC e500 machines
  MAINTAINERS: Adjust file list for PPC pseries machine
  MAINTAINERS: Add fw_cfg.c to PPC mac99 machine
  MAINTAINERS: Add PPC common files to PowerPC TCG CPUs
  MAINTAINERS: Update PPC TCG target with tests

 MAINTAINERS            | 20 ++++++++++++++++++--
 hw/ppc/ppc440_bamboo.c |  1 -
 hw/ppc/virtex_ml507.c  |  1 -
 3 files changed, 18 insertions(+), 4 deletions(-)

-- 
2.41.0

[PATCH v2 1/8] ppc/{bamboo, virtex_ml507}: Remove useless dependency on ppc405.h header

[Cédric Le Goater]

Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com> (odd fixer:virtex_ml507)
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
 hw/ppc/ppc440_bamboo.c | 1 -
 hw/ppc/virtex_ml507.c  | 1 -
 2 files changed, 2 deletions(-)

diff --git a/hw/ppc/ppc440_bamboo.c b/hw/ppc/ppc440_bamboo.c
index 45f409c83862..a189942de4cf 100644
--- a/hw/ppc/ppc440_bamboo.c
+++ b/hw/ppc/ppc440_bamboo.c
@@ -24,7 +24,6 @@
 #include "elf.h"
 #include "hw/char/serial.h"
 #include "hw/ppc/ppc.h"
-#include "ppc405.h"
 #include "sysemu/sysemu.h"
 #include "sysemu/reset.h"
 #include "hw/sysbus.h"
diff --git a/hw/ppc/virtex_ml507.c b/hw/ppc/virtex_ml507.c
index f2f81bd4259c..d02f330650fc 100644
--- a/hw/ppc/virtex_ml507.c
+++ b/hw/ppc/virtex_ml507.c
@@ -43,7 +43,6 @@
 #include "hw/ppc/ppc.h"
 #include "hw/ppc/ppc4xx.h"
 #include "hw/qdev-properties.h"
-#include "ppc405.h"
 
 #include <libfdt.h>
 
-- 
2.41.0

[PATCH v2 2/8] MAINTAINERS: Adjust file list for PPC ref405ep machine

[Cédric Le Goater]

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
 MAINTAINERS | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 355b1960ce46..9f2eb00b7744 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1345,7 +1345,8 @@ PowerPC Machines
 405 (ref405ep)
 L: qemu-ppc@nongnu.org
 S: Orphan
-F: hw/ppc/ppc405_boards.c
+F: hw/ppc/ppc405*
+F: tests/avocado/ppc_405.py
 
 Bamboo
 L: qemu-ppc@nongnu.org
-- 
2.41.0

[PATCH v2 3/8] MAINTAINERS: Adjust file list for PPC 4xx CPUs

[Cédric Le Goater]

Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
 MAINTAINERS | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 9f2eb00b7744..cdac16c8eae7 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1961,7 +1961,9 @@ F: docs/specs/acpi_hest_ghes.rst
 ppc4xx
 L: qemu-ppc@nongnu.org
 S: Orphan
-F: hw/ppc/ppc4*.c
+F: hw/ppc/ppc4xx*.c
+F: hw/ppc/ppc440_uc.c
+F: hw/ppc/ppc440.h
 F: hw/i2c/ppc4xx_i2c.c
 F: include/hw/ppc/ppc4xx.h
 F: include/hw/i2c/ppc4xx_i2c.h
-- 
2.41.0

[PATCH v2 4/8] MAINTAINERS: Adjust file list for PPC e500 machines

[Cédric Le Goater]

Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index cdac16c8eae7..016cfb355123 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1358,6 +1358,7 @@ e500
 L: qemu-ppc@nongnu.org
 S: Orphan
 F: hw/ppc/e500*
+F: hw/ppc/ppce500_spin.c
 F: hw/gpio/mpc8xxx.c
 F: hw/i2c/mpc_i2c.c
 F: hw/net/fsl_etsec/
@@ -1367,6 +1368,7 @@ F: include/hw/pci-host/ppce500.h
 F: pc-bios/u-boot.e500
 F: hw/intc/openpic_kvm.h
 F: include/hw/ppc/openpic_kvm.h
+F: docs/system/ppc/ppce500.rst
 
 mpc8544ds
 L: qemu-ppc@nongnu.org
-- 
2.41.0

[PATCH v2 5/8] MAINTAINERS: Adjust file list for PPC pseries machine

[Cédric Le Goater]

The fdt.{c.h} files provide a helper routine used by the pseries and
pnv machines. Attached it to the list of the larger one: pseries.

Protected Execution Facility (PEF) is the confidential guest support
for PPC pseries machines.

Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
 MAINTAINERS | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 016cfb355123..814352191305 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1441,6 +1441,10 @@ F: hw/*/spapr*
 F: include/hw/*/spapr*
 F: hw/*/xics*
 F: include/hw/*/xics*
+F: include/hw/ppc/fdt.h
+F: hw/ppc/fdt.c
+F: include/hw/ppc/pef.h
+F: hw/ppc/pef.c
 F: pc-bios/slof.bin
 F: docs/system/ppc/pseries.rst
 F: docs/specs/ppc-spapr-*
-- 
2.41.0

[PATCH v2 6/8] MAINTAINERS: Add fw_cfg.c to PPC mac99 machine

[Cédric Le Goater]

The hw/ppc/fw_cfg.c file contains the implementation of
fw_cfg_arch_key_name(), used by the common nvram model. List it under
mac99 machine next to the mac_nvram model.

Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 814352191305..d00f39ac9440 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1388,6 +1388,7 @@ F: hw/pci-bridge/dec.[hc]
 F: hw/misc/macio/
 F: hw/misc/mos6522.c
 F: hw/nvram/mac_nvram.c
+F: hw/ppc/fw_cfg.c
 F: hw/input/adb*
 F: include/hw/misc/macio/
 F: include/hw/misc/mos6522.h
-- 
2.41.0

Re: [PATCH v2 6/8] MAINTAINERS: Add fw_cfg.c to PPC mac99 machine

[Mark Cave-Ayland]

On 02/10/2023 16:51, Cédric Le Goater wrote:

> The hw/ppc/fw_cfg.c file contains the implementation of
> fw_cfg_arch_key_name(), used by the common nvram model. List it under
> mac99 machine next to the mac_nvram model.
> 
> Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
>   MAINTAINERS | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 814352191305..d00f39ac9440 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1388,6 +1388,7 @@ F: hw/pci-bridge/dec.[hc]
>   F: hw/misc/macio/
>   F: hw/misc/mos6522.c
>   F: hw/nvram/mac_nvram.c
> +F: hw/ppc/fw_cfg.c
>   F: hw/input/adb*
>   F: include/hw/misc/macio/
>   F: include/hw/misc/mos6522.h

Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>


ATB,

Mark.

[PATCH v2 7/8] MAINTAINERS: Add PPC common files to PowerPC TCG CPUs

[Cédric Le Goater]

Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
 MAINTAINERS | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index d00f39ac9440..e40f7f71d651 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -307,6 +307,11 @@ F: target/ppc/
 F: hw/ppc/ppc.c
 F: hw/ppc/ppc_booke.c
 F: include/hw/ppc/ppc.h
+F: hw/ppc/meson.build
+F: hw/ppc/trace*
+F: configs/devices/ppc*
+F: docs/system/ppc/embedded.rst
+F: docs/system/target-ppc.rst
 
 RISC-V TCG CPUs
 M: Palmer Dabbelt <palmer@dabbelt.com>
-- 
2.41.0

[PATCH v2 8/8] MAINTAINERS: Update PPC TCG target with tests

[Cédric Le Goater]

Cc: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index e40f7f71d651..174bcfe39210 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3551,6 +3551,7 @@ PPC TCG target
 M: Richard Henderson <richard.henderson@linaro.org>
 S: Odd Fixes
 F: tcg/ppc/
+F: tests/tcg/ppc*
 
 RISC-V TCG target
 M: Palmer Dabbelt <palmer@dabbelt.com>
-- 
2.41.0

Re: [PATCH v2 8/8] MAINTAINERS: Update PPC TCG target with tests

[Thomas Huth]

On 02/10/2023 17.51, Cédric Le Goater wrote:
> Cc: Richard Henderson <richard.henderson@linaro.org>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
>   MAINTAINERS | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index e40f7f71d651..174bcfe39210 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3551,6 +3551,7 @@ PPC TCG target
>   M: Richard Henderson <richard.henderson@linaro.org>
>   S: Odd Fixes
>   F: tcg/ppc/
> +F: tests/tcg/ppc*

Sorry, but I think this patch is wrong. This section is about the TCG *host* 
backend (tcg/ppc/), but tests/tcg/ppc* is about the TCG *guest* frontend.

I just noticed since I just wrote a patch that adds the tests/tcg/ 
subfolders to the right sections:

  https://lore.kernel.org/qemu-devel/20231018062401.20746-1-thuth@redhat.com/

The ppc* subfolders are included there, too, so I'd suggest to drop this 
patch here.

  Thomas

Re: [PATCH v2 8/8] MAINTAINERS: Update PPC TCG target with tests

[Cédric Le Goater]

On 10/18/23 08:27, Thomas Huth wrote:
> On 02/10/2023 17.51, Cédric Le Goater wrote:
>> Cc: Richard Henderson <richard.henderson@linaro.org>
>> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>> Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
>> Signed-off-by: Cédric Le Goater <clg@kaod.org>
>> ---
>>   MAINTAINERS | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index e40f7f71d651..174bcfe39210 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -3551,6 +3551,7 @@ PPC TCG target
>>   M: Richard Henderson <richard.henderson@linaro.org>
>>   S: Odd Fixes
>>   F: tcg/ppc/
>> +F: tests/tcg/ppc*
> 
> Sorry, but I think this patch is wrong. This section is about the TCG *host* backend (tcg/ppc/), but tests/tcg/ppc* is about the TCG *guest* frontend.
> 
> I just noticed since I just wrote a patch that adds the tests/tcg/ subfolders to the right sections:
> 
>   https://lore.kernel.org/qemu-devel/20231018062401.20746-1-thuth@redhat.com/
> 
> The ppc* subfolders are included there, too, so I'd suggest to drop this patch here.

ok. Good for me.

Thanks,

C.