qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>
Subject: [PULL 07/24] Makefile: build plugins before running TCG tests
Date: Tue,  3 Oct 2023 10:30:24 +0200	[thread overview]
Message-ID: <20231003083042.110065-8-pbonzini@redhat.com> (raw)
In-Reply-To: <20231003083042.110065-1-pbonzini@redhat.com>

Add back test-plugins and, after making sure it is always defined,
do so unconditionally.

Reported-by: Alex Bennée <alex.bennee@linaro.org>
Fixes: 2c13c574418 ("configure, meson: move --enable-plugins to meson", 2023-09-07)
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Tested-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 tests/Makefile.include   |  2 +-
 tests/meson.build        |  5 +----
 tests/plugin/meson.build | 18 ++++++++++++------
 3 files changed, 14 insertions(+), 11 deletions(-)

diff --git a/tests/Makefile.include b/tests/Makefile.include
index 38987426594..dab1989a071 100644
--- a/tests/Makefile.include
+++ b/tests/Makefile.include
@@ -73,7 +73,7 @@ $(TCG_TESTS_TARGETS:%=distclean-tcg-tests-%): distclean-tcg-tests-%:
 build-tcg: $(BUILD_TCG_TARGET_RULES)
 
 .PHONY: check-tcg
-.ninja-goals.check-tcg = all
+.ninja-goals.check-tcg = all test-plugins
 check-tcg: $(RUN_TCG_TARGET_RULES)
 
 .PHONY: clean-tcg
diff --git a/tests/meson.build b/tests/meson.build
index debaa4505eb..9996a293fbb 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -80,10 +80,7 @@ if 'CONFIG_TCG' in config_all
   subdir('fp')
 endif
 
-if get_option('plugins')
-  subdir('plugin')
-endif
-
+subdir('plugin')
 subdir('unit')
 subdir('qapi-schema')
 subdir('qtest')
diff --git a/tests/plugin/meson.build b/tests/plugin/meson.build
index 2bbfc4b19e1..322cafcdf6b 100644
--- a/tests/plugin/meson.build
+++ b/tests/plugin/meson.build
@@ -1,7 +1,13 @@
 t = []
-foreach i : ['bb', 'empty', 'insn', 'mem', 'syscall']
-  t += shared_module(i, files(i + '.c'),
-                     include_directories: '../../include/qemu',
-                     dependencies: glib)
-endforeach
-alias_target('test-plugins', t)
+if get_option('plugins')
+  foreach i : ['bb', 'empty', 'insn', 'mem', 'syscall']
+    t += shared_module(i, files(i + '.c'),
+                       include_directories: '../../include/qemu',
+                       dependencies: glib)
+  endforeach
+endif
+if t.length() > 0
+  alias_target('test-plugins', t)
+else
+  run_target('test-plugins', command: find_program('true'))
+endif
-- 
2.41.0



  parent reply	other threads:[~2023-10-03  8:32 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-03  8:30 [PULL 00/24] Audio, build system, misc fixes for 2023-10-03 Paolo Bonzini
2023-10-03  8:30 ` [PULL 01/24] optionrom: Remove build-id section Paolo Bonzini
2023-10-03 10:04   ` Michael Tokarev
2023-10-03  8:30 ` [PULL 02/24] accel/kvm/kvm-all: Handle register access errors Paolo Bonzini
2023-10-03  8:30 ` [PULL 03/24] e1000: remove old compatibility code Paolo Bonzini
2023-10-03  8:30 ` [PULL 04/24] pc: remove short_root_bus property Paolo Bonzini
2023-10-03  8:30 ` [PULL 05/24] make-release: do not ship dtc sources Paolo Bonzini
2023-10-03  8:30 ` [PULL 06/24] meson: clean up static_library keyword arguments Paolo Bonzini
2023-10-03  8:30 ` Paolo Bonzini [this message]
2023-10-03  8:30 ` [PULL 08/24] esp: use correct type for esp_dma_enable() in sysbus_esp_gpio_demux() Paolo Bonzini
2023-10-03  8:30 ` [PULL 09/24] esp: restrict non-DMA transfer length to that of available data Paolo Bonzini
2023-10-03  8:30 ` [PULL 10/24] scsi-disk: ensure that FORMAT UNIT commands are terminated Paolo Bonzini
2023-10-03  8:30 ` [PULL 11/24] crypto: only include tls-cipher-suites in emulators Paolo Bonzini
2023-10-03  8:30 ` [PULL 12/24] ui/vnc: Require audiodev= to enable audio Paolo Bonzini
2023-10-03  8:30 ` [PULL 13/24] audio: Require AudioState in AUD_add_capture Paolo Bonzini
2023-10-03  8:30 ` [PULL 14/24] audio: allow returning an error from the driver init Paolo Bonzini
2023-10-03  8:30 ` [PULL 15/24] audio: return Error ** from audio_state_by_name Paolo Bonzini
2023-10-03  8:30 ` [PULL 16/24] audio: commonize voice initialization Paolo Bonzini
2023-10-03  8:30 ` [PULL 17/24] audio: simplify flow in audio_init Paolo Bonzini
2023-10-03  8:30 ` [PULL 18/24] audio: remove QEMU_AUDIO_* and -audio-help support Paolo Bonzini
2023-10-03  8:30 ` [PULL 19/24] Introduce machine property "audiodev" Paolo Bonzini
2023-10-03  8:30 ` [PULL 20/24] hw/arm: Support machine-default audiodev with fallback Paolo Bonzini
2023-10-03  8:30 ` [PULL 21/24] hw/ppc: " Paolo Bonzini
2023-10-03  8:30 ` [PULL 22/24] vt82c686 machines: " Paolo Bonzini
2023-10-03  8:30 ` [PULL 23/24] audio: propagate Error * out of audio_init Paolo Bonzini
2023-10-03  8:30 ` [PULL 24/24] audio: forbid default audiodev backend with -nodefaults Paolo Bonzini
2023-10-03 14:43 ` [PULL 00/24] Audio, build system, misc fixes for 2023-10-03 Stefan Hajnoczi
2023-10-03 15:36 ` Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231003083042.110065-8-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).