From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Eduardo Habkost" <eduardo@habkost.net>,
"Yanan Wang" <wangyanan55@huawei.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
kvm@vger.kernel.org, "Alex Bennée" <alex.bennee@linaro.org>,
"Claudio Fontana" <cfontana@suse.de>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Marcelo Tosatti" <mtosatti@redhat.com>,
"Roman Bolshakov" <rbolshakov@ddn.com>,
"Fabiano Rosas" <farosas@suse.de>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Cameron Esfahani" <dirty@apple.com>
Subject: [PATCH v2 4/7] accel: Introduce accel_cpu_common_unrealize() stub
Date: Tue, 3 Oct 2023 14:30:22 +0200 [thread overview]
Message-ID: <20231003123026.99229-5-philmd@linaro.org> (raw)
In-Reply-To: <20231003123026.99229-1-philmd@linaro.org>
Prepare the stub for parity with accel_cpu_common_realize().
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
include/qemu/accel.h | 6 ++++++
accel/accel-common.c | 4 ++++
cpu.c | 4 +++-
3 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/include/qemu/accel.h b/include/qemu/accel.h
index 898159c001..446153b145 100644
--- a/include/qemu/accel.h
+++ b/include/qemu/accel.h
@@ -96,6 +96,12 @@ void accel_cpu_instance_init(CPUState *cpu);
*/
bool accel_cpu_common_realize(CPUState *cpu, Error **errp);
+/**
+ * accel_cpu_common_unrealize:
+ * @cpu: The CPU that needs to call accel-specific cpu unrealization.
+ */
+void accel_cpu_common_unrealize(CPUState *cpu);
+
/**
* accel_supported_gdbstub_sstep_flags:
*
diff --git a/accel/accel-common.c b/accel/accel-common.c
index 53cf08a89a..e9548eac29 100644
--- a/accel/accel-common.c
+++ b/accel/accel-common.c
@@ -129,6 +129,10 @@ bool accel_cpu_common_realize(CPUState *cpu, Error **errp)
return true;
}
+void accel_cpu_common_unrealize(CPUState *cpu)
+{
+}
+
int accel_supported_gdbstub_sstep_flags(void)
{
AccelState *accel = current_accel();
diff --git a/cpu.c b/cpu.c
index 1e2649a706..2a1eff948b 100644
--- a/cpu.c
+++ b/cpu.c
@@ -187,8 +187,10 @@ void cpu_exec_unrealizefn(CPUState *cpu)
cpu_list_remove(cpu);
/*
* Now that the vCPU has been removed from the RCU list, we can call
- * tcg_exec_unrealizefn, which may free fields using call_rcu.
+ * tcg_exec_unrealizefn and
+ * accel_cpu_common_unrealize, which may free fields using call_rcu.
*/
+ accel_cpu_common_unrealize(cpu);
if (tcg_enabled()) {
tcg_exec_unrealizefn(cpu);
}
--
2.41.0
next prev parent reply other threads:[~2023-10-03 12:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 12:30 [PATCH v2 0/7] accel: Restrict tcg_exec_[un]realizefn() to TCG Philippe Mathieu-Daudé
2023-10-03 12:30 ` [PATCH v2 1/7] accel: Rename accel_cpu_realizefn() -> accel_cpu_realize() Philippe Mathieu-Daudé
2023-10-03 12:30 ` [PATCH v2 2/7] accel: Rename AccelCPUClass::cpu_realizefn() -> cpu_target_realize() Philippe Mathieu-Daudé
2023-10-03 12:30 ` [PATCH v2 3/7] accel: Rename accel_cpu_realize() -> accel_cpu_common_realize() Philippe Mathieu-Daudé
2023-10-03 12:30 ` Philippe Mathieu-Daudé [this message]
2023-10-03 12:30 ` [PATCH v2 5/7] accel: Declare AccelClass::cpu_common_[un]realize() handlers Philippe Mathieu-Daudé
2023-10-03 12:30 ` [PATCH v2 6/7] accel/tcg: Have tcg_exec_realizefn() return a boolean Philippe Mathieu-Daudé
2023-10-03 12:30 ` [PATCH v2 7/7] accel/tcg: Restrict tcg_exec_[un]realizefn() to TCG Philippe Mathieu-Daudé
2023-10-03 14:06 ` [PATCH v2 0/7] accel: " Claudio Fontana
2023-10-03 16:02 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231003123026.99229-5-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=cfontana@suse.de \
--cc=dirty@apple.com \
--cc=eduardo@habkost.net \
--cc=farosas@suse.de \
--cc=kvm@vger.kernel.org \
--cc=marcel.apfelbaum@gmail.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rbolshakov@ddn.com \
--cc=richard.henderson@linaro.org \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).