From: Jonathan Cameron via <qemu-devel@nongnu.org>
To: Salil Mehta <salil.mehta@huawei.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"qemu-arm@nongnu.org" <qemu-arm@nongnu.org>,
"maz@kernel.org" <maz@kernel.org>,
"jean-philippe@linaro.org" <jean-philippe@linaro.org>,
"lpieralisi@kernel.org" <lpieralisi@kernel.org>,
"peter.maydell@linaro.org" <peter.maydell@linaro.org>,
"richard.henderson@linaro.org" <richard.henderson@linaro.org>,
"imammedo@redhat.com" <imammedo@redhat.com>,
"andrew.jones@linux.dev" <andrew.jones@linux.dev>,
"david@redhat.com" <david@redhat.com>,
"philmd@linaro.org" <philmd@linaro.org>,
"eric.auger@redhat.com" <eric.auger@redhat.com>,
"oliver.upton@linux.dev" <oliver.upton@linux.dev>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"mst@redhat.com" <mst@redhat.com>,
"will@kernel.org" <will@kernel.org>,
"gshan@redhat.com" <gshan@redhat.com>,
"rafael@kernel.org" <rafael@kernel.org>,
"alex.bennee@linaro.org" <alex.bennee@linaro.org>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"darren@os.amperecomputing.com" <darren@os.amperecomputing.com>,
"ilkka@os.amperecomputing.com" <ilkka@os.amperecomputing.com>,
"vishnu@os.amperecomputing.com" <vishnu@os.amperecomputing.com>,
"karl.heubaum@oracle.com" <karl.heubaum@oracle.com>,
"miguel.luis@oracle.com" <miguel.luis@oracle.com>,
"salil.mehta@opnsrc.net" <salil.mehta@opnsrc.net>,
zhukeqian <zhukeqian1@huawei.com>,
"wangxiongfeng (C)" <wangxiongfeng2@huawei.com>,
"wangyanan (Y)" <wangyanan55@huawei.com>,
"jiakernel2@gmail.com" <jiakernel2@gmail.com>,
"maobibo@loongson.cn" <maobibo@loongson.cn>,
"lixianglai@loongson.cn" <lixianglai@loongson.cn>,
Linuxarm <linuxarm@huawei.com>
Subject: Re: [PATCH V2 06/10] hw/acpi: Update GED _EVT method AML with cpu scan
Date: Tue, 3 Oct 2023 12:53:51 +0100 [thread overview]
Message-ID: <20231003125351.00004788@Huawei.com> (raw)
In-Reply-To: <ed93b18d03ef44c5b37815449bdc10c3@huawei.com>
> > aml_notify(aml_name(ACPI_POWER_BUTTON_DEVICE),
> > > diff --git a/include/hw/acpi/cpu_hotplug.h
> > b/include/hw/acpi/cpu_hotplug.h
> > > index 48b291e45e..ef631750b4 100644
> > > --- a/include/hw/acpi/cpu_hotplug.h
> > > +++ b/include/hw/acpi/cpu_hotplug.h
> > > @@ -20,6 +20,8 @@
> > > #include "hw/acpi/cpu.h"
> > >
> > > #define ACPI_CPU_HOTPLUG_REG_LEN 12
> > > +#define ACPI_CPU_SCAN_METHOD "CSCN"
> >
> > This seems to already be defined in hw/acpi/cpu.c
> > Can we drop it from there given that file now includes this
> > header anyway.
>
> Perhaps I can assign this to the macro in the hw/acpi/cpu.c?
hw/acpi/cpu.c includes this header now anyway I think.
So just drop that definition and should all be good.
Jonathan
>
> Thanks
> Salil.
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Salil Mehta <salil.mehta@huawei.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"qemu-arm@nongnu.org" <qemu-arm@nongnu.org>,
"maz@kernel.org" <maz@kernel.org>,
"jean-philippe@linaro.org" <jean-philippe@linaro.org>,
"lpieralisi@kernel.org" <lpieralisi@kernel.org>,
"peter.maydell@linaro.org" <peter.maydell@linaro.org>,
"richard.henderson@linaro.org" <richard.henderson@linaro.org>,
"imammedo@redhat.com" <imammedo@redhat.com>,
"andrew.jones@linux.dev" <andrew.jones@linux.dev>,
"david@redhat.com" <david@redhat.com>,
"philmd@linaro.org" <philmd@linaro.org>,
"eric.auger@redhat.com" <eric.auger@redhat.com>,
"oliver.upton@linux.dev" <oliver.upton@linux.dev>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"mst@redhat.com" <mst@redhat.com>,
"will@kernel.org" <will@kernel.org>,
"gshan@redhat.com" <gshan@redhat.com>,
"rafael@kernel.org" <rafael@kernel.org>,
"alex.bennee@linaro.org" <alex.bennee@linaro.org>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"darren@os.amperecomputing.com" <darren@os.amperecomputing.com>,
"ilkka@os.amperecomputing.com" <ilkka@os.amperecomputing.com>,
"vishnu@os.amperecomputing.com" <vishnu@os.amperecomputing.com>,
"karl.heubaum@oracle.com" <karl.heubaum@oracle.com>,
"miguel.luis@oracle.com" <miguel.luis@oracle.com>,
"salil.mehta@opnsrc.net" <salil.mehta@opnsrc.net>,
zhukeqian <zhukeqian1@huawei.com>,
"wangxiongfeng (C)" <wangxiongfeng2@huawei.com>,
"wangyanan (Y)" <wangyanan55@huawei.com>,
"jiakernel2@gmail.com" <jiakernel2@gmail.com>,
"maobibo@loongson.cn" <maobibo@loongson.cn>,
"lixianglai@loongson.cn" <lixianglai@loongson.cn>,
Linuxarm <linuxarm@huawei.com>
Subject: Re: [PATCH V2 06/10] hw/acpi: Update GED _EVT method AML with cpu scan
Date: Tue, 3 Oct 2023 12:53:51 +0100 [thread overview]
Message-ID: <20231003125351.00004788@Huawei.com> (raw)
Message-ID: <20231003115351.Av9a5v9TS2ZQHSNm0OdncoYEMYqMk7_NNO49oViaYPA@z> (raw)
In-Reply-To: <ed93b18d03ef44c5b37815449bdc10c3@huawei.com>
> > aml_notify(aml_name(ACPI_POWER_BUTTON_DEVICE),
> > > diff --git a/include/hw/acpi/cpu_hotplug.h
> > b/include/hw/acpi/cpu_hotplug.h
> > > index 48b291e45e..ef631750b4 100644
> > > --- a/include/hw/acpi/cpu_hotplug.h
> > > +++ b/include/hw/acpi/cpu_hotplug.h
> > > @@ -20,6 +20,8 @@
> > > #include "hw/acpi/cpu.h"
> > >
> > > #define ACPI_CPU_HOTPLUG_REG_LEN 12
> > > +#define ACPI_CPU_SCAN_METHOD "CSCN"
> >
> > This seems to already be defined in hw/acpi/cpu.c
> > Can we drop it from there given that file now includes this
> > header anyway.
>
> Perhaps I can assign this to the macro in the hw/acpi/cpu.c?
hw/acpi/cpu.c includes this header now anyway I think.
So just drop that definition and should all be good.
Jonathan
>
> Thanks
> Salil.
next prev parent reply other threads:[~2023-10-03 11:54 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-30 0:19 [PATCH V2 00/10] Add architecture agnostic code to support vCPU Hotplug Salil Mehta via
2023-09-30 0:19 ` [PATCH V2 01/10] accel/kvm: Extract common KVM vCPU {creation, parking} code Salil Mehta via
2023-10-02 15:53 ` [PATCH V2 01/10] accel/kvm: Extract common KVM vCPU {creation,parking} code Jonathan Cameron via
2023-10-02 15:53 ` Jonathan Cameron
2023-10-03 11:05 ` Salil Mehta via
2023-10-03 11:05 ` Salil Mehta
2023-10-03 11:51 ` Jonathan Cameron via
2023-10-03 11:51 ` Jonathan Cameron
2023-10-03 12:27 ` Salil Mehta via
2023-10-03 12:27 ` Salil Mehta
2023-10-02 23:17 ` Gavin Shan
2023-10-03 11:22 ` Salil Mehta via
2023-10-03 11:22 ` Salil Mehta
2023-09-30 0:19 ` [PATCH V2 02/10] hw/acpi: Move CPU ctrl-dev MMIO region len macro to common header file Salil Mehta via
2023-10-02 15:54 ` Jonathan Cameron via
2023-10-02 15:54 ` Jonathan Cameron
2023-10-03 11:24 ` Salil Mehta via
2023-10-03 11:24 ` Salil Mehta
2023-10-02 23:19 ` Gavin Shan
2023-10-03 11:24 ` Salil Mehta via
2023-10-03 11:24 ` Salil Mehta
2023-09-30 0:19 ` [PATCH V2 03/10] hw/acpi: Add ACPI CPU hotplug init stub Salil Mehta via
2023-10-02 16:00 ` Jonathan Cameron via
2023-10-02 16:00 ` Jonathan Cameron
2023-10-03 11:27 ` Salil Mehta via
2023-10-03 11:27 ` Salil Mehta
2023-10-02 23:25 ` Gavin Shan
2023-10-03 11:28 ` Salil Mehta via
2023-10-03 11:28 ` Salil Mehta
2023-09-30 0:19 ` [PATCH V2 04/10] hw/acpi: Init GED framework with cpu hotplug events Salil Mehta via
2023-10-02 16:07 ` Jonathan Cameron via
2023-10-02 16:07 ` Jonathan Cameron
2023-10-03 11:29 ` Salil Mehta via
2023-10-03 11:29 ` Salil Mehta
2023-10-02 23:28 ` Gavin Shan
2023-10-03 11:30 ` Salil Mehta via
2023-10-03 11:30 ` Salil Mehta
2023-09-30 0:19 ` [PATCH V2 05/10] hw/acpi: Update CPUs AML with cpu-(ctrl)dev change Salil Mehta via
2023-10-02 16:09 ` Jonathan Cameron via
2023-10-02 16:09 ` Jonathan Cameron
2023-10-03 11:31 ` Salil Mehta via
2023-10-03 11:31 ` Salil Mehta
2023-10-03 0:09 ` Gavin Shan
2023-10-03 11:33 ` Salil Mehta via
2023-10-03 11:33 ` Salil Mehta
2023-09-30 0:19 ` [PATCH V2 06/10] hw/acpi: Update GED _EVT method AML with cpu scan Salil Mehta via
2023-10-02 16:14 ` Jonathan Cameron via
2023-10-02 16:14 ` Jonathan Cameron
2023-10-03 11:43 ` Salil Mehta via
2023-10-03 11:43 ` Salil Mehta
2023-10-03 11:53 ` Jonathan Cameron via [this message]
2023-10-03 11:53 ` Jonathan Cameron
2023-10-03 12:13 ` Salil Mehta via
2023-10-03 12:13 ` Salil Mehta
2023-10-03 0:10 ` Gavin Shan
2023-10-03 11:43 ` Salil Mehta via
2023-10-03 11:43 ` Salil Mehta
2023-09-30 0:19 ` [PATCH V2 07/10] hw/acpi: Update ACPI GED framework to support vCPU Hotplug Salil Mehta via
2023-10-02 16:16 ` Jonathan Cameron via
2023-10-02 16:16 ` Jonathan Cameron
2023-10-03 11:44 ` Salil Mehta via
2023-10-03 11:44 ` Salil Mehta
2023-10-03 0:11 ` Gavin Shan
2023-10-03 11:45 ` Salil Mehta via
2023-10-03 11:45 ` Salil Mehta
2023-09-30 0:19 ` [PATCH V2 08/10] physmem: Add helper function to destroy CPU AddressSpace Salil Mehta via
2023-10-02 16:20 ` Jonathan Cameron via
2023-10-02 16:20 ` Jonathan Cameron
2023-10-03 11:46 ` Salil Mehta via
2023-10-03 11:46 ` Salil Mehta
2023-10-03 1:36 ` Gavin Shan
2023-10-03 11:54 ` Salil Mehta via
2023-10-03 11:54 ` Salil Mehta
2023-10-04 10:48 ` Salil Mehta via
2023-10-04 10:48 ` Salil Mehta
2023-09-30 0:19 ` [PATCH V2 09/10] gdbstub: Add helper function to unregister GDB register space Salil Mehta via
2023-10-03 3:16 ` Gavin Shan
2023-10-03 11:56 ` Salil Mehta via
2023-10-03 11:56 ` Salil Mehta
2023-09-30 0:19 ` [PATCH V2 10/10] target/arm/kvm: Write CPU state back to KVM on reset Salil Mehta via
2023-10-03 3:54 ` Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231003125351.00004788@Huawei.com \
--to=qemu-devel@nongnu.org \
--cc=Jonathan.Cameron@Huawei.com \
--cc=alex.bennee@linaro.org \
--cc=andrew.jones@linux.dev \
--cc=darren@os.amperecomputing.com \
--cc=david@redhat.com \
--cc=eric.auger@redhat.com \
--cc=gshan@redhat.com \
--cc=ilkka@os.amperecomputing.com \
--cc=imammedo@redhat.com \
--cc=jean-philippe@linaro.org \
--cc=jiakernel2@gmail.com \
--cc=karl.heubaum@oracle.com \
--cc=linux@armlinux.org.uk \
--cc=linuxarm@huawei.com \
--cc=lixianglai@loongson.cn \
--cc=lpieralisi@kernel.org \
--cc=maobibo@loongson.cn \
--cc=maz@kernel.org \
--cc=miguel.luis@oracle.com \
--cc=mst@redhat.com \
--cc=oliver.upton@linux.dev \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=rafael@kernel.org \
--cc=richard.henderson@linaro.org \
--cc=salil.mehta@huawei.com \
--cc=salil.mehta@opnsrc.net \
--cc=vishnu@os.amperecomputing.com \
--cc=wangxiongfeng2@huawei.com \
--cc=wangyanan55@huawei.com \
--cc=will@kernel.org \
--cc=zhukeqian1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).