From: Fan Ni <fan.ni@samsung.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Jonathan Cameron <Jonathan.Cameron@Huawei.com>,
qemu-devel <qemu-devel@nongnu.org>,
"Michael S . Tsirkin" <mst@redhat.com>,
"linuxarm@huawei.com" <linuxarm@huawei.com>
Subject: Re: [PATCH] hw/cxl: Fix local variable shadowing of cap_hdrs
Date: Tue, 3 Oct 2023 17:20:14 +0000 [thread overview]
Message-ID: <20231003172013.GB456865@sjcvldevvm72> (raw)
In-Reply-To: <878r8ph0zr.fsf@pond.sub.org>
On Fri, Sep 29, 2023 at 09:50:16AM +0200, Markus Armbruster wrote:
> Jonathan Cameron <Jonathan.Cameron@Huawei.com> writes:
>
> > On Wed, 27 Sep 2023 19:13:35 +0000
> > Fan Ni <fan.ni@samsung.com> wrote:
> >
> >> On Mon, Sep 25, 2023 at 04:22:58PM +0100, Jonathan Cameron wrote:
> >>
> >> > Rename the version not burried in the macro to cap_h.
> >> The change looks good to me. Just one minor thing. why "version" get
> >> involved here?
> >>
> >
> > Used in the sense of two copies of something with slightly differences
> > given if it were straight code without a macro, we'd have just
> > have used the copy being changed here for all of the calls.
> > With hindsight, not the best word to choose given the many other meanings!
>
> Fan, good enough to get your R-by?
>
Yes.
Fan
next prev parent reply other threads:[~2023-10-03 17:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230925152310uscas1p1b621d173ac0c0ce2163e4f2c788e4fdf@uscas1p1.samsung.com>
2023-09-25 15:22 ` [PATCH] hw/cxl: Fix local variable shadowing of cap_hdrs Jonathan Cameron via
2023-09-27 19:13 ` Fan Ni
2023-09-28 12:22 ` Jonathan Cameron via
2023-09-29 7:50 ` Markus Armbruster
2023-10-03 17:20 ` Fan Ni [this message]
2023-10-03 13:28 ` Michael S. Tsirkin
2023-10-03 17:21 ` Fan Ni
2023-10-04 10:32 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231003172013.GB456865@sjcvldevvm72 \
--to=fan.ni@samsung.com \
--cc=Jonathan.Cameron@Huawei.com \
--cc=armbru@redhat.com \
--cc=linuxarm@huawei.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).