From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: laurent@vivier.eu, deller@gmx.de,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH v5 2/9] linux-user: Exit not abort in die_with_backtrace
Date: Tue, 3 Oct 2023 12:20:05 -0700 [thread overview]
Message-ID: <20231003192012.1674888-3-richard.henderson@linaro.org> (raw)
In-Reply-To: <20231003192012.1674888-1-richard.henderson@linaro.org>
This line is supposed to be unreachable, but if we're going to
have it at all, SIGABRT via abort() is subject to the same signal
peril that created this function in the first place.
We can _exit immediately without peril.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
linux-user/signal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/linux-user/signal.c b/linux-user/signal.c
index b7a2c47837..84a56b76cc 100644
--- a/linux-user/signal.c
+++ b/linux-user/signal.c
@@ -713,7 +713,7 @@ void die_with_signal(int host_sig)
sigsuspend(&act.sa_mask);
/* unreachable */
- abort();
+ _exit(EXIT_FAILURE);
}
static G_NORETURN
--
2.34.1
next prev parent reply other threads:[~2023-10-03 19:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 19:20 [PATCH v5 0/9] linux-user: Detect and report host crashes Richard Henderson
2023-10-03 19:20 ` [PATCH v5 1/9] linux-user: Split out die_with_signal Richard Henderson
2023-10-03 19:20 ` Richard Henderson [this message]
2023-10-03 19:20 ` [PATCH v5 3/9] linux-user: Detect and report host crashes Richard Henderson
2023-10-03 19:20 ` [PATCH v5 4/9] linux-user: Only register handlers for core_dump_signal by default Richard Henderson
2023-10-03 19:20 ` [PATCH v5 5/9] linux-user: Map unsupported signals to an out-of-bounds value Richard Henderson
2023-10-03 19:20 ` [PATCH v5 6/9] linux-user: Simplify signal_init Richard Henderson
2023-10-03 19:20 ` [PATCH v5 7/9] linux-user: Split out host_sig{segv,bus}_handler Richard Henderson
2023-10-03 19:20 ` [PATCH v5 8/9] linux-user: Detect and report host SIGILL, SIGFPE, SIGTRAP Richard Henderson
2023-10-03 19:20 ` [PATCH v5 9/9] linux-user: Remap guest SIGABRT Richard Henderson
2023-10-13 3:52 ` [PATCH v5 0/9] linux-user: Detect and report host crashes Richard Henderson
2023-10-13 12:53 ` Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231003192012.1674888-3-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=deller@gmx.de \
--cc=laurent@vivier.eu \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).