From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: laurent@vivier.eu, deller@gmx.de
Subject: [PATCH v5 8/9] linux-user: Detect and report host SIGILL, SIGFPE, SIGTRAP
Date: Tue, 3 Oct 2023 12:20:11 -0700 [thread overview]
Message-ID: <20231003192012.1674888-9-richard.henderson@linaro.org> (raw)
In-Reply-To: <20231003192012.1674888-1-richard.henderson@linaro.org>
These signals, when not spoofed via kill(), are always bugs.
Use die_from_signal to report this sensibly.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
linux-user/signal.c | 44 +++++++++++++++++++++++++++++++++++++++++++-
1 file changed, 43 insertions(+), 1 deletion(-)
diff --git a/linux-user/signal.c b/linux-user/signal.c
index 706b8ac7a7..b67077f320 100644
--- a/linux-user/signal.c
+++ b/linux-user/signal.c
@@ -796,6 +796,43 @@ void die_from_signal(siginfo_t *info)
break;
}
break;
+ case SIGILL:
+ sig = "ILL";
+ switch (info->si_code) {
+ case ILL_ILLOPC:
+ code = "ILLOPC";
+ break;
+ case ILL_ILLOPN:
+ code = "ILLOPN";
+ break;
+ case ILL_ILLADR:
+ code = "ILLADR";
+ break;
+ case ILL_PRVOPC:
+ code = "PRVOPC";
+ break;
+ case ILL_PRVREG:
+ code = "PRVREG";
+ break;
+ case ILL_COPROC:
+ code = "COPROC";
+ break;
+ }
+ break;
+ case SIGFPE:
+ sig = "FPE";
+ switch (info->si_code) {
+ case FPE_INTDIV:
+ code = "INTDIV";
+ break;
+ case FPE_INTOVF:
+ code = "INTOVF";
+ break;
+ }
+ break;
+ case SIGTRAP:
+ sig = "TRAP";
+ break;
default:
snprintf(sigbuf, sizeof(sigbuf), "%d", info->si_signo);
sig = sigbuf;
@@ -900,7 +937,8 @@ static void host_signal_handler(int host_sig, siginfo_t *info, void *puc)
/*
* Non-spoofed SIGSEGV and SIGBUS are synchronous, and need special
- * handling wrt signal blocking and unwinding.
+ * handling wrt signal blocking and unwinding. Non-spoofed SIGILL,
+ * SIGFPE, SIGTRAP are always host bugs.
*/
if (info->si_code > 0) {
switch (host_sig) {
@@ -912,6 +950,10 @@ static void host_signal_handler(int host_sig, siginfo_t *info, void *puc)
host_sigbus_handler(cpu, info, uc);
sync_sig = true;
break;
+ case SIGILL:
+ case SIGFPE:
+ case SIGTRAP:
+ die_from_signal(info);
}
}
--
2.34.1
next prev parent reply other threads:[~2023-10-03 19:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 19:20 [PATCH v5 0/9] linux-user: Detect and report host crashes Richard Henderson
2023-10-03 19:20 ` [PATCH v5 1/9] linux-user: Split out die_with_signal Richard Henderson
2023-10-03 19:20 ` [PATCH v5 2/9] linux-user: Exit not abort in die_with_backtrace Richard Henderson
2023-10-03 19:20 ` [PATCH v5 3/9] linux-user: Detect and report host crashes Richard Henderson
2023-10-03 19:20 ` [PATCH v5 4/9] linux-user: Only register handlers for core_dump_signal by default Richard Henderson
2023-10-03 19:20 ` [PATCH v5 5/9] linux-user: Map unsupported signals to an out-of-bounds value Richard Henderson
2023-10-03 19:20 ` [PATCH v5 6/9] linux-user: Simplify signal_init Richard Henderson
2023-10-03 19:20 ` [PATCH v5 7/9] linux-user: Split out host_sig{segv,bus}_handler Richard Henderson
2023-10-03 19:20 ` Richard Henderson [this message]
2023-10-03 19:20 ` [PATCH v5 9/9] linux-user: Remap guest SIGABRT Richard Henderson
2023-10-13 3:52 ` [PATCH v5 0/9] linux-user: Detect and report host crashes Richard Henderson
2023-10-13 12:53 ` Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231003192012.1674888-9-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=deller@gmx.de \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).