From: Gurchetan Singh <gurchetansingh@chromium.org>
To: qemu-devel@nongnu.org
Cc: marcandre.lureau@redhat.com, akihiko.odaki@gmail.com,
ray.huang@amd.com, alex.bennee@linaro.org, shentey@gmail.com,
hi@alyssa.is, ernunes@redhat.com, manos.pitsidianakis@linaro.org,
mark.cave-ayland@ilande.co.uk, thuth@redhat.com
Subject: [PATCH v15 8/9] gfxstream + rutabaga: enable rutabaga
Date: Tue, 3 Oct 2023 13:44:59 -0700 [thread overview]
Message-ID: <20231003204500.518-9-gurchetansingh@chromium.org> (raw)
In-Reply-To: <20231003204500.518-1-gurchetansingh@chromium.org>
This change enables rutabaga to receive virtio-gpu-3d hypercalls
when it is active.
Signed-off-by: Gurchetan Singh <gurchetansingh@chromium.org>
Tested-by: Alyssa Ross <hi@alyssa.is>
Tested-by: Emmanouil Pitsidianakis <manos.pitsidianakis@linaro.org>
Tested-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Reviewed-by: Antonio Caggiano <quic_acaggian@quicinc.com>
Reviewed-by: Emmanouil Pitsidianakis <manos.pitsidianakis@linaro.org>
Reviewed-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
hw/display/virtio-gpu-base.c | 3 ++-
hw/display/virtio-gpu.c | 5 +++--
softmmu/qdev-monitor.c | 3 +++
softmmu/vl.c | 1 +
4 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/hw/display/virtio-gpu-base.c b/hw/display/virtio-gpu-base.c
index 4f2b0ba1f3..50c5373b65 100644
--- a/hw/display/virtio-gpu-base.c
+++ b/hw/display/virtio-gpu-base.c
@@ -223,7 +223,8 @@ virtio_gpu_base_get_features(VirtIODevice *vdev, uint64_t features,
{
VirtIOGPUBase *g = VIRTIO_GPU_BASE(vdev);
- if (virtio_gpu_virgl_enabled(g->conf)) {
+ if (virtio_gpu_virgl_enabled(g->conf) ||
+ virtio_gpu_rutabaga_enabled(g->conf)) {
features |= (1 << VIRTIO_GPU_F_VIRGL);
}
if (virtio_gpu_edid_enabled(g->conf)) {
diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c
index be16efbd38..6efd15b6ae 100644
--- a/hw/display/virtio-gpu.c
+++ b/hw/display/virtio-gpu.c
@@ -1363,8 +1363,9 @@ void virtio_gpu_device_realize(DeviceState *qdev, Error **errp)
VirtIOGPU *g = VIRTIO_GPU(qdev);
if (virtio_gpu_blob_enabled(g->parent_obj.conf)) {
- if (!virtio_gpu_have_udmabuf()) {
- error_setg(errp, "cannot enable blob resources without udmabuf");
+ if (!virtio_gpu_rutabaga_enabled(g->parent_obj.conf) &&
+ !virtio_gpu_have_udmabuf()) {
+ error_setg(errp, "need rutabaga or udmabuf for blob resources");
return;
}
diff --git a/softmmu/qdev-monitor.c b/softmmu/qdev-monitor.c
index 74f4e41338..1b8005ae55 100644
--- a/softmmu/qdev-monitor.c
+++ b/softmmu/qdev-monitor.c
@@ -86,6 +86,9 @@ static const QDevAlias qdev_alias_table[] = {
{ "virtio-gpu-pci", "virtio-gpu", QEMU_ARCH_VIRTIO_PCI },
{ "virtio-gpu-gl-device", "virtio-gpu-gl", QEMU_ARCH_VIRTIO_MMIO },
{ "virtio-gpu-gl-pci", "virtio-gpu-gl", QEMU_ARCH_VIRTIO_PCI },
+ { "virtio-gpu-rutabaga-device", "virtio-gpu-rutabaga",
+ QEMU_ARCH_VIRTIO_MMIO },
+ { "virtio-gpu-rutabaga-pci", "virtio-gpu-rutabaga", QEMU_ARCH_VIRTIO_PCI },
{ "virtio-input-host-device", "virtio-input-host", QEMU_ARCH_VIRTIO_MMIO },
{ "virtio-input-host-ccw", "virtio-input-host", QEMU_ARCH_VIRTIO_CCW },
{ "virtio-input-host-pci", "virtio-input-host", QEMU_ARCH_VIRTIO_PCI },
diff --git a/softmmu/vl.c b/softmmu/vl.c
index 98e071e63b..dd82c6eb13 100644
--- a/softmmu/vl.c
+++ b/softmmu/vl.c
@@ -215,6 +215,7 @@ static struct {
{ .driver = "ati-vga", .flag = &default_vga },
{ .driver = "vhost-user-vga", .flag = &default_vga },
{ .driver = "virtio-vga-gl", .flag = &default_vga },
+ { .driver = "virtio-vga-rutabaga", .flag = &default_vga },
};
static QemuOptsList qemu_rtc_opts = {
--
2.42.0.582.g8ccd20d70d-goog
next prev parent reply other threads:[~2023-10-03 20:46 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 20:44 [PATCH v15 0/9] rutabaga_gfx + gfxstream Gurchetan Singh
2023-10-03 20:44 ` [PATCH v15 1/9] virtio: Add shared memory capability Gurchetan Singh
2023-10-03 20:44 ` [PATCH v15 2/9] virtio-gpu: CONTEXT_INIT feature Gurchetan Singh
2023-10-03 20:44 ` [PATCH v15 3/9] virtio-gpu: hostmem Gurchetan Singh
2023-10-03 20:44 ` [PATCH v15 4/9] virtio-gpu: blob prep Gurchetan Singh
2023-10-03 20:44 ` [PATCH v15 5/9] gfxstream + rutabaga prep: added need defintions, fields, and options Gurchetan Singh
2023-10-03 20:44 ` [PATCH v15 6/9] gfxstream + rutabaga: add initial support for gfxstream Gurchetan Singh
2023-10-04 8:19 ` Marc-André Lureau
2023-10-03 20:44 ` [PATCH v15 7/9] gfxstream + rutabaga: meson support Gurchetan Singh
2023-10-03 20:44 ` Gurchetan Singh [this message]
2023-10-03 20:45 ` [PATCH v15 9/9] docs/system: add basic virtio-gpu documentation Gurchetan Singh
2024-01-16 10:42 ` [PATCH v15 0/9] rutabaga_gfx + gfxstream Alyssa Ross
2024-01-19 17:52 ` Gurchetan Singh
2024-01-19 21:13 ` Alyssa Ross
2024-01-19 22:53 ` Gurchetan Singh
2024-01-20 12:18 ` Alyssa Ross
2024-01-26 2:15 ` Gurchetan Singh
2024-01-26 14:22 ` Alyssa Ross
2024-01-31 3:10 ` Gurchetan Singh
2024-02-14 0:48 ` Gurchetan Singh
2024-03-02 14:37 ` rutabaga 0.1.3 Alyssa Ross
2024-03-05 0:23 ` Gurchetan Singh
2024-03-22 21:20 ` Alyssa Ross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231003204500.518-9-gurchetansingh@chromium.org \
--to=gurchetansingh@chromium.org \
--cc=akihiko.odaki@gmail.com \
--cc=alex.bennee@linaro.org \
--cc=ernunes@redhat.com \
--cc=hi@alyssa.is \
--cc=manos.pitsidianakis@linaro.org \
--cc=marcandre.lureau@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
--cc=ray.huang@amd.com \
--cc=shentey@gmail.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).