From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"Cédric Le Goater" <clg@kaod.org>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Kevin Wolf" <kwolf@redhat.com>,
"Andrew Jeffery" <andrew@aj.id.au>,
"John Snow" <jsnow@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Cleber Rosa" <crosa@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, "Joel Stanley" <joel@jms.id.au>,
qemu-block@nongnu.org, "Beraldo Leal" <bleal@redhat.com>,
"Vladimir Sementsov-Ogievskiy" <vsementsov@yandex-team.ru>,
"Hanna Reitz" <hreitz@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Vladimir Sementsov-Ogievskiy" <v.sementsov-og@mail.ru>,
"Thomas Huth" <thuth@redhat.com>,
"Eric Blake" <eblake@redhat.com>,
"Ani Sinha" <anisinha@redhat.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Markus Armbruster" <armbru@redhat.com>
Subject: [PULL 1/9] Python/iotests: Add type hint for nbd module
Date: Wed, 4 Oct 2023 15:46:05 -0400 [thread overview]
Message-ID: <20231004194613.2900323-2-jsnow@redhat.com> (raw)
In-Reply-To: <20231004194613.2900323-1-jsnow@redhat.com>
The test bails gracefully if this module isn't installed, but linters
need a little help understanding that. It's enough to just declare the
type in this case.
(Fixes pylint complaining about use of an uninitialized variable because
it isn't wise enough to understand the notrun call is noreturn.)
Signed-off-by: John Snow <jsnow@redhat.com>
---
tests/qemu-iotests/tests/nbd-multiconn | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/tests/nbd-multiconn b/tests/qemu-iotests/tests/nbd-multiconn
index 478a1eaba27..7e686a786ea 100755
--- a/tests/qemu-iotests/tests/nbd-multiconn
+++ b/tests/qemu-iotests/tests/nbd-multiconn
@@ -20,6 +20,8 @@
import os
from contextlib import contextmanager
+from types import ModuleType
+
import iotests
from iotests import qemu_img_create, qemu_io
@@ -28,7 +30,7 @@ disk = os.path.join(iotests.test_dir, 'disk')
size = '4M'
nbd_sock = os.path.join(iotests.sock_dir, 'nbd_sock')
nbd_uri = 'nbd+unix:///{}?socket=' + nbd_sock
-
+nbd: ModuleType
@contextmanager
def open_nbd(export_name):
--
2.41.0
next prev parent reply other threads:[~2023-10-04 19:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-04 19:46 [PULL 0/9] Python patches John Snow
2023-10-04 19:46 ` John Snow [this message]
2023-10-05 14:05 ` [PULL 1/9] Python/iotests: Add type hint for nbd module Eric Blake
2023-10-05 14:55 ` John Snow
2023-10-04 19:46 ` [PULL 2/9] python/machine: move socket setup out of _base_args property John Snow
2023-10-04 19:46 ` [PULL 3/9] python/machine: close sock_pair in cleanup path John Snow
2023-10-04 19:46 ` [PULL 4/9] python/console_socket: accept existing FD in initializer John Snow
2023-10-04 19:46 ` [PULL 5/9] python/machine: use socketpair() for console connections John Snow
2023-10-04 19:46 ` [PULL 6/9] python/machine: use socketpair() for qtest connection John Snow
2023-10-04 19:46 ` [PULL 7/9] python/machine: remove unused sock_dir argument John Snow
2023-10-04 19:46 ` [PULL 8/9] python/qmp: remove Server.wait_closed() call for Python 3.12 John Snow
2023-10-04 19:46 ` [PULL 9/9] Python: test " John Snow
2023-10-05 4:48 ` [PULL 0/9] Python patches Philippe Mathieu-Daudé
2023-10-05 13:00 ` Stefan Hajnoczi
2023-10-05 14:59 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231004194613.2900323-2-jsnow@redhat.com \
--to=jsnow@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=andrew@aj.id.au \
--cc=anisinha@redhat.com \
--cc=armbru@redhat.com \
--cc=bleal@redhat.com \
--cc=clg@kaod.org \
--cc=crosa@redhat.com \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=hreitz@redhat.com \
--cc=joel@jms.id.au \
--cc=kwolf@redhat.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=v.sementsov-og@mail.ru \
--cc=vsementsov@yandex-team.ru \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).