From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>
Cc: qemu-arm@nongnu.org, qemu-ppc@nongnu.org, qemu-block@nongnu.org,
qemu-s390x@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH v2 00/22] qapi: Kill 'qapi/qmp/qerror.h' for good
Date: Thu, 5 Oct 2023 06:50:17 +0200 [thread overview]
Message-ID: <20231005045041.52649-1-philmd@linaro.org> (raw)
Since v1:
- Fixed checkpatch warnings (Juan)
- Added R-b tags
- New patch for 'vcpu_dirty_limit'
Hi,
This is kind of a selfish series. I'm really tired to grep
and read this comment from 2015 in qapi/qmp/qerror.h:
/*
* These macros will go away, please don't use
* in new code, and do not add new ones!
*/
Besides, these definitions are still added in recent code
(see for example commit 09f9ec9913 from June 2023). So
let's finish with this 8 years old technical debt.
Overall it took me 3h: 1h to find the correct Coccinelle
doc about Python use and read it again [*], then 1h to
adapt the script for each patch, rest is testing and
writing comments, so the scripts used could be used as
reference later.
Regards,
Phil.
[*] https://www.lrz.de/services/compute/courses/x_lecturenotes/hspc1w19.pdf
Philippe Mathieu-Daudé (22):
qapi: Inline and remove QERR_BUS_NO_HOTPLUG definition
qapi: Inline and remove QERR_DEVICE_HAS_NO_MEDIUM definition
qapi: Inline and remove QERR_DEVICE_IN_USE definition
qapi: Inline and remove QERR_DEVICE_NO_HOTPLUG definition
qapi: Inline QERR_INVALID_PARAMETER definition (constant parameter)
qapi: Inline and remove QERR_INVALID_PARAMETER definition
qapi: Inline QERR_INVALID_PARAMETER_TYPE definition (constant param)
qapi: Inline QERR_INVALID_PARAMETER_TYPE definition (constant value)
qapi: Inline and remove QERR_INVALID_PARAMETER_TYPE definition
qapi: Correct error message for 'vcpu_dirty_limit' parameter
qapi: Inline QERR_INVALID_PARAMETER_VALUE definition (constant value)
qapi: Inline QERR_INVALID_PARAMETER_VALUE definition (constant param)
qapi: Inline and remove QERR_INVALID_PARAMETER_VALUE definition
qapi: Inline and remove QERR_IO_ERROR definition
qapi: Inline and remove QERR_MIGRATION_ACTIVE definition
qapi: Inline QERR_MISSING_PARAMETER definition (constant parameter)
qapi: Inline and remove QERR_MISSING_PARAMETER definition
qapi: Inline and remove QERR_PROPERTY_VALUE_BAD definition
qapi: Inline and remove QERR_PROPERTY_VALUE_OUT_OF_RANGE definition
qapi: Inline and remove QERR_QGA_COMMAND_FAILED definition
RFC qapi: Inline and remove QERR_UNSUPPORTED definition
qapi: Remove 'qapi/qmp/qerror.h' header
qga/qapi-schema.json | 5 +-
include/qapi/qmp/qerror.h | 62 -------------------
backends/cryptodev-vhost-user.c | 5 +-
backends/dbus-vmstate.c | 3 +-
backends/rng-egd.c | 5 +-
backends/rng-random.c | 4 +-
block/gluster.c | 22 +++----
block/monitor/block-hmp-cmds.c | 7 +--
block/quorum.c | 4 +-
block/snapshot.c | 5 +-
block/vmdk.c | 9 ++-
blockdev.c | 16 +++--
blockjob.c | 4 +-
chardev/char-fe.c | 3 +-
chardev/char.c | 4 +-
dump/dump.c | 11 ++--
dump/win_dump.c | 5 +-
hw/core/qdev-properties-system.c | 6 +-
hw/core/qdev-properties.c | 3 +-
hw/core/qdev.c | 4 +-
hw/intc/openpic.c | 4 +-
hw/ppc/spapr_pci.c | 5 +-
hw/usb/redirect.c | 7 +--
migration/migration.c | 7 +--
migration/options.c | 102 +++++++++++++------------------
migration/page_cache.c | 9 ++-
migration/ram.c | 5 +-
migration/savevm.c | 7 +--
monitor/fds.c | 9 ++-
monitor/hmp-cmds.c | 3 +-
monitor/qmp-cmds.c | 4 +-
net/filter-buffer.c | 4 +-
net/filter.c | 8 +--
net/net.c | 10 ++-
qapi/opts-visitor.c | 12 ++--
qapi/qapi-forward-visitor.c | 3 +-
qapi/qapi-util.c | 4 +-
qapi/qapi-visit-core.c | 5 +-
qapi/qobject-input-visitor.c | 53 ++++++++--------
qapi/string-input-visitor.c | 27 ++++----
qga/commands-bsd.c | 9 ++-
qga/commands-posix.c | 47 +++++++-------
qga/commands-win32.c | 65 ++++++++++----------
qga/commands.c | 10 +--
qom/object.c | 16 +++--
qom/object_interfaces.c | 3 +-
qom/qom-qmp-cmds.c | 8 +--
softmmu/balloon.c | 3 +-
softmmu/cpus.c | 8 +--
softmmu/qdev-monitor.c | 24 ++++----
softmmu/rtc.c | 1 -
softmmu/tpm.c | 8 +--
softmmu/vl.c | 5 +-
target/arm/arm-qmp-cmds.c | 4 +-
target/i386/cpu.c | 15 +++--
target/s390x/cpu_models_sysemu.c | 4 +-
ui/input-barrier.c | 3 +-
ui/ui-qmp-cmds.c | 7 +--
util/block-helpers.c | 4 +-
util/qemu-option.c | 21 +++----
scripts/qapi/visit.py | 5 +-
61 files changed, 308 insertions(+), 437 deletions(-)
delete mode 100644 include/qapi/qmp/qerror.h
--
2.41.0
next reply other threads:[~2023-10-05 4:56 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-05 4:50 Philippe Mathieu-Daudé [this message]
2023-10-05 4:50 ` [PATCH v2 01/22] qapi: Inline and remove QERR_BUS_NO_HOTPLUG definition Philippe Mathieu-Daudé
2023-10-05 5:55 ` Cédric Le Goater
2023-10-20 5:49 ` Markus Armbruster
2023-10-05 4:50 ` [PATCH v2 02/22] qapi: Inline and remove QERR_DEVICE_HAS_NO_MEDIUM definition Philippe Mathieu-Daudé
2023-10-20 6:00 ` Markus Armbruster
2023-10-05 4:50 ` [PATCH v2 03/22] qapi: Inline and remove QERR_DEVICE_IN_USE definition Philippe Mathieu-Daudé
2023-10-05 4:50 ` [PATCH v2 04/22] qapi: Inline and remove QERR_DEVICE_NO_HOTPLUG definition Philippe Mathieu-Daudé
2023-10-20 6:03 ` Markus Armbruster
2023-10-05 4:50 ` [PATCH v2 05/22] qapi: Inline QERR_INVALID_PARAMETER definition (constant parameter) Philippe Mathieu-Daudé
2023-10-20 7:07 ` Markus Armbruster
2023-10-05 4:50 ` [PATCH v2 06/22] qapi: Inline and remove QERR_INVALID_PARAMETER definition Philippe Mathieu-Daudé
2023-10-20 7:16 ` Markus Armbruster
2023-10-05 4:50 ` [PATCH v2 07/22] qapi: Inline QERR_INVALID_PARAMETER_TYPE definition (constant param) Philippe Mathieu-Daudé
2023-10-20 7:18 ` Markus Armbruster
2023-10-05 4:50 ` [PATCH v2 08/22] qapi: Inline QERR_INVALID_PARAMETER_TYPE definition (constant value) Philippe Mathieu-Daudé
2023-10-05 4:50 ` [PATCH v2 09/22] qapi: Inline and remove QERR_INVALID_PARAMETER_TYPE definition Philippe Mathieu-Daudé
2023-10-05 4:50 ` [PATCH v2 10/22] qapi: Correct error message for 'vcpu_dirty_limit' parameter Philippe Mathieu-Daudé
2023-10-05 6:33 ` Juan Quintela
2023-10-20 8:33 ` Markus Armbruster
2023-10-20 9:55 ` Juan Quintela
2023-10-05 4:50 ` [PATCH v2 11/22] qapi: Inline QERR_INVALID_PARAMETER_VALUE definition (constant value) Philippe Mathieu-Daudé
2023-10-05 6:34 ` Juan Quintela
2023-10-20 11:32 ` Markus Armbruster
2023-10-05 4:50 ` [PATCH v2 12/22] qapi: Inline QERR_INVALID_PARAMETER_VALUE definition (constant param) Philippe Mathieu-Daudé
2023-10-05 4:50 ` [PATCH v2 13/22] qapi: Inline and remove QERR_INVALID_PARAMETER_VALUE definition Philippe Mathieu-Daudé
2023-10-05 4:50 ` [PATCH v2 14/22] qapi: Inline and remove QERR_IO_ERROR definition Philippe Mathieu-Daudé
2023-10-20 11:50 ` Markus Armbruster
2023-10-05 4:50 ` [PATCH v2 15/22] qapi: Inline and remove QERR_MIGRATION_ACTIVE definition Philippe Mathieu-Daudé
2023-10-05 4:50 ` [PATCH v2 16/22] qapi: Inline QERR_MISSING_PARAMETER definition (constant parameter) Philippe Mathieu-Daudé
2023-10-20 12:58 ` Markus Armbruster
2023-10-05 4:50 ` [PATCH v2 17/22] qapi: Inline and remove QERR_MISSING_PARAMETER definition Philippe Mathieu-Daudé
2023-10-05 4:50 ` [PATCH v2 18/22] qapi: Inline and remove QERR_PROPERTY_VALUE_BAD definition Philippe Mathieu-Daudé
2023-10-20 13:00 ` Markus Armbruster
2023-10-05 4:50 ` [PATCH v2 19/22] qapi: Inline and remove QERR_PROPERTY_VALUE_OUT_OF_RANGE definition Philippe Mathieu-Daudé
2023-10-20 13:08 ` Markus Armbruster
2023-10-05 4:50 ` [PATCH v2 20/22] qapi: Inline and remove QERR_QGA_COMMAND_FAILED definition Philippe Mathieu-Daudé
2023-10-20 13:03 ` Markus Armbruster
2023-10-05 4:50 ` [RFC PATCH v2 21/22] qapi: Inline and remove QERR_UNSUPPORTED definition Philippe Mathieu-Daudé
2023-10-05 11:22 ` Markus Armbruster
2023-10-05 11:57 ` Markus Armbruster
2024-06-12 12:23 ` Philippe Mathieu-Daudé
2024-06-12 13:07 ` Markus Armbruster
2024-06-12 13:27 ` Konstantin Kostiuk
2024-06-12 13:45 ` Philippe Mathieu-Daudé
2023-10-05 11:57 ` Markus Armbruster
2023-10-05 4:50 ` [PATCH v2 22/22] qapi: Remove 'qapi/qmp/qerror.h' header Philippe Mathieu-Daudé
2023-10-05 9:26 ` [PATCH v2 00/22] qapi: Kill 'qapi/qmp/qerror.h' for good Markus Armbruster
2023-10-20 13:15 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231005045041.52649-1-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=armbru@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-s390x@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).