From: "Michael S. Tsirkin" <mst@redhat.com>
To: Damien Zammit <damien@zamaudio.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org
Subject: Re: [PATCH qemu] timer/i8254: Fix one shot PIT mode
Date: Fri, 6 Oct 2023 01:19:00 -0400 [thread overview]
Message-ID: <20231006011738-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <57fad6fa-c27c-b534-c644-1f96318f8972@zamaudio.com>
On Fri, Oct 06, 2023 at 02:36:52AM +0000, Damien Zammit wrote:
> >From: Michael Tokarev <mjt@tls.msk.ru>
> >26.02.2023 04:58, Damien Zammit wrote:
> >> Currently, the one-shot (mode 1) PIT expires far too quickly,
> >> due to the output being set under the wrong logic.
> >> This change fixes the one-shot PIT mode to behave similarly to mode 0.
> >>
> >> TESTED: using the one-shot PIT mode to calibrate a local apic timer.
> >
> >Has this been forgotten, or is it not needed anymore?
>
> This is still required but nobody uses the
> PIT one-shot mode (probably because it *is* currently broken).
>
> Can it be merged?
>
> Thanks,
> Damien
OK, I tagged it. thanks!
next prev parent reply other threads:[~2023-10-06 5:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-06 2:36 [PATCH qemu] timer/i8254: Fix one shot PIT mode Damien Zammit
2023-10-06 5:19 ` Michael S. Tsirkin [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-02-26 1:58 Damien Zammit
2023-02-26 8:51 ` Michael S. Tsirkin
2023-02-26 9:17 ` Damien Zammit
2023-02-26 9:45 ` Max Filippov
2023-02-26 12:11 ` BALATON Zoltan
2023-02-26 13:03 ` Michael S. Tsirkin
2023-05-15 16:15 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231006011738-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=damien@zamaudio.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).