From: Fabiano Rosas <farosas@suse.de>
To: qemu-devel@nongnu.org
Cc: "Juan Quintela" <quintela@redhat.com>,
"Peter Xu" <peterx@redhat.com>,
"Leonardo Bras" <leobras@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Thomas Huth" <thuth@redhat.com>
Subject: [PATCH v2 0/9] tests/migration-test: Allow testing older machine types
Date: Fri, 6 Oct 2023 09:39:01 -0300 [thread overview]
Message-ID: <20231006123910.17759-1-farosas@suse.de> (raw)
This adds support for running migration-test with two different QEMU
versions to test migration compatibility. The tests automatically
choose the latest machine type supported by both QEMU versions.
changes:
- introduce *_with_env variants of the relevant functions [Daniel, Juan]
- keep the requirement for having the QTEST_QEMU_BINARY always
present. qtest_get_arch() is used extensively in the qtest_add*
functions. It would be too much churn to pass a different binary
into it.
- with this^ we also need to keep the requirement for using only one
of SRC|DST. Otherwise it would be confusing to have three binaries
listed.
- query the alias to find out the machine types [Daniel]
I haven't looked into the docker part for now. I think Daniel's
suggestion of QTEST_QEMU_BINARY_SRC='podman run ... qemu-system-foo'
looks interesting. Do we have the latest release already built in the
registry at any given point?
Thanks
v1:
https://lore.kernel.org/r/20231003141932.2367-1-farosas@suse.de
Hi, I had this WIP patch laying around that seems to fit Juan's vision
about testing older machine types. It is a very rough draft for now,
but it may be useful for kickstarting the discussion.
With this we can give the tests two different QEMU versions. The test
picks the older machine type between the two and runs the whole
migration-test suite.
We'd just need a way to provide the older build. Currently I'm doing
this by hand.
sample output:
# Using two different QEMU binaries. Common machine type: pc-i440fx-8.1
...
# Using ./qemu-system-x86_64 (v8.1.0-952-g8a940312a2-dirty) as migration source
...
# Using ../build-8.1.0/qemu-system-x86_64 (v8.1.0-dirty) as migration destination
Let me know what you think.
Fabiano Rosas (9):
tests/qtest: Allow qtest_qemu_binary to use a custom environment
variable
tests/qtest: Introduce qtest_init_with_env
tests/qtest: Allow qtest_get_machines to use an alternate QEMU binary
tests/qtest: Introduce qtest_has_machine_with_env
tests/qtest: Introduce qtest_resolve_machine_alias
tests/qtest/migration: Introduce find_common_machine_version
tests/qtest/migration: Define a machine for all architectures
tests/qtest/migration: Support more than one QEMU binary
tests/qtest: Don't print messages from query instances
tests/qtest/libqtest.c | 86 +++++++++++++++++++++++++++------
tests/qtest/libqtest.h | 32 ++++++++++++
tests/qtest/migration-helpers.c | 24 +++++++++
tests/qtest/migration-helpers.h | 2 +
tests/qtest/migration-test.c | 36 ++++++++++++--
5 files changed, 162 insertions(+), 18 deletions(-)
--
2.35.3
next reply other threads:[~2023-10-06 12:41 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-06 12:39 Fabiano Rosas [this message]
2023-10-06 12:39 ` [PATCH v2 1/9] tests/qtest: Allow qtest_qemu_binary to use a custom environment variable Fabiano Rosas
2023-10-11 14:17 ` Juan Quintela
2023-10-11 14:30 ` Thomas Huth
2023-10-11 14:32 ` Juan Quintela
2023-10-11 14:55 ` Thomas Huth
2023-10-06 12:39 ` [PATCH v2 2/9] tests/qtest: Introduce qtest_init_with_env Fabiano Rosas
2023-10-11 14:20 ` Juan Quintela
2023-10-11 14:56 ` Thomas Huth
2023-10-06 12:39 ` [PATCH v2 3/9] tests/qtest: Allow qtest_get_machines to use an alternate QEMU binary Fabiano Rosas
2023-10-11 14:22 ` Juan Quintela
2023-10-11 15:05 ` Thomas Huth
2023-10-12 7:49 ` Thomas Huth
2023-10-12 14:53 ` Fabiano Rosas
2023-10-16 16:00 ` Fabiano Rosas
2023-10-06 12:39 ` [PATCH v2 4/9] tests/qtest: Introduce qtest_has_machine_with_env Fabiano Rosas
2023-10-11 14:22 ` Juan Quintela
2023-10-11 15:06 ` Thomas Huth
2023-10-06 12:39 ` [PATCH v2 5/9] tests/qtest: Introduce qtest_resolve_machine_alias Fabiano Rosas
2023-10-11 14:23 ` Juan Quintela
2023-10-11 15:25 ` Thomas Huth
2023-10-11 15:47 ` Thomas Huth
2023-10-06 12:39 ` [PATCH v2 6/9] tests/qtest/migration: Introduce find_common_machine_version Fabiano Rosas
2023-10-11 14:25 ` Juan Quintela
2023-10-11 15:50 ` Thomas Huth
2023-10-06 12:39 ` [PATCH v2 7/9] tests/qtest/migration: Define a machine for all architectures Fabiano Rosas
2023-10-11 14:28 ` Juan Quintela
2023-10-11 14:40 ` Fabiano Rosas
2023-10-11 14:48 ` Daniel P. Berrangé
2023-10-11 14:59 ` Fabiano Rosas
2023-10-17 12:53 ` Fabiano Rosas
2023-10-11 15:55 ` Thomas Huth
2023-10-06 12:39 ` [PATCH v2 8/9] tests/qtest/migration: Support more than one QEMU binary Fabiano Rosas
2023-10-11 14:31 ` Juan Quintela
2023-10-06 12:39 ` [PATCH v2 9/9] tests/qtest: Don't print messages from query instances Fabiano Rosas
2023-10-11 14:31 ` Juan Quintela
2023-10-11 15:59 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231006123910.17759-1-farosas@suse.de \
--to=farosas@suse.de \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=leobras@redhat.com \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).