qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fabiano Rosas <farosas@suse.de>
To: qemu-devel@nongnu.org
Cc: "Juan Quintela" <quintela@redhat.com>,
	"Peter Xu" <peterx@redhat.com>,
	"Leonardo Bras" <leobras@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Daniel P . Berrangé" <berrange@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Thomas Huth" <thuth@redhat.com>,
	"Laurent Vivier" <lvivier@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>
Subject: [PATCH v2 9/9] tests/qtest: Don't print messages from query instances
Date: Fri,  6 Oct 2023 09:39:10 -0300	[thread overview]
Message-ID: <20231006123910.17759-10-farosas@suse.de> (raw)
In-Reply-To: <20231006123910.17759-1-farosas@suse.de>

Now that we can query more than one binary, the "starting QEMU..."
message can get a little noisy. Mute those messages unless we're
running with --verbose.

Only affects qtest_init() calls from within libqtest. The tests
continue to output as usual.

Signed-off-by: Fabiano Rosas <farosas@suse.de>
---
 tests/qtest/libqtest.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c
index f2f1756de1..ea844ad7bc 100644
--- a/tests/qtest/libqtest.c
+++ b/tests/qtest/libqtest.c
@@ -91,6 +91,7 @@ struct QTestState
 
 static GHookList abrt_hooks;
 static void (*sighandler_old)(int);
+static bool silence_spawn_log;
 
 static int qtest_query_target_endianness(QTestState *s);
 
@@ -405,7 +406,9 @@ static QTestState *G_GNUC_PRINTF(2, 3) qtest_spawn_qemu(const char *qemu_bin,
 
     qtest_add_abrt_handler(kill_qemu_hook_func, s);
 
-    g_test_message("starting QEMU: %s", command->str);
+    if (!silence_spawn_log) {
+        g_test_message("starting QEMU: %s", command->str);
+    }
 
 #ifndef _WIN32
     s->qemu_pid = fork();
@@ -1465,6 +1468,8 @@ static struct MachInfo *qtest_get_machines(const char *var)
         return machines;
     }
 
+    silence_spawn_log = !g_test_verbose();
+
     qts = qtest_init_with_env(qemu_var, "-machine none");
     response = qtest_qmp(qts, "{ 'execute': 'query-machines' }");
     g_assert(response);
@@ -1496,6 +1501,8 @@ static struct MachInfo *qtest_get_machines(const char *var)
     qtest_quit(qts);
     qobject_unref(response);
 
+    silence_spawn_log = false;
+
     memset(&machines[idx], 0, sizeof(struct MachInfo)); /* Terminating entry */
     return machines;
 }
-- 
2.35.3



  parent reply	other threads:[~2023-10-06 12:41 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-06 12:39 [PATCH v2 0/9] tests/migration-test: Allow testing older machine types Fabiano Rosas
2023-10-06 12:39 ` [PATCH v2 1/9] tests/qtest: Allow qtest_qemu_binary to use a custom environment variable Fabiano Rosas
2023-10-11 14:17   ` Juan Quintela
2023-10-11 14:30     ` Thomas Huth
2023-10-11 14:32       ` Juan Quintela
2023-10-11 14:55   ` Thomas Huth
2023-10-06 12:39 ` [PATCH v2 2/9] tests/qtest: Introduce qtest_init_with_env Fabiano Rosas
2023-10-11 14:20   ` Juan Quintela
2023-10-11 14:56   ` Thomas Huth
2023-10-06 12:39 ` [PATCH v2 3/9] tests/qtest: Allow qtest_get_machines to use an alternate QEMU binary Fabiano Rosas
2023-10-11 14:22   ` Juan Quintela
2023-10-11 15:05   ` Thomas Huth
2023-10-12  7:49   ` Thomas Huth
2023-10-12 14:53     ` Fabiano Rosas
2023-10-16 16:00       ` Fabiano Rosas
2023-10-06 12:39 ` [PATCH v2 4/9] tests/qtest: Introduce qtest_has_machine_with_env Fabiano Rosas
2023-10-11 14:22   ` Juan Quintela
2023-10-11 15:06   ` Thomas Huth
2023-10-06 12:39 ` [PATCH v2 5/9] tests/qtest: Introduce qtest_resolve_machine_alias Fabiano Rosas
2023-10-11 14:23   ` Juan Quintela
2023-10-11 15:25   ` Thomas Huth
2023-10-11 15:47   ` Thomas Huth
2023-10-06 12:39 ` [PATCH v2 6/9] tests/qtest/migration: Introduce find_common_machine_version Fabiano Rosas
2023-10-11 14:25   ` Juan Quintela
2023-10-11 15:50   ` Thomas Huth
2023-10-06 12:39 ` [PATCH v2 7/9] tests/qtest/migration: Define a machine for all architectures Fabiano Rosas
2023-10-11 14:28   ` Juan Quintela
2023-10-11 14:40     ` Fabiano Rosas
2023-10-11 14:48     ` Daniel P. Berrangé
2023-10-11 14:59       ` Fabiano Rosas
2023-10-17 12:53     ` Fabiano Rosas
2023-10-11 15:55   ` Thomas Huth
2023-10-06 12:39 ` [PATCH v2 8/9] tests/qtest/migration: Support more than one QEMU binary Fabiano Rosas
2023-10-11 14:31   ` Juan Quintela
2023-10-06 12:39 ` Fabiano Rosas [this message]
2023-10-11 14:31   ` [PATCH v2 9/9] tests/qtest: Don't print messages from query instances Juan Quintela
2023-10-11 15:59   ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231006123910.17759-10-farosas@suse.de \
    --to=farosas@suse.de \
    --cc=alex.bennee@linaro.org \
    --cc=berrange@redhat.com \
    --cc=leobras@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).