* [PATCH] scripts/xml-preprocess: Make sure this script is invoked via the right Python
@ 2023-10-06 4:52 Thomas Huth
2023-10-06 5:11 ` Marc-André Lureau
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Thomas Huth @ 2023-10-06 4:52 UTC (permalink / raw)
To: qemu-devel, Marc-André Lureau; +Cc: Paolo Bonzini, qemu-trivial
If a script is executable and has a shebang line, Meson treats it as
a normal executable, so that this script here is run via the "python3"
binary in the $PATH. However, "python3" might not be in the $PATH at
all, or it might be a wrong version, so we should make sure to run
this script via the Python version that has been chosen for the QEMU
build process. The best way to do this is to remove the executable bit
from the access mode bits. (See also commit 4b424c757188f7a4)
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1918
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
scripts/xml-preprocess.py | 0
1 file changed, 0 insertions(+), 0 deletions(-)
mode change 100755 => 100644 scripts/xml-preprocess.py
diff --git a/scripts/xml-preprocess.py b/scripts/xml-preprocess.py
old mode 100755
new mode 100644
--
2.41.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scripts/xml-preprocess: Make sure this script is invoked via the right Python
2023-10-06 4:52 [PATCH] scripts/xml-preprocess: Make sure this script is invoked via the right Python Thomas Huth
@ 2023-10-06 5:11 ` Marc-André Lureau
2023-10-06 6:42 ` Michael Tokarev
2023-10-09 7:01 ` Paolo Bonzini
2 siblings, 0 replies; 4+ messages in thread
From: Marc-André Lureau @ 2023-10-06 5:11 UTC (permalink / raw)
To: Thomas Huth; +Cc: qemu-devel, Paolo Bonzini, qemu-trivial
On Fri, Oct 6, 2023 at 8:53 AM Thomas Huth <thuth@redhat.com> wrote:
>
> If a script is executable and has a shebang line, Meson treats it as
> a normal executable, so that this script here is run via the "python3"
> binary in the $PATH. However, "python3" might not be in the $PATH at
> all, or it might be a wrong version, so we should make sure to run
> this script via the Python version that has been chosen for the QEMU
> build process. The best way to do this is to remove the executable bit
> from the access mode bits. (See also commit 4b424c757188f7a4)
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1918
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
thanks
> ---
> scripts/xml-preprocess.py | 0
> 1 file changed, 0 insertions(+), 0 deletions(-)
> mode change 100755 => 100644 scripts/xml-preprocess.py
>
> diff --git a/scripts/xml-preprocess.py b/scripts/xml-preprocess.py
> old mode 100755
> new mode 100644
> --
> 2.41.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scripts/xml-preprocess: Make sure this script is invoked via the right Python
2023-10-06 4:52 [PATCH] scripts/xml-preprocess: Make sure this script is invoked via the right Python Thomas Huth
2023-10-06 5:11 ` Marc-André Lureau
@ 2023-10-06 6:42 ` Michael Tokarev
2023-10-09 7:01 ` Paolo Bonzini
2 siblings, 0 replies; 4+ messages in thread
From: Michael Tokarev @ 2023-10-06 6:42 UTC (permalink / raw)
To: Thomas Huth, qemu-devel, Marc-André Lureau
Cc: Paolo Bonzini, qemu-trivial
Applied to my trivial-patches tree, thanks!
/mjt
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scripts/xml-preprocess: Make sure this script is invoked via the right Python
2023-10-06 4:52 [PATCH] scripts/xml-preprocess: Make sure this script is invoked via the right Python Thomas Huth
2023-10-06 5:11 ` Marc-André Lureau
2023-10-06 6:42 ` Michael Tokarev
@ 2023-10-09 7:01 ` Paolo Bonzini
2 siblings, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2023-10-09 7:01 UTC (permalink / raw)
To: Thomas Huth; +Cc: qemu-devel, Marc-André Lureau, qemu-trivial
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-10-09 7:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-06 4:52 [PATCH] scripts/xml-preprocess: Make sure this script is invoked via the right Python Thomas Huth
2023-10-06 5:11 ` Marc-André Lureau
2023-10-06 6:42 ` Michael Tokarev
2023-10-09 7:01 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).