From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, "Alberto Garcia" <berto@igalia.com>,
"Hao Wu" <wuhaotsh@google.com>, "Kevin Wolf" <kwolf@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Laurent Vivier" <lvivier@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
qemu-block@nongnu.org, "John Snow" <jsnow@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Fam Zheng" <fam@euphon.net>, "Tyrone Ting" <kfting@nuvoton.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH 05/10] tests/hd-geo-test: Clean up global variable shadowing
Date: Mon, 9 Oct 2023 12:02:46 +0200 [thread overview]
Message-ID: <20231009100251.56019-6-philmd@linaro.org> (raw)
In-Reply-To: <20231009100251.56019-1-philmd@linaro.org>
Rename the variable to fix:
tests/qtest/hd-geo-test.c:610:11: error: declaration shadows a variable in the global scope [-Werror,-Wshadow]
char *img_file_name;
^
tests/qtest/hd-geo-test.c:80:14: note: previous declaration is here
static char *img_file_name[backend_last];
^
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
tests/qtest/hd-geo-test.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/tests/qtest/hd-geo-test.c b/tests/qtest/hd-geo-test.c
index d08bffad91..e5e28c412d 100644
--- a/tests/qtest/hd-geo-test.c
+++ b/tests/qtest/hd-geo-test.c
@@ -78,6 +78,7 @@ static const CHST hd_chst[backend_last][mbr_last] = {
};
static char *img_file_name[backend_last];
+static char *qcow2_imgpath;
static const CHST *cur_ide[4];
@@ -607,18 +608,17 @@ static TestArgs *create_args(void)
static void add_drive_with_mbr(TestArgs *args,
MBRpartitions mbr, uint64_t sectors)
{
- char *img_file_name;
char part[300];
int ret;
g_assert(args->n_drives < MAX_DRIVES);
- img_file_name = create_qcow2_with_mbr(mbr, sectors);
+ qcow2_imgpath = create_qcow2_with_mbr(mbr, sectors);
- args->drives[args->n_drives] = img_file_name;
+ args->drives[args->n_drives] = qcow2_imgpath;
ret = snprintf(part, sizeof(part),
"-drive file=%s,if=none,format=qcow2,id=disk%d",
- img_file_name, args->n_drives);
+ qcow2_imgpath, args->n_drives);
g_assert((0 < ret) && (ret <= sizeof(part)));
args->argc = append_arg(args->argc, args->argv, ARGV_SIZE, g_strdup(part));
args->n_drives++;
@@ -1139,6 +1139,10 @@ test_add_done:
g_free(img_file_name[i]);
}
}
+ if (qcow2_imgpath) {
+ unlink(qcow2_imgpath);
+ g_free(qcow2_imgpath);
+ }
return ret;
}
--
2.41.0
next prev parent reply other threads:[~2023-10-09 10:06 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-09 10:02 [PATCH 00/10] tests: Clean up global variables shadowing Philippe Mathieu-Daudé
2023-10-09 10:02 ` [PATCH 01/10] system/qtest: Clean up global variable shadowing in qtest_server_init() Philippe Mathieu-Daudé
2023-10-13 5:56 ` Thomas Huth
2023-10-09 10:02 ` [PATCH 02/10] tests/throttle: Clean up global variable shadowing Philippe Mathieu-Daudé
2023-10-09 10:10 ` Alberto Garcia
2023-10-09 10:02 ` [PATCH 03/10] tests/virtio-scsi: " Philippe Mathieu-Daudé
2023-10-13 5:57 ` Thomas Huth
2023-10-13 7:24 ` Manos Pitsidianakis
2023-10-09 10:02 ` [PATCH 04/10] tests/cdrom-test: Clean up global variable shadowing in prepare_image() Philippe Mathieu-Daudé
2023-10-12 20:46 ` John Snow
2023-10-09 10:02 ` Philippe Mathieu-Daudé [this message]
2023-10-09 10:06 ` [PATCH 05/10] tests/hd-geo-test: Clean up global variable shadowing Philippe Mathieu-Daudé
2023-10-09 10:02 ` [PATCH 06/10] tests/rtl8139: " Philippe Mathieu-Daudé
2023-10-13 6:14 ` Thomas Huth
2023-10-09 10:02 ` [PATCH 07/10] tests/npcm7xx_adc: " Philippe Mathieu-Daudé
2023-10-13 6:15 ` Thomas Huth
2023-10-09 10:02 ` [PATCH 08/10] tests/aio: " Philippe Mathieu-Daudé
2023-10-13 6:24 ` Thomas Huth
2023-10-09 10:02 ` [PATCH 09/10] tests/aio-multithread: " Philippe Mathieu-Daudé
2023-10-13 6:26 ` Thomas Huth
2023-10-09 10:02 ` [PATCH 10/10] tests/coroutine: " Philippe Mathieu-Daudé
2023-10-13 6:27 ` Thomas Huth
2023-10-27 7:39 ` [PATCH 00/10] tests: Clean up global variables shadowing Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231009100251.56019-6-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=armbru@redhat.com \
--cc=berto@igalia.com \
--cc=fam@euphon.net \
--cc=jsnow@redhat.com \
--cc=kfting@nuvoton.com \
--cc=kwolf@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
--cc=wuhaotsh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).