From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3FD13CD613C for ; Mon, 9 Oct 2023 21:28:53 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qpxn0-0002FE-Mj; Mon, 09 Oct 2023 17:27:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qpxmz-0002ES-0p for qemu-devel@nongnu.org; Mon, 09 Oct 2023 17:27:45 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qpxmx-0000kn-0S for qemu-devel@nongnu.org; Mon, 09 Oct 2023 17:27:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696886861; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k3VBARoml2XeuseKnZjUU7dweEiU7QqIS1/01swcVTc=; b=LidxvYa5ZEIDOxfZMu9yZ/clfRPIoLp7AsEG01jBZWXFGLi8MXTpwEYFUpCyf3YlBzNXrI LvDhzeOE3xFTeAE26W2Z2wDFAOEVX4Sev2nzE8CuuioVM3fuHdbzpXnWpAIQTI94B0xqw3 87esEpAi21WZEKCrU3I/JWsZyFGfynA= Received: from mail-io1-f71.google.com (mail-io1-f71.google.com [209.85.166.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-457-VLn0MFmIOemYfpp-1-8hAg-1; Mon, 09 Oct 2023 17:27:39 -0400 X-MC-Unique: VLn0MFmIOemYfpp-1-8hAg-1 Received: by mail-io1-f71.google.com with SMTP id ca18e2360f4ac-79fa06105b0so285976239f.0 for ; Mon, 09 Oct 2023 14:27:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696886859; x=1697491659; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=k3VBARoml2XeuseKnZjUU7dweEiU7QqIS1/01swcVTc=; b=hC6jRTqBneDZ1soOwMzHVyQWjfu2drBd1hldDBe1Mpdz4gLJgkQy3zn1qkCbEcu7aj AbF3qsInmk8yJ8kGKpJQrnQZBGzX4L+egwFfvP8HXZ+yGD7yoSaRfRcokltzdnj6xG4V U4uUXhffsQqLrVtzIA8Rh1FdAxO1jYxeQkwZYPJzRtg5bUKA7V4KD32zgFIukAu/mRfL QMxtqk0Xua16VqHgM5qTeqLC3fYA2iIxTI47BciDjCwpbH8LF6OjCimEDvhmhnA+/WPo rT2XfKe8+jIyGJ5bm218hqEVVR6y1G4/DmresZm9VtCC7tkpKSf07tkPrw5EQyQ1F+Zr Luzw== X-Gm-Message-State: AOJu0Yz9Y3cq1NNThGPhIPZ9Y1O8bhcXoXA1wDbWkkkumwLtv65Ywkag 3Pc3HAqjT3XjgrxwQ2b7DOtbbRvaRblMAkw9BU2iM+47nzCs4Ia3geHGBFiSNOONJFKHDIUKrJ9 0LqeJt6+f0keYHoU= X-Received: by 2002:a05:6e02:78b:b0:34f:6b04:d8c8 with SMTP id q11-20020a056e02078b00b0034f6b04d8c8mr9472986ils.16.1696886858838; Mon, 09 Oct 2023 14:27:38 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHDtAAn1ROwm5m0p6RUk2uAallxthovzEyKSeL1wnh+TT8qPdy0V5C7Hc0bE/TCHJIF2+UFyQ== X-Received: by 2002:a05:6e02:78b:b0:34f:6b04:d8c8 with SMTP id q11-20020a056e02078b00b0034f6b04d8c8mr9472977ils.16.1696886858527; Mon, 09 Oct 2023 14:27:38 -0700 (PDT) Received: from redhat.com ([38.15.60.12]) by smtp.gmail.com with ESMTPSA id p13-20020a92d48d000000b0034e28740e35sm3177127ilg.78.2023.10.09.14.27.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 14:27:37 -0700 (PDT) Date: Mon, 9 Oct 2023 15:27:35 -0600 From: Alex Williamson To: Jonathan Cameron Cc: , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v2 3/3] qom: Link multiple numa nodes to device using a new object Message-ID: <20231009152735.658313f7.alex.williamson@redhat.com> In-Reply-To: <20231009133048.00003535@Huawei.com> References: <20231007201740.30335-1-ankita@nvidia.com> <20231007201740.30335-4-ankita@nvidia.com> <20231009133048.00003535@Huawei.com> Organization: Red Hat MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=alex.williamson@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Mon, 9 Oct 2023 13:30:48 +0100 Jonathan Cameron wrote: > On Sun, 8 Oct 2023 01:47:40 +0530 > wrote: > > > From: Ankit Agrawal > > > > NVIDIA GPU's support MIG (Mult-Instance GPUs) feature [1], which allows > > partitioning of the GPU device resources (including device memory) into > > several (upto 8) isolated instances. Each of the partitioned memory needs > > a dedicated NUMA node to operate. The partitions are not fixed and they > > can be created/deleted at runtime. > > > > Unfortunately Linux OS does not provide a means to dynamically create/destroy > > NUMA nodes and such feature implementation is not expected to be trivial. The > > nodes that OS discovers at the boot time while parsing SRAT remains fixed. So > > we utilize the GI Affinity structures that allows association between nodes > > and devices. Multiple GI structures per BDF is possible, allowing creation of > > multiple nodes by exposing unique PXM in each of these structures. > > > > Introducing a new nvidia-acpi-generic-initiator object, which inherits from > > the generic acpi-generic-initiator object to allow a BDF to be associated with > > more than 1 nodes. > > > > An admin can provide the range of nodes using numa-node-start and > > numa-node-count and link it to a device by providing its id. The following > > sample creates 8 nodes and link them to the device dev0: > > > > -numa node,nodeid=2 \ > > -numa node,nodeid=3 \ > > -numa node,nodeid=4 \ > > -numa node,nodeid=5 \ > > -numa node,nodeid=6 \ > > -numa node,nodeid=7 \ > > -numa node,nodeid=8 \ > > -numa node,nodeid=9 \ > > -device vfio-pci-nohotplug,host=0009:01:00.0,bus=pcie.0,addr=04.0,rombar=0,id=dev0 \ > > -object nvidia-acpi-generic-initiator,id=gi0,device=dev0,numa-node-start=2,numa-node-count=8 \ > > If you go this way, use an array of references to the numa nodes instead of a start and number. > There is no obvious reason why they should be contiguous that I can see. Yup, I was looking for other places we allow a list syntax, I only found fds=a:b:...:z, which is also used for vhostfds=. I didn't find a property beyond the string type to hold this though. > I think it is simpler the other way around though - so have the numa nodes point at the > vfio-pci-nohotplug device. Do you have a syntax you'd propose for this? I'm having trouble seeing how it makes things simpler. Thanks, Alex > > [1] https://www.nvidia.com/en-in/technologies/multi-instance-gpu > > > > Signed-off-by: Ankit Agrawal > > --- > > hw/acpi/acpi-generic-initiator.c | 61 ++++++++++++++++++++++++ > > include/hw/acpi/acpi-generic-initiator.h | 12 +++++ > > qapi/qom.json | 24 +++++++++- > > 3 files changed, 95 insertions(+), 2 deletions(-) > > > > diff --git a/hw/acpi/acpi-generic-initiator.c b/hw/acpi/acpi-generic-initiator.c > > index 1ae79639be..8ef887c3a4 100644 > > --- a/hw/acpi/acpi-generic-initiator.c > > +++ b/hw/acpi/acpi-generic-initiator.c > > @@ -150,3 +150,64 @@ void build_srat_generic_initiator(GArray *table_data) > > } > > g_slist_free(list); > > } > > + > > +static void > > +nvidia_acpi_generic_initiator_set_node_start(Object *obj, Visitor *v, > > + const char *name, void *opaque, > > + Error **errp) > > +{ > > + AcpiGenericInitiator *gi = ACPI_GENERIC_INITIATOR(obj); > > + uint32_t value; > > + > > + if (!visit_type_uint32(v, name, &value, errp)) { > > + return; > > + } > > + > > + if (value >= MAX_NODES) { > > + return; > > + } > > + > > + gi->node = value; > > +} > > + > > +static void > > +nvidia_acpi_generic_initiator_set_node_count(Object *obj, Visitor *v, > > + const char *name, void *opaque, > > + Error **errp) > > +{ > > + AcpiGenericInitiator *gi = ACPI_GENERIC_INITIATOR(obj); > > + uint32_t value; > > + > > + if (!visit_type_uint32(v, name, &value, errp)) { > > + return; > > + } > > + > > + gi->node_count = value; > > +} > > + > > +static void nvidia_acpi_generic_initiator_class_init(ObjectClass *oc, void *data) > > +{ > > + object_class_property_add(oc, NVIDIA_ACPI_GENERIC_INITIATOR_NODE_START_PROP, > > + "uint32", NULL, > > + nvidia_acpi_generic_initiator_set_node_start, > > + NULL, NULL); > > + object_class_property_add(oc, NVIDIA_ACPI_GENERIC_INITIATOR_NODE_COUNT_PROP, > > + "uint32", NULL, > > + nvidia_acpi_generic_initiator_set_node_count, > > + NULL, NULL); > > +} > > + > > +static const TypeInfo nvidia_acpi_generic_initiator_info = { > > + .parent = TYPE_ACPI_GENERIC_INITIATOR, > > + .name = TYPE_NVIDIA_ACPI_GENERIC_INITIATOR, > > + .instance_size = sizeof(NvidiaAcpiGenericInitiator), > > + .class_size = sizeof(NvidiaAcpiGenericInitiatorClass), > > + .class_init = nvidia_acpi_generic_initiator_class_init, > > +}; > > + > > +static void > > +nvidia_acpi_generic_initiator_register_types(void) > > +{ > > + type_register_static(&nvidia_acpi_generic_initiator_info); > > +} > > +type_init(nvidia_acpi_generic_initiator_register_types); > > diff --git a/include/hw/acpi/acpi-generic-initiator.h b/include/hw/acpi/acpi-generic-initiator.h > > index e8e2670309..3e4cf42064 100644 > > --- a/include/hw/acpi/acpi-generic-initiator.h > > +++ b/include/hw/acpi/acpi-generic-initiator.h > > @@ -9,10 +9,14 @@ > > #include "qom/object_interfaces.h" > > > > #define TYPE_ACPI_GENERIC_INITIATOR "acpi-generic-initiator" > > +#define TYPE_NVIDIA_ACPI_GENERIC_INITIATOR "nvidia-acpi-generic-initiator" > > > > #define ACPI_GENERIC_INITIATOR_DEVICE_PROP "device" > > #define ACPI_GENERIC_INITIATOR_NODE_PROP "node" > > > > +#define NVIDIA_ACPI_GENERIC_INITIATOR_NODE_START_PROP "numa-node-start" > > +#define NVIDIA_ACPI_GENERIC_INITIATOR_NODE_COUNT_PROP "numa-node-count" > > + > > typedef struct AcpiGenericInitiator { > > /* private */ > > Object parent; > > @@ -47,6 +51,14 @@ typedef struct PCIDeviceHandle { > > uint64_t res1; > > } PCIDeviceHandle; > > > > +typedef struct NvidiaAcpiGenericInitiator { > > + AcpiGenericInitiator parent; > > +} NvidiaAcpiGenericInitiator; > > + > > +typedef struct NvidiaAcpiGenericInitiatorClass { > > + AcpiGenericInitiatorClass parent_class; > > +} NvidiaAcpiGenericInitiatorClass; > > + > > void build_srat_generic_initiator(GArray *table_data); > > > > #endif > > diff --git a/qapi/qom.json b/qapi/qom.json > > index 86c87a161c..c29ad1388d 100644 > > --- a/qapi/qom.json > > +++ b/qapi/qom.json > > @@ -793,6 +793,24 @@ > > { 'struct': 'AcpiGenericInitiatorProperties', > > 'data': { 'device': 'str', 'node': 'uint32' } } > > > > +## > > +# @NvidiaAcpiGenericInitiatorProperties: > > +# > > +# Properties for nvidia-acpi-generic-initiator objects. > > +# > > +# @device: the ID of the device to be associated with the nodes > > +# > > +# @numa-node-start: the ID of the numa node > > +# > > +# @numa-node-count: count of the numa nodes assocuated with the device > > +# > > +# Since: 8.0 > > +## > > +{ 'struct': 'NvidiaAcpiGenericInitiatorProperties', > > + 'data': { 'device': 'str', > > + 'numa-node-start': 'uint32', > > + 'numa-node-count': 'uint32' } } > > + > > ## > > # @RngProperties: > > # > > @@ -962,7 +980,8 @@ > > 'tls-cipher-suites', > > { 'name': 'x-remote-object', 'features': [ 'unstable' ] }, > > { 'name': 'x-vfio-user-server', 'features': [ 'unstable' ] }, > > - 'acpi-generic-initiator' > > + 'acpi-generic-initiator', > > + 'nvidia-acpi-generic-initiator' > > ] } > > > > ## > > @@ -1030,7 +1049,8 @@ > > 'tls-cipher-suites': 'TlsCredsProperties', > > 'x-remote-object': 'RemoteObjectProperties', > > 'x-vfio-user-server': 'VfioUserServerProperties', > > - 'acpi-generic-initiator': 'AcpiGenericInitiatorProperties' > > + 'acpi-generic-initiator': 'AcpiGenericInitiatorProperties', > > + 'nvidia-acpi-generic-initiator': 'NvidiaAcpiGenericInitiatorProperties' > > } } > > > > ## >