qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Thomas Huth" <thuth@redhat.com>,
	"Xiaojuan Yang" <yangxiaojuan@loongson.cn>,
	"Cédric Le Goater" <clg@kaod.org>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>,
	"Brad Smith" <brad@comstyle.com>,
	"Radoslaw Biernacki" <rad@semihalf.com>,
	"David Hildenbrand" <david@redhat.com>,
	"Cleber Rosa" <crosa@redhat.com>,
	"Ilya Leoshkevich" <iii@linux.ibm.com>,
	qemu-riscv@nongnu.org,
	"Daniel Henrique Barboza" <danielhb413@gmail.com>,
	"Alexandre Iooss" <erdnaxe@crans.org>,
	"Nicholas Piggin" <npiggin@gmail.com>,
	"Bin Meng" <bin.meng@windriver.com>,
	"Leif Lindholm" <quic_llindhol@quicinc.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Eduardo Habkost" <eduardo@habkost.net>,
	"Alistair Francis" <alistair.francis@wdc.com>,
	qemu-ppc@nongnu.org, "John Snow" <jsnow@redhat.com>,
	"Liu Zhiwei" <zhiwei_liu@linux.alibaba.com>,
	qemu-arm@nongnu.org,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Yanan Wang" <wangyanan55@huawei.com>,
	"Weiwei Li" <liweiwei@iscas.ac.cn>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
	"Beraldo Leal" <bleal@redhat.com>,
	"Yoshinori Sato" <ysato@users.sourceforge.jp>,
	"Mahmoud Mandour" <ma.mandourr@gmail.com>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Song Gao" <gaosong@loongson.cn>,
	"Marcin Juszkiewicz" <marcin.juszkiewicz@linaro.org>,
	qemu-s390x@nongnu.org,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Akihiko Odaki" <akihiko.odaki@daynix.com>
Subject: [PATCH 13/25] target/arm: Move the reference to arm-core.xml
Date: Mon,  9 Oct 2023 17:40:52 +0100	[thread overview]
Message-ID: <20231009164104.369749-14-alex.bennee@linaro.org> (raw)
In-Reply-To: <20231009164104.369749-1-alex.bennee@linaro.org>

From: Akihiko Odaki <akihiko.odaki@daynix.com>

Some subclasses overwrite gdb_core_xml_file member but others don't.
Always initialize the member in the subclasses for consistency.

This especially helps for AArch64; in a following change, the file
specified by gdb_core_xml_file is always looked up even if it's going to
be overwritten later. Looking up arm-core.xml results in an error as
it will not be embedded in the AArch64 build.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20230912224107.29669-7-akihiko.odaki@daynix.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 target/arm/cpu.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/target/arm/cpu.c b/target/arm/cpu.c
index 831295d7cd..b65e8cfea3 100644
--- a/target/arm/cpu.c
+++ b/target/arm/cpu.c
@@ -2392,7 +2392,6 @@ static void arm_cpu_class_init(ObjectClass *oc, void *data)
     cc->sysemu_ops = &arm_sysemu_ops;
 #endif
     cc->gdb_num_core_regs = 26;
-    cc->gdb_core_xml_file = "arm-core.xml";
     cc->gdb_arch_name = arm_gdb_arch_name;
     cc->gdb_get_dynamic_xml = arm_gdb_get_dynamic_xml;
     cc->gdb_stop_before_watchpoint = true;
@@ -2414,8 +2413,10 @@ static void arm_cpu_instance_init(Object *obj)
 static void cpu_register_class_init(ObjectClass *oc, void *data)
 {
     ARMCPUClass *acc = ARM_CPU_CLASS(oc);
+    CPUClass *cc = CPU_CLASS(acc);
 
     acc->info = data;
+    cc->gdb_core_xml_file = "arm-core.xml";
 }
 
 void arm_cpu_register(const ARMCPUInfo *info)
-- 
2.39.2



  parent reply	other threads:[~2023-10-09 16:47 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-09 16:40 [PATCH 00/25] October maintainer omnibus pre-PR (tests, gdbstub, plugins) Alex Bennée
2023-10-09 16:40 ` [PATCH 01/25] tests/avocado: update firmware to enable OpenBSD test on sbsa-ref Alex Bennée
2023-10-09 16:40 ` [PATCH 02/25] tests/avocado: remove flaky test marking for test_sbsaref_edk2_firmware Alex Bennée
2023-10-10 11:56   ` Philippe Mathieu-Daudé
2023-10-09 16:40 ` [PATCH 03/25] tests/lcitool: add swtpm to the package list Alex Bennée
2023-10-10 11:57   ` Philippe Mathieu-Daudé
2023-10-09 16:40 ` [PATCH 04/25] gitlab: shuffle some targets and reduce avocado noise Alex Bennée
2023-10-09 16:40 ` [PATCH 05/25] tests/docker: make docker engine choice entirely configure driven Alex Bennée
2023-10-11  1:02   ` Alistair Francis
2023-10-09 16:40 ` [PATCH 06/25] configure: allow user to override docker engine Alex Bennée
2023-10-11  0:59   ` Alistair Francis
2023-10-09 16:40 ` [PATCH 07/25] configure: remove gcc version suffixes Alex Bennée
2023-10-10 11:57   ` Philippe Mathieu-Daudé
2023-10-09 16:40 ` [PATCH 08/25] gdbstub: Fix target_xml initialization Alex Bennée
2023-10-11  1:00   ` Alistair Francis
2023-10-09 16:40 ` [PATCH 09/25] gdbstub: Fix target.xml response Alex Bennée
2023-10-09 16:40 ` [PATCH 10/25] plugins: Check if vCPU is realized Alex Bennée
2023-10-09 16:40 ` [PATCH 11/25] contrib/plugins: Use GRWLock in execlog Alex Bennée
2023-10-09 16:40 ` [PATCH 12/25] gdbstub: Introduce GDBFeature structure Alex Bennée
2023-10-09 16:40 ` Alex Bennée [this message]
2023-10-09 16:40 ` [PATCH 14/25] hw/core/cpu: Return static value with gdb_arch_name() Alex Bennée
2023-10-11  0:55   ` Alistair Francis
2023-10-09 16:40 ` [PATCH 15/25] gdbstub: Use g_markup_printf_escaped() Alex Bennée
2023-10-09 16:40 ` [PATCH 16/25] target/arm: Remove references to gdb_has_xml Alex Bennée
2023-10-11  1:03   ` Alistair Francis
2023-10-09 16:40 ` [PATCH 17/25] target/ppc: " Alex Bennée
2023-10-09 16:40 ` [PATCH 18/25] gdbstub: Remove gdb_has_xml variable Alex Bennée
2023-10-11  0:58   ` Alistair Francis
2023-10-09 16:40 ` [PATCH 19/25] gdbstub: Replace gdb_regs with an array Alex Bennée
2023-10-11  0:57   ` Alistair Francis
2023-10-09 16:40 ` [PATCH 20/25] accel/tcg: Add plugin_enabled to DisasContextBase Alex Bennée
2023-10-09 16:41 ` [PATCH 21/25] target/sh4: Disable decode_gusa when plugins enabled Alex Bennée
2023-10-09 16:41 ` [PATCH 22/25] plugins: Set final instruction count in plugin_gen_tb_end Alex Bennée
2023-10-09 16:41 ` [PATCH 23/25] contrib/plugins: fix coverity warning in cache Alex Bennée
2023-10-09 16:41 ` [PATCH 24/25] contrib/plugins: fix coverity warning in lockstep Alex Bennée
2023-10-09 16:41 ` [PATCH 25/25] contrib/plugins: fix coverity warning in hotblocks Alex Bennée
2023-10-10 12:00   ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231009164104.369749-14-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=akihiko.odaki@daynix.com \
    --cc=alistair.francis@wdc.com \
    --cc=berrange@redhat.com \
    --cc=bin.meng@windriver.com \
    --cc=bleal@redhat.com \
    --cc=brad@comstyle.com \
    --cc=clg@kaod.org \
    --cc=crosa@redhat.com \
    --cc=danielhb413@gmail.com \
    --cc=david@redhat.com \
    --cc=eduardo@habkost.net \
    --cc=erdnaxe@crans.org \
    --cc=gaosong@loongson.cn \
    --cc=iii@linux.ibm.com \
    --cc=jsnow@redhat.com \
    --cc=kbastian@mail.uni-paderborn.de \
    --cc=liweiwei@iscas.ac.cn \
    --cc=ma.mandourr@gmail.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=marcin.juszkiewicz@linaro.org \
    --cc=npiggin@gmail.com \
    --cc=palmer@dabbelt.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=quic_llindhol@quicinc.com \
    --cc=rad@semihalf.com \
    --cc=richard.henderson@linaro.org \
    --cc=thuth@redhat.com \
    --cc=wainersm@redhat.com \
    --cc=wangyanan55@huawei.com \
    --cc=yangxiaojuan@loongson.cn \
    --cc=ysato@users.sourceforge.jp \
    --cc=zhiwei_liu@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).