From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "David Hildenbrand" <david@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Song Gao" <gaosong@loongson.cn>,
"Cédric Le Goater" <clg@kaod.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Laurent Vivier" <lvivier@redhat.com>,
"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>,
qemu-arm@nongnu.org, "Jiaxun Yang" <jiaxun.yang@flygoat.com>,
"Ilya Leoshkevich" <iii@linux.ibm.com>,
"Yoshinori Sato" <ysato@users.sourceforge.jp>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Weiwei Li" <liweiwei@iscas.ac.cn>,
"Nicholas Piggin" <npiggin@gmail.com>,
qemu-riscv@nongnu.org,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Bin Meng" <bin.meng@windriver.com>,
"Yanan Wang" <wangyanan55@huawei.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Alistair Francis" <alistair.francis@wdc.com>,
"Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
"Daniel Henrique Barboza" <danielhb413@gmail.com>,
"Marek Vasut" <marex@denx.de>,
"Peter Maydell" <peter.maydell@linaro.org>,
qemu-ppc@nongnu.org, "Michael Rolnik" <mrolnik@gmail.com>,
"Max Filippov" <jcmvbkbc@gmail.com>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"Laurent Vivier" <laurent@vivier.eu>,
"Stafford Horne" <shorne@gmail.com>,
"Thomas Huth" <thuth@redhat.com>,
"Chris Wulff" <crwulff@gmail.com>,
"Sergio Lopez" <slp@redhat.com>,
"Xiaojuan Yang" <yangxiaojuan@loongson.cn>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Liu Zhiwei" <zhiwei_liu@linux.alibaba.com>,
"Artyom Tarasenko" <atar4qemu@gmail.com>,
"Daniel Henrique Barboza" <dbarboza@ventanamicro.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Brian Cain" <bcain@quicinc.com>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Aurelien Jarno" <aurelien@aurel32.net>,
qemu-s390x@nongnu.org
Subject: [PATCH 18/18] target/sparc: Make SPARC_CPU common to new SPARC32_CPU/SPARC64_CPU types
Date: Tue, 10 Oct 2023 11:29:00 +0200 [thread overview]
Message-ID: <20231010092901.99189-19-philmd@linaro.org> (raw)
In-Reply-To: <20231010092901.99189-1-philmd@linaro.org>
"target/foo/cpu-qom.h" can not use any target specific definitions.
Currently "target/sparc/cpu-qom.h" defines TYPE_SPARC_CPU
depending on the sparc(32)/sparc64 build type. This doesn't
scale in a heterogeneous context where we need to access both
types concurrently.
In order to do that, introduce the new SPARC32_CPU / SPARC64_CPU
types, both inheriting a common TYPE_SPARC_CPU base type.
Keep the current CPU types registered in sparc_register_cpudef_type()
as 32 or 64-bit, depending on the binary built.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
target/sparc/cpu-qom.h | 9 ++++-----
target/sparc/cpu.h | 3 +++
target/sparc/cpu.c | 12 +++++++++++-
3 files changed, 18 insertions(+), 6 deletions(-)
diff --git a/target/sparc/cpu-qom.h b/target/sparc/cpu-qom.h
index 86b24a254a..d08fbd4ddc 100644
--- a/target/sparc/cpu-qom.h
+++ b/target/sparc/cpu-qom.h
@@ -23,13 +23,12 @@
#include "hw/core/cpu.h"
#include "qom/object.h"
-#ifdef TARGET_SPARC64
-#define TYPE_SPARC_CPU "sparc64-cpu"
-#else
#define TYPE_SPARC_CPU "sparc-cpu"
-#endif
+#define TYPE_SPARC32_CPU "sparc32-cpu"
+#define TYPE_SPARC64_CPU "sparc64-cpu"
-OBJECT_DECLARE_CPU_TYPE(SPARCCPU, SPARCCPUClass, SPARC_CPU)
+OBJECT_DECLARE_CPU_TYPE(SPARC32CPU, SPARCCPUClass, SPARC32_CPU)
+OBJECT_DECLARE_CPU_TYPE(SPARC64CPU, SPARCCPUClass, SPARC64_CPU)
#define SPARC_CPU_TYPE_SUFFIX "-" TYPE_SPARC_CPU
#define SPARC_CPU_TYPE_NAME(model) model SPARC_CPU_TYPE_SUFFIX
diff --git a/target/sparc/cpu.h b/target/sparc/cpu.h
index 924e83b9ce..0f94e5a442 100644
--- a/target/sparc/cpu.h
+++ b/target/sparc/cpu.h
@@ -12,6 +12,9 @@
#define TARGET_DPREGS 32
#endif
+/* Abstract QOM SPARC CPU, not exposed to other targets */
+OBJECT_DECLARE_CPU_TYPE(SPARCCPU, SPARCCPUClass, SPARC_CPU)
+
/*#define EXCP_INTERRUPT 0x100*/
/* Windowed register indexes. */
diff --git a/target/sparc/cpu.c b/target/sparc/cpu.c
index 1e66413e94..7d060ba488 100644
--- a/target/sparc/cpu.c
+++ b/target/sparc/cpu.c
@@ -934,6 +934,12 @@ static const TypeInfo sparc_cpu_types[] = {
.abstract = true,
.class_size = sizeof(SPARCCPUClass),
.class_init = sparc_cpu_class_init,
+ }, {
+ .name = TYPE_SPARC32_CPU,
+ .parent = TYPE_SPARC_CPU,
+ }, {
+ .name = TYPE_SPARC64_CPU,
+ .parent = TYPE_SPARC_CPU,
}
};
@@ -950,7 +956,11 @@ static void sparc_register_cpudef_type(const struct sparc_def_t *def)
char *typename = sparc_cpu_type_name(def->name);
TypeInfo ti = {
.name = typename,
- .parent = TYPE_SPARC_CPU,
+#ifdef TARGET_SPARC64
+ .parent = TYPE_SPARC64_CPU,
+#else
+ .parent = TYPE_SPARC32_CPU,
+#endif
.class_init = sparc_cpu_cpudef_class_init,
.class_data = (void *)def,
};
--
2.41.0
next prev parent reply other threads:[~2023-10-10 9:33 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-10 9:28 [PATCH 00/18] target: Make 'cpu-qom.h' really target agnostic Philippe Mathieu-Daudé
2023-10-10 9:28 ` [PATCH 01/18] target: Mention 'cpu-qom.h' is " Philippe Mathieu-Daudé
2023-10-13 3:55 ` Richard Henderson
2023-10-10 9:28 ` [PATCH 02/18] target/ppc: Remove CPU_RESOLVING_TYPE from 'cpu-qom.h' Philippe Mathieu-Daudé
2023-10-13 3:55 ` Richard Henderson
2023-10-10 9:28 ` [PATCH 03/18] target/riscv: " Philippe Mathieu-Daudé
2023-10-10 11:36 ` LIU Zhiwei
2023-10-13 3:57 ` Richard Henderson
2023-10-10 9:28 ` [PATCH 04/18] target: Declare FOO_CPU_TYPE_NAME/SUFFIX in 'cpu-qom.h' Philippe Mathieu-Daudé
2023-10-11 2:51 ` LIU Zhiwei
2023-10-11 3:21 ` Philippe Mathieu-Daudé
2023-10-11 6:12 ` LIU Zhiwei
2023-10-13 4:02 ` Richard Henderson
2023-10-10 9:28 ` [PATCH 05/18] target/hexagon: Declare QOM definitions " Philippe Mathieu-Daudé
2023-10-13 4:06 ` Richard Henderson
2023-10-13 9:18 ` Philippe Mathieu-Daudé
2023-10-10 9:28 ` [PATCH 06/18] target/loongarch: " Philippe Mathieu-Daudé
2023-10-10 11:33 ` gaosong
2023-10-10 9:28 ` [PATCH 07/18] target/nios2: " Philippe Mathieu-Daudé
2023-10-10 9:28 ` [PATCH 08/18] target/openrisc: " Philippe Mathieu-Daudé
2023-10-10 9:28 ` [PATCH 09/18] target/i386: Inline target specific TARGET_DEFAULT_CPU_TYPE definition Philippe Mathieu-Daudé
2023-10-13 4:09 ` Richard Henderson
2023-10-10 9:28 ` [PATCH 10/18] target/riscv: Inline target specific TYPE_RISCV_CPU_BASE definition Philippe Mathieu-Daudé
2023-10-10 11:33 ` LIU Zhiwei
2023-10-11 0:46 ` Alistair Francis
2023-10-13 4:13 ` Richard Henderson
2023-10-13 13:58 ` Philippe Mathieu-Daudé
2023-10-10 9:28 ` [PATCH 11/18] target/i386: Declare CPU QOM types using DEFINE_TYPES() macro Philippe Mathieu-Daudé
2023-10-13 4:17 ` Richard Henderson
2023-10-10 9:28 ` [PATCH 12/18] target/mips: " Philippe Mathieu-Daudé
2023-10-13 4:18 ` Richard Henderson
2023-10-10 9:28 ` [PATCH 13/18] target/ppc: " Philippe Mathieu-Daudé
2023-10-13 4:20 ` Richard Henderson
2023-10-10 9:28 ` [PATCH 14/18] target/sparc: " Philippe Mathieu-Daudé
2023-10-13 4:21 ` Richard Henderson
2023-10-13 18:25 ` Mark Cave-Ayland
2023-10-10 9:28 ` [PATCH 15/18] cpus: Open code OBJECT_DECLARE_TYPE() in OBJECT_DECLARE_CPU_TYPE() Philippe Mathieu-Daudé
2023-10-13 4:27 ` Richard Henderson
2023-10-13 12:47 ` Richard Henderson
2023-10-10 9:28 ` [PATCH 16/18] target/i386: Make X86_CPU common to new I386_CPU / X86_64_CPU types Philippe Mathieu-Daudé
2023-10-13 4:31 ` Richard Henderson
2023-10-10 9:28 ` [PATCH 17/18] target/mips: Make MIPS_CPU common to new MIPS32_CPU / MIPS64_CPU types Philippe Mathieu-Daudé
2023-10-13 4:34 ` Richard Henderson
2024-03-15 12:22 ` Philippe Mathieu-Daudé
2025-03-25 15:20 ` Philippe Mathieu-Daudé
2023-10-10 9:29 ` Philippe Mathieu-Daudé [this message]
2023-10-13 18:28 ` [PATCH 18/18] target/sparc: Make SPARC_CPU common to new SPARC32_CPU/SPARC64_CPU types Mark Cave-Ayland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231010092901.99189-19-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=aleksandar.rikalo@syrmia.com \
--cc=alistair.francis@wdc.com \
--cc=atar4qemu@gmail.com \
--cc=aurelien@aurel32.net \
--cc=bcain@quicinc.com \
--cc=bin.meng@windriver.com \
--cc=clg@kaod.org \
--cc=crwulff@gmail.com \
--cc=danielhb413@gmail.com \
--cc=david@redhat.com \
--cc=dbarboza@ventanamicro.com \
--cc=edgar.iglesias@gmail.com \
--cc=eduardo@habkost.net \
--cc=gaosong@loongson.cn \
--cc=iii@linux.ibm.com \
--cc=jcmvbkbc@gmail.com \
--cc=jiaxun.yang@flygoat.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=laurent@vivier.eu \
--cc=liweiwei@iscas.ac.cn \
--cc=lvivier@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=marex@denx.de \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mrolnik@gmail.com \
--cc=mst@redhat.com \
--cc=npiggin@gmail.com \
--cc=palmer@dabbelt.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=shorne@gmail.com \
--cc=slp@redhat.com \
--cc=thuth@redhat.com \
--cc=wangyanan55@huawei.com \
--cc=yangxiaojuan@loongson.cn \
--cc=ysato@users.sourceforge.jp \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).