From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Ilya Leoshkevich" <iii@linux.ibm.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Halil Pasic" <pasic@linux.ibm.com>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Yanan Wang" <wangyanan55@huawei.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Eric Farman" <farman@linux.ibm.com>,
qemu-s390x@nongnu.org,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
"Thomas Huth" <thuth@redhat.com>,
"Ani Sinha" <anisinha@redhat.com>,
"David Hildenbrand" <david@redhat.com>
Subject: [PATCH v2 0/6] hw: Clean up global variables shadowing
Date: Tue, 10 Oct 2023 13:50:42 +0200 [thread overview]
Message-ID: <20231010115048.11856-1-philmd@linaro.org> (raw)
Missing review: #1 #2 #3
v2:
- Addressed Ani's review comments (patches #2, #3)
- Added R-b tags
Clean up global variables shadowing in hw/ in
order to be able to use -Wshadow with Clang.
Philippe Mathieu-Daudé (6):
hw/core/cpu: Clean up global variable shadowing
hw/loader: Clean up global variable shadowing in rom_add_file()
hw/display/vga: Clean up global variable shadowing
hw/acpi/pcihp: Clean up global variable shadowing in acpi_pcihp_init()
hw/pci: Clean up global variable shadowing of address_space_io
variable
hw/s390x: Clean up global variable shadowing in
quiesce_powerdown_req()
hw/display/vga_int.h | 4 ++--
include/hw/acpi/pcihp.h | 2 +-
include/hw/core/cpu.h | 8 ++++----
include/hw/loader.h | 11 ++++++-----
include/hw/pci/pci.h | 9 +++------
cpu-common.c | 6 +++---
hw/acpi/pcihp.c | 5 ++---
hw/core/loader.c | 10 +++++-----
hw/display/vga.c | 12 ++++++------
hw/pci/pci.c | 25 +++++++++----------------
hw/s390x/sclpquiesce.c | 8 ++++----
target/s390x/cpu_models.c | 2 +-
12 files changed, 46 insertions(+), 56 deletions(-)
--
2.41.0
next reply other threads:[~2023-10-10 11:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-10 11:50 Philippe Mathieu-Daudé [this message]
2023-10-10 11:50 ` [PATCH v2 1/6] hw/core/cpu: Clean up global variable shadowing Philippe Mathieu-Daudé
2023-10-10 12:34 ` Ani Sinha
2023-10-10 11:50 ` [PATCH v2 2/6] hw/loader: Clean up global variable shadowing in rom_add_file() Philippe Mathieu-Daudé
2023-10-10 12:54 ` Ani Sinha
2023-10-10 11:50 ` [PATCH v2 3/6] hw/display/vga: Clean up global variable shadowing Philippe Mathieu-Daudé
2023-10-10 12:46 ` Ani Sinha
2023-10-10 12:50 ` Philippe Mathieu-Daudé
2023-10-10 12:51 ` Philippe Mathieu-Daudé
2023-10-10 11:50 ` [PATCH v2 4/6] hw/acpi/pcihp: Clean up global variable shadowing in acpi_pcihp_init() Philippe Mathieu-Daudé
2023-10-10 11:50 ` [PATCH v2 5/6] hw/pci: Clean up global variable shadowing of address_space_io variable Philippe Mathieu-Daudé
2023-10-10 11:50 ` [PATCH v2 6/6] hw/s390x: Clean up global variable shadowing in quiesce_powerdown_req() Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231010115048.11856-1-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=anisinha@redhat.com \
--cc=armbru@redhat.com \
--cc=borntraeger@linux.ibm.com \
--cc=david@redhat.com \
--cc=eduardo@habkost.net \
--cc=farman@linux.ibm.com \
--cc=iii@linux.ibm.com \
--cc=imammedo@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).