From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Song Gao" <gaosong@loongson.cn>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Xiaojuan Yang" <yangxiaojuan@loongson.cn>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH 2/2] hw/loongarch/virt: Remove unused ISA Bus
Date: Tue, 10 Oct 2023 15:53:42 +0200 [thread overview]
Message-ID: <20231010135342.40219-3-philmd@linaro.org> (raw)
In-Reply-To: <20231010135342.40219-1-philmd@linaro.org>
The LoongArch 'virt' machine doesn't use its ISA I/O region.
If a ISA device were to be mapped there, there is no support
for ISA IRQ. Unlikely useful. Simply remove.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
include/hw/loongarch/virt.h | 3 ---
hw/loongarch/virt.c | 5 -----
hw/loongarch/Kconfig | 1 -
3 files changed, 9 deletions(-)
diff --git a/include/hw/loongarch/virt.h b/include/hw/loongarch/virt.h
index f1659655c6..674f4655e0 100644
--- a/include/hw/loongarch/virt.h
+++ b/include/hw/loongarch/virt.h
@@ -16,8 +16,6 @@
#define LOONGARCH_MAX_CPUS 256
-#define VIRT_ISA_IO_BASE 0x18000000UL
-#define VIRT_ISA_IO_SIZE 0x0004000
#define VIRT_FWCFG_BASE 0x1e020000UL
#define VIRT_BIOS_BASE 0x1c000000UL
#define VIRT_BIOS_SIZE (4 * MiB)
@@ -38,7 +36,6 @@ struct LoongArchMachineState {
MemoryRegion lowmem;
MemoryRegion highmem;
- MemoryRegion isa_io;
MemoryRegion bios;
bool bios_loaded;
/* State for other subsystems/APIs: */
diff --git a/hw/loongarch/virt.c b/hw/loongarch/virt.c
index 2629128aed..91342ee3b8 100644
--- a/hw/loongarch/virt.c
+++ b/hw/loongarch/virt.c
@@ -874,11 +874,6 @@ static void loongarch_init(MachineState *machine)
machine_memory_devices_init(machine, device_mem_base, device_mem_size);
}
- /* Add isa io region */
- memory_region_init_alias(&lams->isa_io, NULL, "isa-io",
- get_system_io(), 0, VIRT_ISA_IO_SIZE);
- memory_region_add_subregion(address_space_mem, VIRT_ISA_IO_BASE,
- &lams->isa_io);
/* load the BIOS image. */
loongarch_firmware_init(lams);
diff --git a/hw/loongarch/Kconfig b/hw/loongarch/Kconfig
index fcd5f2b4b6..5727efed6d 100644
--- a/hw/loongarch/Kconfig
+++ b/hw/loongarch/Kconfig
@@ -5,7 +5,6 @@ config LOONGARCH_VIRT
imply VIRTIO_VGA
imply PCI_DEVICES
imply NVDIMM
- select ISA_BUS
select SERIAL
select VIRTIO_PCI
select PLATFORM_BUS
--
2.41.0
next prev parent reply other threads:[~2023-10-10 13:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-10 13:53 [PATCH 0/2] hw/loongarch/virt: Remove unused ISA bus Philippe Mathieu-Daudé
2023-10-10 13:53 ` [PATCH 1/2] hw/loongarch/virt: Remove unused ISA UART Philippe Mathieu-Daudé
2023-10-10 13:53 ` Philippe Mathieu-Daudé [this message]
2023-10-11 1:42 ` [PATCH 0/2] hw/loongarch/virt: Remove unused ISA bus gaosong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231010135342.40219-3-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=gaosong@loongson.cn \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yangxiaojuan@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).