[PATCH 0/2] hw/loongarch/virt: Remove unused ISA bus

[PATCH 0/2] hw/loongarch/virt: Remove unused ISA bus

[Philippe Mathieu-Daudé]

ISA bus and serial aren't used by the LoongArch virt
machine. Remove the dead code.

Philippe Mathieu-Daudé (2):
  hw/loongarch/virt: Remove unused ISA UART
  hw/loongarch/virt: Remove unused ISA Bus

 include/hw/loongarch/virt.h | 3 ---
 hw/loongarch/virt.c         | 5 -----
 hw/loongarch/Kconfig        | 2 --
 3 files changed, 10 deletions(-)

-- 
2.41.0

[PATCH 1/2] hw/loongarch/virt: Remove unused ISA UART

[Philippe Mathieu-Daudé]

The LoongArch 'virt' machine doesn't use any ISA UART.
No need to build the device model, remove its Kconfig entry.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 hw/loongarch/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/hw/loongarch/Kconfig b/hw/loongarch/Kconfig
index 1e7c5b43c5..fcd5f2b4b6 100644
--- a/hw/loongarch/Kconfig
+++ b/hw/loongarch/Kconfig
@@ -7,7 +7,6 @@ config LOONGARCH_VIRT
     imply NVDIMM
     select ISA_BUS
     select SERIAL
-    select SERIAL_ISA
     select VIRTIO_PCI
     select PLATFORM_BUS
     select LOONGARCH_IPI
-- 
2.41.0

[PATCH 2/2] hw/loongarch/virt: Remove unused ISA Bus

[Philippe Mathieu-Daudé]

The LoongArch 'virt' machine doesn't use its ISA I/O region.

If a ISA device were to be mapped there, there is no support
for ISA IRQ. Unlikely useful. Simply remove.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 include/hw/loongarch/virt.h | 3 ---
 hw/loongarch/virt.c         | 5 -----
 hw/loongarch/Kconfig        | 1 -
 3 files changed, 9 deletions(-)

diff --git a/include/hw/loongarch/virt.h b/include/hw/loongarch/virt.h
index f1659655c6..674f4655e0 100644
--- a/include/hw/loongarch/virt.h
+++ b/include/hw/loongarch/virt.h
@@ -16,8 +16,6 @@
 
 #define LOONGARCH_MAX_CPUS      256
 
-#define VIRT_ISA_IO_BASE        0x18000000UL
-#define VIRT_ISA_IO_SIZE        0x0004000
 #define VIRT_FWCFG_BASE         0x1e020000UL
 #define VIRT_BIOS_BASE          0x1c000000UL
 #define VIRT_BIOS_SIZE          (4 * MiB)
@@ -38,7 +36,6 @@ struct LoongArchMachineState {
 
     MemoryRegion lowmem;
     MemoryRegion highmem;
-    MemoryRegion isa_io;
     MemoryRegion bios;
     bool         bios_loaded;
     /* State for other subsystems/APIs: */
diff --git a/hw/loongarch/virt.c b/hw/loongarch/virt.c
index 2629128aed..91342ee3b8 100644
--- a/hw/loongarch/virt.c
+++ b/hw/loongarch/virt.c
@@ -874,11 +874,6 @@ static void loongarch_init(MachineState *machine)
         machine_memory_devices_init(machine, device_mem_base, device_mem_size);
     }
 
-    /* Add isa io region */
-    memory_region_init_alias(&lams->isa_io, NULL, "isa-io",
-                             get_system_io(), 0, VIRT_ISA_IO_SIZE);
-    memory_region_add_subregion(address_space_mem, VIRT_ISA_IO_BASE,
-                                &lams->isa_io);
     /* load the BIOS image. */
     loongarch_firmware_init(lams);
 
diff --git a/hw/loongarch/Kconfig b/hw/loongarch/Kconfig
index fcd5f2b4b6..5727efed6d 100644
--- a/hw/loongarch/Kconfig
+++ b/hw/loongarch/Kconfig
@@ -5,7 +5,6 @@ config LOONGARCH_VIRT
     imply VIRTIO_VGA
     imply PCI_DEVICES
     imply NVDIMM
-    select ISA_BUS
     select SERIAL
     select VIRTIO_PCI
     select PLATFORM_BUS
-- 
2.41.0

Re: [PATCH 0/2] hw/loongarch/virt: Remove unused ISA bus

[gaosong]

在 2023/10/10 下午9:53, Philippe Mathieu-Daudé 写道:
> ISA bus and serial aren't used by the LoongArch virt
> machine. Remove the dead code.
> 
> Philippe Mathieu-Daudé (2):
>    hw/loongarch/virt: Remove unused ISA UART
>    hw/loongarch/virt: Remove unused ISA Bus
> 
>   include/hw/loongarch/virt.h | 3 ---
>   hw/loongarch/virt.c         | 5 -----
>   hw/loongarch/Kconfig        | 2 --
>   3 files changed, 10 deletions(-)
> 

Reviewed-by: Song Gao <gaosong@loongson.cn>

Thanks.
Song Gao