From: David Hildenbrand <david@redhat.com>
To: qemu-devel@nongnu.org
Cc: David Hildenbrand <david@redhat.com>,
"Maciej S . Szmigiero" <maciej.szmigiero@oracle.com>,
"Michael S . Tsirkin" <mst@redhat.com>
Subject: [GIT PULL 05/18] vhost: Return number of free memslots
Date: Thu, 12 Oct 2023 16:36:42 +0200 [thread overview]
Message-ID: <20231012143655.114631-6-david@redhat.com> (raw)
In-Reply-To: <20231012143655.114631-1-david@redhat.com>
Let's return the number of free slots instead of only checking if there
is a free slot. Required to support memory devices that consume multiple
memslots.
This is a preparation for memory devices that consume multiple memslots.
Message-ID: <20230926185738.277351-6-david@redhat.com>
Reviewed-by: Maciej S. Szmigiero <maciej.szmigiero@oracle.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
---
hw/mem/memory-device.c | 2 +-
hw/virtio/vhost-stub.c | 4 ++--
hw/virtio/vhost.c | 4 ++--
include/hw/virtio/vhost.h | 2 +-
4 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/hw/mem/memory-device.c b/hw/mem/memory-device.c
index 98e355c960..e09960744d 100644
--- a/hw/mem/memory-device.c
+++ b/hw/mem/memory-device.c
@@ -63,7 +63,7 @@ static void memory_device_check_addable(MachineState *ms, MemoryRegion *mr,
error_setg(errp, "hypervisor has no free memory slots left");
return;
}
- if (!vhost_has_free_slot()) {
+ if (!vhost_get_free_memslots()) {
error_setg(errp, "a used vhost backend has no free memory slots left");
return;
}
diff --git a/hw/virtio/vhost-stub.c b/hw/virtio/vhost-stub.c
index aa858ef3fb..d53dd9d288 100644
--- a/hw/virtio/vhost-stub.c
+++ b/hw/virtio/vhost-stub.c
@@ -2,9 +2,9 @@
#include "hw/virtio/vhost.h"
#include "hw/virtio/vhost-user.h"
-bool vhost_has_free_slot(void)
+unsigned int vhost_get_free_memslots(void)
{
- return true;
+ return UINT_MAX;
}
bool vhost_user_init(VhostUserState *user, CharBackend *chr, Error **errp)
diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c
index 530a65c1b4..82c3d20521 100644
--- a/hw/virtio/vhost.c
+++ b/hw/virtio/vhost.c
@@ -54,7 +54,7 @@ static unsigned int used_shared_memslots;
static QLIST_HEAD(, vhost_dev) vhost_devices =
QLIST_HEAD_INITIALIZER(vhost_devices);
-bool vhost_has_free_slot(void)
+unsigned int vhost_get_free_memslots(void)
{
unsigned int free = UINT_MAX;
struct vhost_dev *hdev;
@@ -71,7 +71,7 @@ bool vhost_has_free_slot(void)
}
free = MIN(free, cur_free);
}
- return free > 0;
+ return free;
}
static void vhost_dev_sync_region(struct vhost_dev *dev,
diff --git a/include/hw/virtio/vhost.h b/include/hw/virtio/vhost.h
index 6a173cb9fa..603bf834be 100644
--- a/include/hw/virtio/vhost.h
+++ b/include/hw/virtio/vhost.h
@@ -315,7 +315,7 @@ uint64_t vhost_get_features(struct vhost_dev *hdev, const int *feature_bits,
*/
void vhost_ack_features(struct vhost_dev *hdev, const int *feature_bits,
uint64_t features);
-bool vhost_has_free_slot(void);
+unsigned int vhost_get_free_memslots(void);
int vhost_net_set_backend(struct vhost_dev *hdev,
struct vhost_vring_file *file);
--
2.41.0
next prev parent reply other threads:[~2023-10-12 14:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-12 14:36 [GIT PULL 00/18] Host Memory Backends and Memory devices queue 2023-10-12 David Hildenbrand
2023-10-12 14:36 ` [GIT PULL 01/18] vhost: Rework memslot filtering and fix "used_memslot" tracking David Hildenbrand
2023-10-12 14:36 ` [GIT PULL 02/18] vhost: Remove vhost_backend_can_merge() callback David Hildenbrand
2023-10-12 14:36 ` [GIT PULL 03/18] softmmu/physmem: Fixup qemu_ram_block_from_host() documentation David Hildenbrand
2023-10-12 14:36 ` [GIT PULL 04/18] kvm: Return number of free memslots David Hildenbrand
2023-10-12 14:36 ` David Hildenbrand [this message]
2023-10-12 14:36 ` [GIT PULL 06/18] memory-device: Support memory devices with multiple memslots David Hildenbrand
2023-10-12 14:36 ` [GIT PULL 07/18] stubs: Rename qmp_memory_device.c to memory_device.c David Hildenbrand
2023-10-12 14:36 ` [GIT PULL 08/18] memory-device: Track required and actually used memslots in DeviceMemoryState David Hildenbrand
2023-10-12 14:36 ` [GIT PULL 09/18] memory-device, vhost: Support memory devices that dynamically consume memslots David Hildenbrand
2023-10-12 14:36 ` [GIT PULL 10/18] kvm: Add stub for kvm_get_max_memslots() David Hildenbrand
2023-10-12 14:36 ` [GIT PULL 11/18] vhost: Add vhost_get_max_memslots() David Hildenbrand
2023-10-12 14:36 ` [GIT PULL 12/18] memory-device, vhost: Support automatic decision on the number of memslots David Hildenbrand
2023-10-12 14:36 ` [GIT PULL 13/18] memory: Clarify mapping requirements for RamDiscardManager David Hildenbrand
2023-10-12 14:36 ` [GIT PULL 14/18] virtio-mem: Pass non-const VirtIOMEM via virtio_mem_range_cb David Hildenbrand
2023-10-12 14:36 ` [GIT PULL 15/18] virtio-mem: Update state to match bitmap as soon as it's been migrated David Hildenbrand
2023-10-12 14:36 ` [GIT PULL 16/18] virtio-mem: Expose device memory dynamically via multiple memslots if enabled David Hildenbrand
2023-10-12 14:36 ` [GIT PULL 17/18] memory, vhost: Allow for marking memory device memory regions unmergeable David Hildenbrand
2023-10-12 14:36 ` [GIT PULL 18/18] virtio-mem: Mark memslot alias " David Hildenbrand
2023-10-16 19:19 ` [GIT PULL 00/18] Host Memory Backends and Memory devices queue 2023-10-12 Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231012143655.114631-6-david@redhat.com \
--to=david@redhat.com \
--cc=maciej.szmigiero@oracle.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).