From: Jonathan Cameron via <qemu-devel@nongnu.org>
To: Salil Mehta <salil.mehta@huawei.com>
Cc: <qemu-devel@nongnu.org>, <qemu-arm@nongnu.org>, <maz@kernel.org>,
<jean-philippe@linaro.org>, <lpieralisi@kernel.org>,
<peter.maydell@linaro.org>, <richard.henderson@linaro.org>,
<imammedo@redhat.com>, <andrew.jones@linux.dev>,
<david@redhat.com>, <philmd@linaro.org>, <eric.auger@redhat.com>,
<oliver.upton@linux.dev>, <pbonzini@redhat.com>, <mst@redhat.com>,
<will@kernel.org>, <gshan@redhat.com>, <rafael@kernel.org>,
<alex.bennee@linaro.org>, <linux@armlinux.org.uk>,
<darren@os.amperecomputing.com>, <ilkka@os.amperecomputing.com>,
<vishnu@os.amperecomputing.com>, <karl.heubaum@oracle.com>,
<miguel.luis@oracle.com>, <salil.mehta@opnsrc.net>,
<zhukeqian1@huawei.com>, <wangxiongfeng2@huawei.com>,
<wangyanan55@huawei.com>, <jiakernel2@gmail.com>,
<maobibo@loongson.cn>, <lixianglai@loongson.cn>,
<linuxarm@huawei.com>
Subject: Re: [PATCH V5 1/9] accel/kvm: Extract common KVM vCPU {creation,parking} code
Date: Thu, 12 Oct 2023 15:36:25 +0100 [thread overview]
Message-ID: <20231012153625.00005025@Huawei.com> (raw)
In-Reply-To: <20231011194355.15628-2-salil.mehta@huawei.com>
On Wed, 11 Oct 2023 20:43:47 +0100
Salil Mehta <salil.mehta@huawei.com> wrote:
> KVM vCPU creation is done once during the initialization of the VM when Qemu
> thread is spawned. This is common to all the architectures.
>
> Hot-unplug of vCPU results in destruction of the vCPU object in QOM but the
> corresponding KVM vCPU object in the Host KVM is not destroyed and its
> representative KVM vCPU object/context in Qemu is parked.
>
> Refactor common logic so that some APIs could be reused by vCPU Hotplug code.
If you are respinning I'd also call out that you added some trace points.
>
> Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
> Reviewed-by: Gavin Shan <gshan@redhat.com>
> Tested-by: Vishnu Pajjuri <vishnu@os.amperecomputing.com>
Otherwise LGTM as it's a straight forward refactor.
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Salil Mehta <salil.mehta@huawei.com>
Cc: <qemu-devel@nongnu.org>, <qemu-arm@nongnu.org>, <maz@kernel.org>,
<jean-philippe@linaro.org>, <lpieralisi@kernel.org>,
<peter.maydell@linaro.org>, <richard.henderson@linaro.org>,
<imammedo@redhat.com>, <andrew.jones@linux.dev>,
<david@redhat.com>, <philmd@linaro.org>, <eric.auger@redhat.com>,
<oliver.upton@linux.dev>, <pbonzini@redhat.com>, <mst@redhat.com>,
<will@kernel.org>, <gshan@redhat.com>, <rafael@kernel.org>,
<alex.bennee@linaro.org>, <linux@armlinux.org.uk>,
<darren@os.amperecomputing.com>, <ilkka@os.amperecomputing.com>,
<vishnu@os.amperecomputing.com>, <karl.heubaum@oracle.com>,
<miguel.luis@oracle.com>, <salil.mehta@opnsrc.net>,
<zhukeqian1@huawei.com>, <wangxiongfeng2@huawei.com>,
<wangyanan55@huawei.com>, <jiakernel2@gmail.com>,
<maobibo@loongson.cn>, <lixianglai@loongson.cn>,
<linuxarm@huawei.com>
Subject: Re: [PATCH V5 1/9] accel/kvm: Extract common KVM vCPU {creation,parking} code
Date: Thu, 12 Oct 2023 15:36:25 +0100 [thread overview]
Message-ID: <20231012153625.00005025@Huawei.com> (raw)
Message-ID: <20231012143625.buTkG-u_1BTuZZkJ_LMK4F4WhI_GEPczvQDXlpvvqCE@z> (raw)
In-Reply-To: <20231011194355.15628-2-salil.mehta@huawei.com>
On Wed, 11 Oct 2023 20:43:47 +0100
Salil Mehta <salil.mehta@huawei.com> wrote:
> KVM vCPU creation is done once during the initialization of the VM when Qemu
> thread is spawned. This is common to all the architectures.
>
> Hot-unplug of vCPU results in destruction of the vCPU object in QOM but the
> corresponding KVM vCPU object in the Host KVM is not destroyed and its
> representative KVM vCPU object/context in Qemu is parked.
>
> Refactor common logic so that some APIs could be reused by vCPU Hotplug code.
If you are respinning I'd also call out that you added some trace points.
>
> Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
> Reviewed-by: Gavin Shan <gshan@redhat.com>
> Tested-by: Vishnu Pajjuri <vishnu@os.amperecomputing.com>
Otherwise LGTM as it's a straight forward refactor.
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
next prev parent reply other threads:[~2023-10-12 14:36 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-11 19:43 [PATCH V5 0/9] Add architecture agnostic code to support vCPU Hotplug Salil Mehta via
2023-10-11 19:43 ` Salil Mehta
2023-10-11 19:43 ` [PATCH V5 1/9] accel/kvm: Extract common KVM vCPU {creation, parking} code Salil Mehta via
2023-10-11 19:43 ` Salil Mehta
2023-10-12 14:36 ` Jonathan Cameron via [this message]
2023-10-12 14:36 ` [PATCH V5 1/9] accel/kvm: Extract common KVM vCPU {creation,parking} code Jonathan Cameron
2023-10-12 14:38 ` Salil Mehta via
2023-10-12 14:38 ` Salil Mehta
2023-10-16 2:45 ` [PATCH V5 1/9] accel/kvm: Extract common KVM vCPU {creation, parking} code Shaoqin Huang
2023-10-16 2:47 ` Shaoqin Huang
2023-10-11 19:43 ` [PATCH V5 2/9] hw/acpi: Move CPU ctrl-dev MMIO region len macro to common header file Salil Mehta via
2023-10-11 19:43 ` Salil Mehta
2023-10-11 19:43 ` [PATCH V5 3/9] hw/acpi: Add ACPI CPU hotplug init stub Salil Mehta via
2023-10-11 19:43 ` Salil Mehta
2023-10-11 19:43 ` [PATCH V5 4/9] hw/acpi: Init GED framework with CPU hotplug events Salil Mehta via
2023-10-11 19:43 ` Salil Mehta
2023-10-16 2:53 ` Shaoqin Huang
2023-10-16 10:01 ` Salil Mehta via
2023-10-16 10:01 ` Salil Mehta
2023-10-11 19:43 ` [PATCH V5 5/9] hw/acpi: Update CPUs AML with cpu-(ctrl)dev change Salil Mehta via
2023-10-11 19:43 ` Salil Mehta
2023-10-12 14:49 ` Jonathan Cameron via
2023-10-12 14:49 ` Jonathan Cameron
2023-10-11 19:43 ` [PATCH V5 6/9] hw/acpi: Update GED _EVT method AML with CPU scan Salil Mehta via
2023-10-11 19:43 ` Salil Mehta
2023-10-11 19:43 ` [PATCH V5 7/9] hw/acpi: Update ACPI GED framework to support vCPU Hotplug Salil Mehta via
2023-10-11 19:43 ` Salil Mehta
2023-10-11 19:43 ` [PATCH V5 8/9] physmem: Add helper function to destroy CPU AddressSpace Salil Mehta via
2023-10-11 19:43 ` Salil Mehta
2023-10-11 23:31 ` Gavin Shan
2023-10-12 0:04 ` Salil Mehta
2023-10-12 0:18 ` Gavin Shan
2023-10-12 9:22 ` Salil Mehta via
2023-10-12 9:22 ` Salil Mehta
2023-10-11 19:43 ` [PATCH V5 9/9] gdbstub: Add helper function to unregister GDB register space Salil Mehta via
2023-10-11 19:43 ` Salil Mehta
2023-10-12 0:07 ` Gavin Shan
2023-10-12 9:19 ` Salil Mehta via
2023-10-12 9:19 ` Salil Mehta
2023-10-13 3:58 ` [PATCH V5 0/9] Add architecture agnostic code to support vCPU Hotplug lixianglai
2023-10-13 10:21 ` Salil Mehta via
2023-10-13 10:21 ` Salil Mehta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231012153625.00005025@Huawei.com \
--to=qemu-devel@nongnu.org \
--cc=Jonathan.Cameron@Huawei.com \
--cc=alex.bennee@linaro.org \
--cc=andrew.jones@linux.dev \
--cc=darren@os.amperecomputing.com \
--cc=david@redhat.com \
--cc=eric.auger@redhat.com \
--cc=gshan@redhat.com \
--cc=ilkka@os.amperecomputing.com \
--cc=imammedo@redhat.com \
--cc=jean-philippe@linaro.org \
--cc=jiakernel2@gmail.com \
--cc=karl.heubaum@oracle.com \
--cc=linux@armlinux.org.uk \
--cc=linuxarm@huawei.com \
--cc=lixianglai@loongson.cn \
--cc=lpieralisi@kernel.org \
--cc=maobibo@loongson.cn \
--cc=maz@kernel.org \
--cc=miguel.luis@oracle.com \
--cc=mst@redhat.com \
--cc=oliver.upton@linux.dev \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=rafael@kernel.org \
--cc=richard.henderson@linaro.org \
--cc=salil.mehta@huawei.com \
--cc=salil.mehta@opnsrc.net \
--cc=vishnu@os.amperecomputing.com \
--cc=wangxiongfeng2@huawei.com \
--cc=wangyanan55@huawei.com \
--cc=will@kernel.org \
--cc=zhukeqian1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).