From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org
Cc: Stefan Hajnoczi <stefanha@redhat.com>, Chris Rauer <crauer@google.com>
Subject: [PULL 3/7] tests/qtest: Fix npcm7xx_timer-test.c flaky test
Date: Thu, 12 Oct 2023 18:51:04 +0200 [thread overview]
Message-ID: <20231012165108.913443-4-thuth@redhat.com> (raw)
In-Reply-To: <20231012165108.913443-1-thuth@redhat.com>
From: Chris Rauer <crauer@google.com>
npcm7xx_timer-test occasionally fails due to the state of the timers
from the previous test iteration. Advancing the clock step after the
reset resolves this issue.
Fixes: https://gitlab.com/qemu-project/qemu/-/issues/1897
Signed-off-by: Chris Rauer <crauer@google.com>
Message-ID: <20230929000831.691559-1-crauer@google.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/qtest/npcm7xx_timer-test.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/qtest/npcm7xx_timer-test.c b/tests/qtest/npcm7xx_timer-test.c
index 43711049ca..58f58c2f71 100644
--- a/tests/qtest/npcm7xx_timer-test.c
+++ b/tests/qtest/npcm7xx_timer-test.c
@@ -465,6 +465,7 @@ static void test_periodic_interrupt(gconstpointer test_data)
int i;
tim_reset(td);
+ clock_step_next();
tim_write_ticr(td, count);
tim_write_tcsr(td, CEN | IE | MODE_PERIODIC | PRESCALE(ps));
--
2.41.0
next prev parent reply other threads:[~2023-10-12 16:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-12 16:51 [PULL 0/7] Misc patches Thomas Huth
2023-10-12 16:51 ` [PULL 1/7] hw/pvrdma: Protect against buggy or malicious guest driver Thomas Huth
2023-10-12 16:51 ` [PULL 2/7] hw/rdma: Deprecate the pvrdma device and the rdma subsystem Thomas Huth
2023-10-12 16:51 ` Thomas Huth [this message]
2023-10-12 16:51 ` [PULL 4/7] hw/misc/i2c-echo: add copyright/license note Thomas Huth
2023-10-12 16:51 ` [PULL 5/7] hw/misc/Kconfig: add switch for i2c-echo Thomas Huth
2023-10-12 16:51 ` [PULL 6/7] MAINTAINERS: Add include/sysemu/qtest.h to the qtest section Thomas Huth
2023-10-12 16:51 ` [PULL 7/7] gitlab-ci: Disable the riscv64-debian-cross-container by default Thomas Huth
2023-10-16 19:20 ` [PULL 0/7] Misc patches Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231012165108.913443-4-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=crauer@google.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).