From: Andrew Jones <ajones@ventanamicro.com>
To: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Cc: qemu-devel@nongnu.org, qemu-riscv@nongnu.org,
alistair.francis@wdc.com, bmeng@tinylab.org,
liweiwei@iscas.ac.cn, zhiwei_liu@linux.alibaba.com,
palmer@rivosinc.com
Subject: Re: [PATCH 0/4] target/riscv: rename ext_i* to ext_zi*
Date: Fri, 13 Oct 2023 08:37:30 +0200 [thread overview]
Message-ID: <20231013-f1376faaa53cd1336bfe7233@orel> (raw)
In-Reply-To: <20231012164604.398496-1-dbarboza@ventanamicro.com>
On Thu, Oct 12, 2023 at 01:46:00PM -0300, Daniel Henrique Barboza wrote:
> Hi,
>
> This series renames the following internal extensions flags:
>
> ext_ifencei, ext_icsr, ext_icbom, ext_icboz
>
> To add a leading 'z':
>
> ext_zifencei, ext_zicsr, ext_zicbom, ext_zicboz
>
> This was proposed by Andrew Jones. The motivation, in his own words:
>
> "I'd prefer we name the booleans with their 'z' to improve grepping.
> When one wants to search for uses of zifencei, I imagine they're more
> likely to do 'grep -i zifencei' than 'grep -i ifencei', particularly
> because the 's' is maintained for S extensions. "
>
>
> Aside from that, these are the only 4 Z-extension flags that don't use a
> leading 'z' in their name, so there's also the benefit of making
> everything equal.
>
For the series,
Reviewed-by: Andrew Jones <ajones@ventanamicro.com>
Thanks,
drew
next prev parent reply other threads:[~2023-10-13 6:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-12 16:46 [PATCH 0/4] target/riscv: rename ext_i* to ext_zi* Daniel Henrique Barboza
2023-10-12 16:46 ` [PATCH 1/4] target/riscv: rename ext_ifencei to ext_zifencei Daniel Henrique Barboza
2023-10-16 4:34 ` Alistair Francis
2023-10-12 16:46 ` [PATCH 2/4] target/riscv: rename ext_icsr to ext_zicsr Daniel Henrique Barboza
2023-10-16 4:35 ` Alistair Francis
2023-10-12 16:46 ` [PATCH 3/4] target/riscv: rename ext_icbom to ext_zicbom Daniel Henrique Barboza
2023-10-16 4:42 ` Alistair Francis
2023-10-12 16:46 ` [PATCH 4/4] target/riscv: rename ext_icboz to ext_zicboz Daniel Henrique Barboza
2023-10-16 4:42 ` Alistair Francis
2023-10-13 6:37 ` Andrew Jones [this message]
2023-10-16 5:00 ` [PATCH 0/4] target/riscv: rename ext_i* to ext_zi* Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231013-f1376faaa53cd1336bfe7233@orel \
--to=ajones@ventanamicro.com \
--cc=alistair.francis@wdc.com \
--cc=bmeng@tinylab.org \
--cc=dbarboza@ventanamicro.com \
--cc=liweiwei@iscas.ac.cn \
--cc=palmer@rivosinc.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).