qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
	"Fam Zheng" <fam@euphon.net>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Eric Blake" <eblake@redhat.com>,
	libvir-list@redhat.com, "Fabiano Rosas" <farosas@suse.de>,
	qemu-block@nongnu.org, "Peter Xu" <peterx@redhat.com>,
	"Leonardo Bras" <leobras@redhat.com>,
	"Dr. David Alan Gilbert" <dave@treblig.org>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Hailiang Zhang" <zhanghailiang@xfusion.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Juan Quintela" <quintela@redhat.com>
Subject: [PATCH v4 02/10] migration: Print block status when needed
Date: Fri, 13 Oct 2023 12:47:28 +0200	[thread overview]
Message-ID: <20231013104736.31722-3-quintela@redhat.com> (raw)
In-Reply-To: <20231013104736.31722-1-quintela@redhat.com>

The new line was only printed when command options were used.  When we
used migration parameters and capabilities, it wasn't.

Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 migration/migration-hmp-cmds.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/migration/migration-hmp-cmds.c b/migration/migration-hmp-cmds.c
index c115ef2d23..e0e16afa34 100644
--- a/migration/migration-hmp-cmds.c
+++ b/migration/migration-hmp-cmds.c
@@ -30,6 +30,7 @@
 #include "sysemu/runstate.h"
 #include "ui/qemu-spice.h"
 #include "sysemu/sysemu.h"
+#include "options.h"
 #include "migration.h"
 
 static void migration_global_dump(Monitor *mon)
@@ -682,7 +683,6 @@ void hmp_x_colo_lost_heartbeat(Monitor *mon, const QDict *qdict)
 typedef struct HMPMigrationStatus {
     QEMUTimer *timer;
     Monitor *mon;
-    bool is_block_migration;
 } HMPMigrationStatus;
 
 static void hmp_migrate_status_cb(void *opaque)
@@ -708,7 +708,7 @@ static void hmp_migrate_status_cb(void *opaque)
 
         timer_mod(status->timer, qemu_clock_get_ms(QEMU_CLOCK_REALTIME) + 1000);
     } else {
-        if (status->is_block_migration) {
+        if (migrate_block()) {
             monitor_printf(status->mon, "\n");
         }
         if (info->error_desc) {
@@ -748,7 +748,6 @@ void hmp_migrate(Monitor *mon, const QDict *qdict)
 
         status = g_malloc0(sizeof(*status));
         status->mon = mon;
-        status->is_block_migration = blk || inc;
         status->timer = timer_new_ms(QEMU_CLOCK_REALTIME, hmp_migrate_status_cb,
                                           status);
         timer_mod(status->timer, qemu_clock_get_ms(QEMU_CLOCK_REALTIME));
-- 
2.41.0



  parent reply	other threads:[~2023-10-13 10:49 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-13 10:47 [PATCH v4 00/10] Migration deprecated parts Juan Quintela
2023-10-13 10:47 ` [PATCH v4 01/10] migration: Improve json and formatting Juan Quintela
2023-10-13 12:48   ` Markus Armbruster
2023-10-13 10:47 ` Juan Quintela [this message]
2023-10-13 10:47 ` [PATCH v4 03/10] migration: migrate 'inc' command option is deprecated Juan Quintela
2023-10-13 13:09   ` Markus Armbruster
2023-10-16  7:00     ` Juan Quintela
2023-10-16  9:42       ` Markus Armbruster
2023-10-16 13:28         ` Juan Quintela
2023-10-17  5:53           ` Markus Armbruster
2023-10-13 10:47 ` [PATCH v4 04/10] migration: migrate 'blk' " Juan Quintela
2023-10-13 13:11   ` Markus Armbruster
2023-10-13 10:47 ` [PATCH v4 05/10] migration: Deprecate block migration Juan Quintela
2023-10-13 10:47 ` [PATCH v4 06/10] migration: Deprecate old compression method Juan Quintela
2023-10-13 10:47 ` [PATCH v4 07/10] [RFC] migration: Make -i/-b an error for hmp and qmp Juan Quintela
2023-10-13 10:47 ` [PATCH v4 08/10] [RFC] migration: Remove helpers needed for -i/-b migrate options Juan Quintela
2023-10-13 10:47 ` [PATCH v4 09/10] [RFC] migration: Remove support for block_incremental Juan Quintela
2023-10-13 10:47 ` [PATCH v4 10/10] [RFC] migration: Remove block migration support Juan Quintela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231013104736.31722-3-quintela@redhat.com \
    --to=quintela@redhat.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=dave@treblig.org \
    --cc=eblake@redhat.com \
    --cc=fam@euphon.net \
    --cc=farosas@suse.de \
    --cc=leobras@redhat.com \
    --cc=libvir-list@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=thuth@redhat.com \
    --cc=zhanghailiang@xfusion.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).