From: "Angel M. Villegas" <anvilleg@cisco.com>
To: qemu-devel@nongnu.org, anvilleg@cisco.com
Cc: michael.roth@amd.com, kkostiuk@redhat.com
Subject: [PATCH] guest-agent: improve help for --allow-rpcs and --block-rpcs
Date: Fri, 13 Oct 2023 11:51:10 -0400 [thread overview]
Message-ID: <20231013155110.23175-1-anvilleg@cisco.com> (raw)
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1757
Updates to qga help output and documentation for --allow-rpcs and --blocks-rpcs
Signed-off-by: Angel M. Villegas <anvilleg@cisco.com>
---
docs/interop/qemu-ga.rst | 8 ++++----
qga/main.c | 4 ++--
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/docs/interop/qemu-ga.rst b/docs/interop/qemu-ga.rst
index 461c5a35ee..72fb75a6f5 100644
--- a/docs/interop/qemu-ga.rst
+++ b/docs/interop/qemu-ga.rst
@@ -81,13 +81,13 @@ Options
.. option:: -b, --block-rpcs=LIST
- Comma-separated list of RPCs to disable (no spaces, use ``help`` to
- list available RPCs).
+ Comma-separated list of RPCs to disable (no spaces, use ``--block-rpcs=help``
+ to list available RPCs).
.. option:: -a, --allow-rpcs=LIST
- Comma-separated list of RPCs to enable (no spaces, use ``help`` to
- list available RPCs).
+ Comma-separated list of RPCs to enable (no spaces, use ``--allow-rpcs=help``
+ to list available RPCs).
.. option:: -D, --dump-conf
diff --git a/qga/main.c b/qga/main.c
index 8668b9f3d3..bdf5344584 100644
--- a/qga/main.c
+++ b/qga/main.c
@@ -261,9 +261,9 @@ QEMU_COPYRIGHT "\n"
" -s, --service service commands: install, uninstall, vss-install, vss-uninstall\n"
#endif
" -b, --block-rpcs comma-separated list of RPCs to disable (no spaces,\n"
-" use \"help\" to list available RPCs)\n"
+" use \"--block-rpcs=help\" to list available RPCs)\n"
" -a, --allow-rpcs comma-separated list of RPCs to enable (no spaces,\n"
-" use \"help\" to list available RPCs)\n"
+" use \"--allow-rpcs=help\" to list available RPCs)\n"
" -D, --dump-conf dump a qemu-ga config file based on current config\n"
" options / command-line parameters to stdout\n"
" -r, --retry-path attempt re-opening path if it's unavailable or closed\n"
--
2.39.2 (Apple Git-143)
next reply other threads:[~2023-10-13 15:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 15:51 Angel M. Villegas [this message]
2023-10-17 7:47 ` [PATCH] guest-agent: improve help for --allow-rpcs and --block-rpcs Konstantin Kostiuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231013155110.23175-1-anvilleg@cisco.com \
--to=anvilleg@cisco.com \
--cc=kkostiuk@redhat.com \
--cc=michael.roth@amd.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).