From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>,
Fam Zheng <fam@euphon.net>, Cleber Rosa <crosa@redhat.com>,
Eric Blake <eblake@redhat.com>,
Li Zhijian <lizhijian@fujitsu.com>, Peter Xu <peterx@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
John Snow <jsnow@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Juan Quintela <quintela@redhat.com>,
Leonardo Bras <leobras@redhat.com>,
Laurent Vivier <lvivier@redhat.com>,
Fabiano Rosas <farosas@suse.de>, Thomas Huth <thuth@redhat.com>
Subject: [PULL 09/38] migration: Fix analyze-migration read operation signedness
Date: Mon, 16 Oct 2023 12:06:37 +0200 [thread overview]
Message-ID: <20231016100706.2551-10-quintela@redhat.com> (raw)
In-Reply-To: <20231016100706.2551-1-quintela@redhat.com>
From: Fabiano Rosas <farosas@suse.de>
The migration code uses unsigned values for 16, 32 and 64-bit
operations. Fix the script to do the same.
This was causing an issue when parsing the migration stream generated
on the ppc64 target because one of instance_ids was larger than the
32bit signed maximum:
Traceback (most recent call last):
File "/home/fabiano/kvm/qemu/build/scripts/analyze-migration.py", line 658, in <module>
dump.read(dump_memory = args.memory)
File "/home/fabiano/kvm/qemu/build/scripts/analyze-migration.py", line 592, in read
classdesc = self.section_classes[section_key]
KeyError: ('spapr_iommu', -2147483648)
Signed-off-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Message-ID: <20231009184326.15777-6-farosas@suse.de>
---
scripts/analyze-migration.py | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/scripts/analyze-migration.py b/scripts/analyze-migration.py
index 56ab04dd2d..de506cb8bf 100755
--- a/scripts/analyze-migration.py
+++ b/scripts/analyze-migration.py
@@ -38,13 +38,13 @@ def __init__(self, filename):
self.file = open(self.filename, "rb")
def read64(self):
- return int.from_bytes(self.file.read(8), byteorder='big', signed=True)
+ return int.from_bytes(self.file.read(8), byteorder='big', signed=False)
def read32(self):
- return int.from_bytes(self.file.read(4), byteorder='big', signed=True)
+ return int.from_bytes(self.file.read(4), byteorder='big', signed=False)
def read16(self):
- return int.from_bytes(self.file.read(2), byteorder='big', signed=True)
+ return int.from_bytes(self.file.read(2), byteorder='big', signed=False)
def read8(self):
return int.from_bytes(self.file.read(1), byteorder='big', signed=True)
--
2.41.0
next prev parent reply other threads:[~2023-10-16 10:10 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 10:06 [PULL 00/38] Migration 20231016 patches Juan Quintela
2023-10-16 10:06 ` [PULL 01/38] migration: refactor migration_completion Juan Quintela
2023-10-16 10:06 ` [PULL 02/38] migration: Use g_autofree to simplify ram_dirty_bitmap_reload() Juan Quintela
2023-10-16 10:06 ` [PULL 03/38] migration: Allow user to specify available switchover bandwidth Juan Quintela
2023-10-16 10:06 ` [PULL 04/38] migration: fix RAMBlock add NULL check Juan Quintela
2023-10-16 10:06 ` [PULL 05/38] migration: Add the configuration vmstate to the json writer Juan Quintela
2023-10-16 10:06 ` [PULL 06/38] migration: Fix analyze-migration.py 'configuration' parsing Juan Quintela
2023-10-16 10:06 ` [PULL 07/38] migration: Add capability parsing to analyze-migration.py Juan Quintela
2023-10-16 10:06 ` [PULL 08/38] migration: Fix analyze-migration.py when ignore-shared is used Juan Quintela
2023-10-16 10:06 ` Juan Quintela [this message]
2023-10-16 10:06 ` [PULL 10/38] tests/qtest/migration: Add a test for the analyze-migration script Juan Quintela
2023-10-16 10:06 ` [PULL 11/38] tests/qtest: migration-test: Add tests for file-based migration Juan Quintela
2023-10-16 18:25 ` Fabiano Rosas
2023-10-17 7:21 ` Juan Quintela
2023-10-17 12:30 ` Fabiano Rosas
2023-10-17 12:55 ` Juan Quintela
2023-10-17 13:19 ` Fabiano Rosas
2023-10-17 13:30 ` Juan Quintela
2023-10-16 10:06 ` [PULL 12/38] migration: hold the BQL during setup Juan Quintela
2023-10-16 10:06 ` [PULL 13/38] migration: Non multifd migration don't care about multifd flushes Juan Quintela
2023-10-16 10:06 ` [PULL 14/38] migration: Create migrate_rdma() Juan Quintela
2023-10-16 10:06 ` [PULL 15/38] migration/rdma: Unfold ram_control_before_iterate() Juan Quintela
2023-10-16 10:06 ` [PULL 16/38] migration/rdma: Unfold ram_control_after_iterate() Juan Quintela
2023-10-16 10:06 ` [PULL 17/38] migration/rdma: Remove all uses of RAM_CONTROL_HOOK Juan Quintela
2023-10-16 10:06 ` [PULL 18/38] migration/rdma: Unfold hook_ram_load() Juan Quintela
2023-10-16 10:06 ` [PULL 19/38] migration/rdma: Create rdma_control_save_page() Juan Quintela
2023-10-16 10:06 ` [PULL 20/38] qemu-file: Remove QEMUFileHooks Juan Quintela
2023-10-16 10:06 ` [PULL 21/38] migration/rdma: Move rdma constants from qemu-file.h to rdma.h Juan Quintela
2023-10-16 10:06 ` [PULL 22/38] migration/rdma: Remove qemu_ prefix from exported functions Juan Quintela
2023-10-16 10:06 ` [PULL 23/38] migration/rdma: Check sooner if we are in postcopy for save_page() Juan Quintela
2023-10-16 10:06 ` [PULL 24/38] migration/rdma: Use i as for index instead of idx Juan Quintela
2023-10-16 10:06 ` [PULL 25/38] migration/rdma: Declare for index variables local Juan Quintela
2023-10-16 10:06 ` [PULL 26/38] migration/rdma: Remove all "ret" variables that are used only once Juan Quintela
2023-10-16 10:06 ` [PULL 27/38] migration: Improve json and formatting Juan Quintela
2023-10-16 10:06 ` [PULL 28/38] migration: check for rate_limit_max for RATE_LIMIT_DISABLED Juan Quintela
2023-10-16 10:06 ` [PULL 29/38] multifd: fix counters in multifd_send_thread Juan Quintela
2023-10-16 10:06 ` [PULL 30/38] multifd: reset next_packet_len after sending pages Juan Quintela
2023-10-16 10:06 ` [PULL 31/38] migration/ram: Refactor precopy ram loading code Juan Quintela
2023-10-16 10:07 ` [PULL 32/38] migration/ram: Remove RAMState from xbzrle_cache_zero_page Juan Quintela
2023-10-16 10:07 ` [PULL 33/38] migration/ram: Stop passing QEMUFile around in save_zero_page Juan Quintela
2023-10-16 10:07 ` [PULL 34/38] migration/ram: Move xbzrle zero page handling into save_zero_page Juan Quintela
2023-10-16 10:07 ` [PULL 35/38] migration/ram: Merge save_zero_page functions Juan Quintela
2023-10-16 10:07 ` [PULL 36/38] migration/multifd: Remove direct "socket" references Juan Quintela
2023-10-16 10:07 ` [PULL 37/38] migration/multifd: Unify multifd_send_thread error paths Juan Quintela
2023-10-16 10:07 ` [PULL 38/38] migration/multifd: Clarify Error usage in multifd_channel_connect Juan Quintela
2023-10-16 16:31 ` [PULL 00/38] Migration 20231016 patches Stefan Hajnoczi
2023-10-16 17:13 ` Fabiano Rosas
2023-10-16 19:18 ` Stefan Hajnoczi
2023-10-16 20:31 ` Fabiano Rosas
2023-10-17 7:24 ` Juan Quintela
2023-10-17 8:20 ` Thomas Huth
-- strict thread matches above, loose matches on Subject: below --
2023-10-17 8:29 [PULL 00/38] Migration 20231017 patches Juan Quintela
2023-10-17 8:29 ` [PULL 09/38] migration: Fix analyze-migration read operation signedness Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231016100706.2551-10-quintela@redhat.com \
--to=quintela@redhat.com \
--cc=armbru@redhat.com \
--cc=crosa@redhat.com \
--cc=eblake@redhat.com \
--cc=fam@euphon.net \
--cc=farosas@suse.de \
--cc=jsnow@redhat.com \
--cc=leobras@redhat.com \
--cc=lizhijian@fujitsu.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
--cc=vsementsov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).