From: Jonathan Cameron via <qemu-devel@nongnu.org> To: <qemu-devel@nongnu.org>, <linux-cxl@vger.kernel.org>, Michael Tsirkin <mst@redhat.com> Cc: linuxarm@huawei.com, "Fan Ni" <fan.ni@samsung.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, "Davidlohr Bueso" <dave@stgolabs.net>, "Gregory Price" <gregory.price@memverge.com>, "Klaus Jensen" <its@irrelevant.dk>, "Corey Minyard" <cminyard@mvista.com>, "Klaus Jensen" <k.jensen@samsung.com> Subject: Re: [PATCH 03/19] hw/cxl/mbox: Pull the CCI definition out of the CXLDeviceState Date: Mon, 16 Oct 2023 16:59:43 +0100 [thread overview] Message-ID: <20231016165943.000067f7@huawei.com> (raw) In-Reply-To: <20230925161124.18940-4-Jonathan.Cameron@huawei.com> On Mon, 25 Sep 2023 17:11:08 +0100 Jonathan Cameron <Jonathan.Cameron@huawei.com> wrote: > Enables having multiple CCIs per devices. Each CCI (mailbox) has it's own > state and command list, so they can't share a single structure. > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > --- I made a mess of reordering patches, so some of Davidlohr's BG ops patch ended up in this one and the next patch. I'll put that back where it should be in v2. > > +typedef struct CXLCCI { > + const struct cxl_cmd (*cxl_cmd_set)[256]; > + struct cel_log { > + uint16_t opcode; > + uint16_t effect; > + } cel_log[1 << 16]; > + size_t cel_size; > + > + /* background command handling (times in ms) */ > + struct { > + uint16_t opcode; > + uint16_t complete_pct; > + uint16_t ret_code; /* Current value of retcode */ > + uint64_t starttime; > + /* set by each bg cmd, cleared by the bg_timer when complete */ > + uint64_t runtime; > + QEMUTimer *timer; > + } bg; We don't have bg ops yet! > + size_t payload_max; > + /* Pointer to device hosting the CCI */ > + DeviceState *d; > + /* Pointer to the device hosting the protocol conversion */ > + DeviceState *intf; > +} CXLCCI; > +
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <Jonathan.Cameron@huawei.com> To: <qemu-devel@nongnu.org>, <linux-cxl@vger.kernel.org>, Michael Tsirkin <mst@redhat.com> Cc: linuxarm@huawei.com, "Fan Ni" <fan.ni@samsung.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, "Davidlohr Bueso" <dave@stgolabs.net>, "Gregory Price" <gregory.price@memverge.com>, "Klaus Jensen" <its@irrelevant.dk>, "Corey Minyard" <cminyard@mvista.com>, "Klaus Jensen" <k.jensen@samsung.com> Subject: Re: [PATCH 03/19] hw/cxl/mbox: Pull the CCI definition out of the CXLDeviceState Date: Mon, 16 Oct 2023 16:59:43 +0100 [thread overview] Message-ID: <20231016165943.000067f7@huawei.com> (raw) Message-ID: <20231016155943.ALvHRtFqBL0qd9-QkvvdDdMN86I5KXTiyq_6Hb5BcgU@z> (raw) In-Reply-To: <20230925161124.18940-4-Jonathan.Cameron@huawei.com> On Mon, 25 Sep 2023 17:11:08 +0100 Jonathan Cameron <Jonathan.Cameron@huawei.com> wrote: > Enables having multiple CCIs per devices. Each CCI (mailbox) has it's own > state and command list, so they can't share a single structure. > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > --- I made a mess of reordering patches, so some of Davidlohr's BG ops patch ended up in this one and the next patch. I'll put that back where it should be in v2. > > +typedef struct CXLCCI { > + const struct cxl_cmd (*cxl_cmd_set)[256]; > + struct cel_log { > + uint16_t opcode; > + uint16_t effect; > + } cel_log[1 << 16]; > + size_t cel_size; > + > + /* background command handling (times in ms) */ > + struct { > + uint16_t opcode; > + uint16_t complete_pct; > + uint16_t ret_code; /* Current value of retcode */ > + uint64_t starttime; > + /* set by each bg cmd, cleared by the bg_timer when complete */ > + uint64_t runtime; > + QEMUTimer *timer; > + } bg; We don't have bg ops yet! > + size_t payload_max; > + /* Pointer to device hosting the CCI */ > + DeviceState *d; > + /* Pointer to the device hosting the protocol conversion */ > + DeviceState *intf; > +} CXLCCI; > +
next prev parent reply other threads:[~2023-10-16 16:01 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-09-25 16:11 [PATCH 00/19] QEMU: CXL mailbox rework and features Jonathan Cameron via 2023-09-25 16:11 ` [PATCH 01/19] hw/cxl/mbox: Pull the payload out of struct cxl_cmd and make instances constant Jonathan Cameron via 2023-09-27 19:27 ` Fan Ni 2023-09-25 16:11 ` [PATCH 02/19] hw/cxl/mbox: Split mailbox command payload into separate input and output Jonathan Cameron via 2023-09-27 22:58 ` Fan Ni 2023-09-25 16:11 ` [PATCH 03/19] hw/cxl/mbox: Pull the CCI definition out of the CXLDeviceState Jonathan Cameron via 2023-09-28 17:44 ` Fan Ni 2023-10-16 15:59 ` Jonathan Cameron via [this message] 2023-10-16 15:59 ` Jonathan Cameron 2023-09-25 16:11 ` [PATCH 04/19] hw/cxl/mbox: Generalize the CCI command processing Jonathan Cameron via 2023-09-28 18:21 ` Fan Ni 2023-10-13 16:17 ` Jonathan Cameron via 2023-10-13 16:17 ` Jonathan Cameron 2023-09-25 16:11 ` [PATCH 05/19] hw/pci-bridge/cxl_upstream: Move defintion of device to header Jonathan Cameron via 2023-09-28 18:26 ` Fan Ni 2023-09-25 16:11 ` [PATCH 06/19] hw/cxl/i2c_mctp_cxl: Initial device emulation Jonathan Cameron via 2023-09-25 16:11 ` [PATCH 07/19] hw/cxl/mbox: Add Information and Status / Identify command Jonathan Cameron via 2023-09-25 16:11 ` [PATCH 08/19] docs: cxl: Add example commandline for MCTP CXL CCIs Jonathan Cameron via 2023-09-25 16:11 ` [PATCH 09/19] hw/cxl/mbox: Add Physical Switch Identify command Jonathan Cameron via 2023-09-25 16:11 ` [PATCH 10/19] hw/cxl: Add a switch mailbox CCI function Jonathan Cameron via 2023-09-25 16:11 ` [PATCH 11/19] hw/pci-bridge/cxl_downstream: Set default link width and link speed Jonathan Cameron via 2023-09-25 16:11 ` [PATCH 12/19] hw/cxl: Implement Physical Ports status retrieval Jonathan Cameron via 2023-09-27 13:55 ` Jonathan Cameron via 2023-09-25 16:11 ` [PATCH 13/19] hw/cxl/mbox: Add Get Background Operation Status Command Jonathan Cameron via 2023-09-25 16:11 ` [PATCH 14/19] hw/cxl/mbox: Add support for background operations Jonathan Cameron via 2023-09-25 16:11 ` [PATCH 15/19] hw/cxl/mbox: Wire up interrupts for background completion Jonathan Cameron via 2023-09-25 16:11 ` [PATCH 16/19] hw/cxl: Add support for device sanitation Jonathan Cameron via 2023-09-25 16:11 ` [PATCH 17/19] hw/cxl/type3: Cleanup multiple CXL_TYPE3() calls in read/write functions Jonathan Cameron via 2023-09-25 16:11 ` [PATCH 18/19] hw/cxl: Add dummy security state get Jonathan Cameron via 2023-09-25 16:11 ` [PATCH 19/19] hw/cxl: Add tunneled command support to mailbox for switch cci/mctp Jonathan Cameron via 2023-09-25 16:50 ` [PATCH 00/19] QEMU: CXL mailbox rework and features Jonathan Cameron via 2023-09-28 18:12 ` Gregory Price
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20231016165943.000067f7@huawei.com \ --to=qemu-devel@nongnu.org \ --cc=Jonathan.Cameron@huawei.com \ --cc=cminyard@mvista.com \ --cc=dave@stgolabs.net \ --cc=fan.ni@samsung.com \ --cc=gregory.price@memverge.com \ --cc=its@irrelevant.dk \ --cc=k.jensen@samsung.com \ --cc=linux-cxl@vger.kernel.org \ --cc=linuxarm@huawei.com \ --cc=mst@redhat.com \ --cc=philmd@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).